Libravatar: Lazy-load LWP::UserAgent

LWP::UserAgent costs about 0.05s to load, but we only need it when the
image is not already cached locally.  Given we cache results for an
hour, it is fairly likely to be cached on subsequent requests.

Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/Debbugs/Libravatar.pm b/Debbugs/Libravatar.pm
index d0510900eda0c43ce001991a8229df6815fde89b..4c4bcd0a66f8ae57d2e2a46649a5f292228b242f 100644 (file)
--- a/Debbugs/Libravatar.pm
+++ b/Debbugs/Libravatar.pm
@@ -39,7 +39,6 @@ use Libravatar::URL;
 use CGI::Simple;
 use Debbugs::CGI qw(cgi_parameters);
 use Digest::MD5 qw(md5_hex);
-use LWP::UserAgent;
 use File::Temp qw(tempfile);
 use File::LibMagic;
 use Cwd qw(abs_path);
@@ -109,6 +108,8 @@ sub retrieve_libravatar{
             return $temp_location;
         }
     }
+    require LWP::UserAgent;
+
     my $dest_type;
     eval {
         my $uri = libravatar_url(email => $param{email},

diff --git a/cgi/libravatar.cgi b/cgi/libravatar.cgi
index c0ff013013220b4aa104c55696c1e870d93f0daa..276b3925fee74f07a658a9f595b457f66548ada0 100755 (executable)
--- a/cgi/libravatar.cgi
+++ b/cgi/libravatar.cgi
@@ -13,7 +13,6 @@ use Debbugs::Libravatar qw(:libravatar);
 
 use Libravatar::URL;
 
-use LWP::UserAgent;
 use HTTP::Request;
 
 use CGI::Simple;