X-Git-Url: https://git.donarmstrong.com/?a=blobdiff_plain;f=cgi%2Fbugreport.cgi;h=be375255af875e285d9a983b09d4f0bfb15372ae;hb=1cda40c7b331de6c31df360b48ed28cbc7b4db5a;hp=3490dffd83224dade99c7bbf12c8207a35834a76;hpb=2a887c5bf4f0bfb6fdf8eb02d1ce80bc3a1155b1;p=debbugs.git diff --git a/cgi/bugreport.cgi b/cgi/bugreport.cgi index 3490dff..9064ca8 100755 --- a/cgi/bugreport.cgi +++ b/cgi/bugreport.cgi @@ -1,327 +1,414 @@ -#!/usr/bin/perl -wT - -package debbugs; +#!/usr/bin/perl +use warnings; use strict; -use POSIX qw(strftime tzset); + +# Sanitize environent for taint +BEGIN{ + delete @ENV{qw(IFS CDPATH ENV BASH_ENV)}; +} + + +use POSIX qw(strftime); use MIME::Parser; use MIME::Decoder; use IO::Scalar; +use IO::File; + +use Debbugs::Config qw(:globals :text); + +# for read_log_records +use Debbugs::Log qw(read_log_records); +use Debbugs::CGI qw(:url :html :util); +use Debbugs::CGI::Bugreport qw(:all); +use Debbugs::Common qw(buglog getmaintainers make_list bug_status); +use Debbugs::Packages qw(getpkgsrc); +use Debbugs::Status qw(splitpackages split_status_fields get_bug_status isstrongseverity); + +use Debbugs::User; + +use Scalar::Util qw(looks_like_number); + +use Debbugs::Text qw(:templates); + +use List::Util qw(max); + + +use CGI::Simple; +my $q = new CGI::Simple; +# STDOUT should be using the utf8 io layer +binmode(STDOUT,':raw:encoding(UTF-8)'); + +my %param = cgi_parameters(query => $q, + single => [qw(bug msg att boring terse), + qw(reverse mbox mime trim), + qw(mboxstat mboxmaint archive), + qw(repeatmerged avatars), + ], + default => {# msg => '', + boring => 'no', + terse => 'no', + reverse => 'no', + mbox => 'no', + mime => 'no', + mboxstat => 'no', + mboxmaint => 'no', + archive => 'no', + repeatmerged => 'yes', + avatars => 'yes', + }, + ); +# This is craptacular. + +my $ref = $param{bug} or quitcgi("No bug number"); +$ref =~ /(\d+)/ or quitcgi("Invalid bug number"); +$ref = $1; +my $short = "#$ref"; +my ($msg) = $param{msg} =~ /^(\d+)$/ if exists $param{msg}; +my ($att) = $param{att} =~ /^(\d+)$/ if exists $param{att}; +my $boring = $param{'boring'} eq 'yes'; +my $terse = $param{'terse'} eq 'yes'; +my $reverse = $param{'reverse'} eq 'yes'; +my $mbox = $param{'mbox'} eq 'yes'; +my $mime = $param{'mime'} eq 'yes'; +my $avatars = $param{avatars} eq 'yes'; + +my %bugusertags; +my %ut; +my %seen_users; -#require '/usr/lib/debbugs/errorlib'; -require './common.pl'; +my $buglog = buglog($ref); +my $bug_status = bug_status($ref); +if (not defined $buglog or not defined $bug_status) { + print $q->header(-status => "404 No such bug", + -type => "text/html", + -charset => 'utf-8', + ); + print fill_in_template(template=>'cgi/no_such_bug', + variables => {modify_time => strftime('%a, %e %b %Y %T UTC', gmtime), + bug_num => $ref, + }, + ); + exit 0; +} -require '/etc/debbugs/config'; -require '/etc/debbugs/text'; +# the log should almost always be newer, but just in case +my $log_mtime = +(stat $buglog)[9] || time; +my $status_mtime = +(stat $bug_status)[9] || time; +my $mtime = strftime '%a, %d %b %Y %T GMT', gmtime(max($status_mtime,$log_mtime)); + +if ($q->request_method() eq 'HEAD' and not defined($att) and not $mbox) { + print $q->header(-type => "text/html", + -charset => 'utf-8', + (length $mtime)?(-last_modified => $mtime):(), + ); + exit 0; +} -use vars(qw($gHTMLTail $gWebDomain)); +for my $user (map {split /[\s*,\s*]+/} make_list($param{users}||[])) { + next unless length($user); + add_user($user,\%ut,\%bugusertags,\%seen_users); +} -my %param = readparse(); +if (defined $param{usertag}) { + for my $usertag (make_list($param{usertag})) { + my %select_ut = (); + my ($u, $t) = split /:/, $usertag, 2; + Debbugs::User::read_usertags(\%select_ut, $u); + unless (defined $t && $t ne "") { + $t = join(",", keys(%select_ut)); + } + add_user($u,\%ut,\%bugusertags,\%seen_users); + push @{$param{tag}}, split /,/, $t; + } +} -my $tail_html; -my %maintainer = %{getmaintainers()}; -my %pkgsrc = %{getpkgsrc()}; +my $trim_headers = ($param{trim} || ((defined $msg and $msg)?'no':'yes')) eq 'yes'; -my $ref = $param{'bug'} || quit("No bug number"); -my $msg = $param{'msg'} || ""; -my $att = $param{'att'} || "0"; -my $boring = ($param{'boring'} || 'no') eq 'yes'; -my $reverse = ($param{'reverse'} || 'no') eq 'yes'; -my $mbox = ($param{'mbox'} || 'no') eq 'yes'; +my $mbox_status_message = $param{mboxstat} eq 'yes'; +my $mbox_maint = $param{mboxmaint} eq 'yes'; +$mbox = 1 if $mbox_status_message or $mbox_maint; -my %status = %{getbugstatus($ref)} or &quit("Couldn't get bug status: $!"); -my $indexentry; -my $descriptivehead; -my $submitted; -my $showseverity; +# Not used by this script directly, but fetch these so that pkgurl() and +# friends can propagate them correctly. +my $archive = $param{'archive'} eq 'yes'; +my $repeatmerged = $param{'repeatmerged'} eq 'yes'; -my $tpack; -my $tmain; -$ENV{"TZ"} = 'UTC'; -tzset(); -my $dtime = strftime "%a, %e %b %Y %T UTC", localtime; -$tail_html = $debbugs::gHTMLTail; -$tail_html =~ s/SUBSTITUTE_DTIME/$dtime/; +my $buglogfh; +if ($buglog =~ m/\.gz$/) { + my $oldpath = $ENV{'PATH'}; + $ENV{'PATH'} = '/bin:/usr/bin'; + $buglogfh = IO::File->new("zcat $buglog |") or quitcgi("open log for $ref: $!"); + $ENV{'PATH'} = $oldpath; +} else { + $buglogfh = IO::File->new($buglog,'r') or quitcgi("open log for $ref: $!"); +} -$|=1; -$tpack = lc $status{'package'}; -$tpack =~ s/[^-+._a-z0-9()].*$//; +my %status = + %{split_status_fields(get_bug_status(bug=>$ref, + bugusertags => \%bugusertags, + ))}; -if ($status{severity} eq 'normal') { - $showseverity = ''; -#} elsif (grep($status{severity} eq $_, @strongseverities)) { -# $showseverity = "Severity: $status{severity};\n"; -} else { - $showseverity = "Severity: $status{severity};\n"; +my @records; +eval{ + @records = read_log_records($buglogfh); +}; +if ($@) { + quitcgi("Bad bug log for $gBug $ref. Unable to read records: $@"); } +undef $buglogfh; + -$indexentry .= $showseverity; -$indexentry .= "Package: " - .htmlsanit($status{package}).";\n"; - -$indexentry .= "Reported by: " . htmlsanit($status{originator}) . ""; -$indexentry .= ";\nTags: " - . htmlsanit(join(", ", sort(split(/\s+/, $status{tags})))) - . "" - if length($status{tags}); - -my @merged= split(/ /,$status{mergedwith}); -if (@merged) { - my $mseparator= ";\nmerged with "; - for my $m (@merged) { - $indexentry .= $mseparator."#$m"; - $mseparator= ",\n"; - } +my $log=''; +my $msg_num = 0; +my $skip_next = 0; +if (defined($msg) and ($msg-1) <= $#records) { + @records = ($records[$msg-1]); + $msg_num = $msg - 1; +} +my @log; +if ( $mbox ) { + binmode(STDOUT,":raw"); + my $date = strftime "%a %b %d %T %Y", localtime; + if (@records > 1) { + print $q->header(-type => "text/plain", + content_disposition => qq(attachment; filename="bug_${ref}.mbox"), + (length $mtime)?(-last_modified => $mtime):(), + ); + } + else { + $msg_num++; + print $q->header(-type => "message/rfc822", + content_disposition => qq(attachment; filename="bug_${ref}_message_${msg_num}.mbox"), + (length $mtime)?(-last_modified => $mtime):(), + ); + } + if ($mbox_status_message and @records > 1) { + my $status_message=''; + my @status_fields = (retitle => 'subject', + package => 'package', + submitter => 'originator', + severity => 'severity', + tag => 'tags', + owner => 'owner', + blocks => 'blocks', + forward => 'forward', + ); + my ($key,$value); + while (($key,$value) = splice(@status_fields,0,2)) { + if (defined $status{$value} and length $status{$value}) { + $status_message .= qq($key $ref $status{$value}\n); + } + } + print STDOUT qq(From unknown $date\n), + create_mime_message([From => "$gBug#$ref <$ref\@$gEmailDomain>", + To => "$gBug#$ref <$ref\@$gEmailDomain>", + Subject => "Status: $status{subject}", + "Reply-To" => "$gBug#$ref <$ref\@$gEmailDomain>", + ], + <{type} !~ /^(?:recips|incoming-recv)$/; + my $wanted_type = $mbox_maint?'recips':'incoming-recv'; + # we want to include control messages anyway + my $record_wanted_anyway = 0; + my ($msg_id) = $record->{text} =~ /^Message-Id:\s+<(.+)>/im; + next if defined $msg_id and exists $seen_message_ids{$msg_id}; + next if defined $msg_id and $msg_id =~/handler\..+\.ack(?:info|done)?\@/; + $record_wanted_anyway = 1 if $record->{text} =~ /^Received: \(at control\)/; + next if not $boring and not $record->{type} eq $wanted_type and not $record_wanted_anyway and @records > 1; + $seen_message_ids{$msg_id} = 1 if defined $msg_id; + my @lines = split( "\n", $record->{text}, -1 ); + if ( $lines[ 1 ] =~ m/^From / ) { + my $tmp = $lines[ 0 ]; + $lines[ 0 ] = $lines[ 1 ]; + $lines[ 1 ] = $tmp; + } + if ( !( $lines[ 0 ] =~ m/^From / ) ) { + unshift @lines, "From unknown $date"; + } + map { s/^(>*From )/>$1/ } @lines[ 1 .. $#lines ]; + print join( "\n", @lines ) . "\n"; + } + exit 0; } -my $dummy = strftime "%a, %e %b %Y %T UTC", localtime($status{date}); -$submitted = ";\ndated ".$dummy; +else { + if (defined $att and defined $msg and @records) { + binmode(STDOUT,":raw"); + $msg_num++; + print handle_email_message($records[0]->{text}, + ref => $ref, + msg_num => $msg_num, + att => $att, + msg => $msg, + trim_headers => $trim_headers, + ); + exit 0; + } + my %seen_msg_ids; + for my $record (@records) { + $msg_num++; + if ($skip_next) { + $skip_next = 0; + next; + } + $skip_next = 1 if $record->{type} eq 'html' and not $boring; + push @log, handle_record($record,$ref,$msg_num, + \%seen_msg_ids, + trim_headers => $trim_headers, + avatars => $avatars, + ); + } +} + +@log = reverse @log if $reverse; +$log = join("\n",@log); + + +# All of the below should be turned into a template + +my %maintainer = %{getmaintainers()}; +my %pkgsrc = %{getpkgsrc()}; + +my $indexentry; +my $showseverity; + +my $tpack; +my $tmain; -if (length($status{done})) { - $indexentry .= ";\nDone: ".htmlsanit($status{done}); -} elsif (length($status{forwarded})) { - $indexentry .= ";\nForwarded to ".htmlsanit($status{forwarded}); +my $dtime = strftime "%a, %e %b %Y %T UTC", gmtime; + +unless (%status) { + print $q->header(-type => "text/html", + -charset => 'utf-8', + (length $mtime)?(-last_modified => $mtime):(), + ); + print fill_in_template(template=>'cgi/no_such_bug', + variables => {modify_time => $dtime, + bug_num => $ref, + }, + ); + exit 0; } -my ($short, $tmaint, $tsrc); -$short = $ref; $short =~ s/^\d+/#$&/; -$tmaint = defined($maintainer{$tpack}) ? $maintainer{$tpack} : '(unknown)'; -$tsrc = defined($pkgsrc{$tpack}) ? $pkgsrc{$tpack} : '(unknown)'; -$descriptivehead= $indexentry.$submitted.";\nMaintainer for $status{package} is\n". - ''.htmlsanit($tmaint).''; -$descriptivehead.= ";\n
Source for $status{package} is\n". - '$tsrc"; -$descriptivehead.= "."; +#$|=1; + + +my @packages = make_list($status{package}); + + +my %packages_affects; +for my $p_a (qw(package affects)) { + foreach my $pkg (make_list($status{$p_a})) { + if ($pkg =~ /^src\:/) { + my ($srcpkg) = $pkg =~ /^src:(.*)/; + $packages_affects{$p_a}{$pkg} = + {maintainer => exists($maintainer{$srcpkg}) ? $maintainer{$srcpkg} : '(unknown)', + source => $srcpkg, + package => $pkg, + is_source => 1, + }; + } + else { + $packages_affects{$p_a}{$pkg} = + {maintainer => exists($maintainer{$pkg}) ? $maintainer{$pkg} : '(unknown)', + exists($pkgsrc{$pkg}) ? (source => $pkgsrc{$pkg}) : (), + package => $pkg, + }; + } + } +} -my $buglog = buglog($ref); -open L, "<$buglog" or &quit("open log for $ref: $!"); +# fixup various bits of the status +$status{tags_array} = [sort(make_list($status{tags}))]; +$status{date_text} = strftime('%a, %e %b %Y %T UTC', gmtime($status{date})); +$status{mergedwith_array} = [make_list($status{mergedwith})]; + + +my $version_graph = ''; +if (@{$status{found_versions}} or @{$status{fixed_versions}}) { + $version_graph = q(version graph}; +} -my $log=''; -my $xmessage = 1; -my $suppressnext = 0; - -my $thisheader = ''; -my $this = ''; - -my $cmsg = 1; - -my $normstate= 'kill-init'; -my $linenum = 0; -my $mail = ''; -my @mails = (); -while(my $line = ) { - $linenum++; - if ($line =~ m/^.$/ and 1 <= ord($line) && ord($line) <= 7) { - # state transitions - my $newstate; - my $statenum = ord($line); - - $newstate = 'autocheck' if ($statenum == 1); - $newstate = 'recips' if ($statenum == 2); - $newstate = 'kill-end' if ($statenum == 3); - $newstate = 'go' if ($statenum == 5); - $newstate = 'html' if ($statenum == 6); - $newstate = 'incoming-recv' if ($statenum == 7); - - # disallowed transitions: - $_ = "$normstate $newstate"; - unless (m/^(go|go-nox|html) kill-end$/ - || m/^(kill-init|kill-end) (incoming-recv|autocheck|recips|html)$/ - || m/^kill-body go$/) - { - &quit("$ref: Transition from $normstate to $newstate at $linenum disallowed"); - } - - if ($newstate eq 'go') { - $this .= "
\n";
-		}
-
-		if ($newstate eq 'html') {
-			$this = '';
-		}
-
-		if ($newstate eq 'kill-end') {
-
-			my $show = 1;
-			$show = $boring
-				if ($suppressnext && $normstate ne 'html');
-
-			$show = ($xmessage == $msg) if ($msg);
-
-			push @mails, $mail if ( $mbox && $mail );
-			if ($show) {
-				my $downloadHtml = '';
-				if ($mail) {
-					my $parser = new MIME::Parser;
-					$parser->tmp_to_core(1);
-					$parser->output_to_core(1);
-#					$parser->output_under("/tmp");
-					my $entity = $parser->parse_data($mail);
-					# TODO: make local subdir, clean it outselves
-					# the following does NOT delete the msg dirs in /tmp
-					END { $entity->purge; $parser->filer->purge; }
-					my @attachments = ();
-					if ( $entity->is_multipart ) {
-						my @parts = $entity->parts_DFS;
-#						$this .= htmlsanit($entity->head->stringify);
-						my @keep = ();
-						foreach ( @parts ) {
-							my $head = $_->head;
-#							$head->mime_attr("content-transfer-encoding" => "8bit")
-#								if !$head->mime_attr("content-transfer-encoding");
-							my ($disposition,$type) = (
-								$head->mime_attr("content-disposition"),
-								lc $head->mime_attr("content-type")
-								);
-							
-#print STDERR "'$type' '$disposition'\n";
-							if ($disposition && ( $disposition eq "attachment" || $disposition eq "inline" ) && $_->head->recommended_filename ) {
-								push @attachments, $_;
-								my $file = $_->head->recommended_filename;
-								$downloadHtml .= "View Attachment: $file\n";
-								if ($msg && $att eq $#attachments) {
-									my $head = $_->head;
-									my $type;
-									chomp($type = $head->mime_attr("content-type"));
-									my $body = $_->stringify_body;
-									print "Content-Type: $type; name=$file\n\n";
-									my $decoder = new MIME::Decoder($head->mime_encoding);
-									$decoder->decode(new IO::Scalar(\$body), \*STDOUT);
-									exit(0);
-								}
-								if ($type eq 'text/plain') {
-#									push @keep, $_;
-								}
-#								$this .= htmlsanit($_->head->stringify);
-							} else {
-#								$this .= htmlsanit($_->head->stringify);
-#								push @keep, $_;
-							}
-#							$this .= "\n" . htmlsanit($_->stringify_body);
-						}
-#						$entity->parts(\@keep) if (!$msg);
-					}
-					$this .= htmlsanit($entity->stringify);
-				}
-				$this = "$downloadHtml\n$this$downloadHtml" if $downloadHtml;
-				$downloadHtml = '';
-				$this = "
\n$this
\n" - if $normstate eq 'go' || $normstate eq 'go-nox'; - $this = "$thisheader$this" if $thisheader && !( $normstate eq 'html' );; - $thisheader = ''; - if ($normstate eq 'html') { - $this .= " Full text available."; - } - if ($reverse) { - $log = "$this\n
$log"; - } else { - $log .= "$this\n
\n"; - } - } - - $xmessage++ if ($normstate ne 'html'); - - $suppressnext = $normstate eq 'html'; - } - - $normstate = $newstate; - $mail = ''; - next; - } - - $_ = $line; - if ($normstate eq 'incoming-recv') { - my $pl= $_; - $pl =~ s/\n+$//; - m/^Received: \(at (\S+)\) by (\S+)\;/ - || &quit("bad line \`$pl' in state incoming-recv"); - $thisheader = "

Message received at ".htmlsanit("$1\@$2") - . ":

\n"; - $this = ''; - $normstate= 'go'; - $mail .= $_; - } elsif ($normstate eq 'html') { - $this .= $_; - } elsif ($normstate eq 'go') { - if ($mail) { - $mail .= $_; - } else { - $this .= htmlsanit($_); - } - } elsif ($normstate eq 'go-nox') { - next if !s/^X//; - if ($mail) { - $mail .= $_; - } else { - $this .= htmlsanit($_); - } - } elsif ($normstate eq 'recips') { - if (m/^-t$/) { - $this = "

Message sent:

\n"; - } else { - s/\04/, /g; s/\n$//; - $this = "

Message sent to ".htmlsanit($_).":

\n"; - } - $normstate= 'kill-body'; - } elsif ($normstate eq 'autocheck') { - next if !m/^X-Debian-Bugs(-\w+)?: This is an autoforward from (\S+)/; - $normstate= 'autowait'; - $this = "

Message received at $2:

\n"; - } elsif ($normstate eq 'autowait') { - next if !m/^$/; - $normstate= 'go-nox'; - $this .= "
\n";
-	} else {
-		&quit("$ref state $normstate line \`$_'");
-	}
+
+my @blockedby= make_list($status{blockedby});
+$status{blockedby_array} = [];
+if (@blockedby && $status{"pending"} ne 'fixed' && ! length($status{done})) {
+    for my $b (@blockedby) {
+        my %s = %{get_bug_status($b)};
+        next if $s{"pending"} eq 'fixed' || length $s{done};
+	push @{$status{blockedby_array}},{bug_num => $b, subject => $s{subject}, status => \%s};
+   }
 }
-&quit("$ref state $normstate at end") unless $normstate eq 'kill-end';
-close(L);
 
-if ( $mbox ) {
-	print "Content-Type: text/plain\n\n";
-	foreach ( @mails ) {
-		my @lines = split( "\n", $_, -1 );
-		if ( $lines[ 1 ] =~ m/^From / ) {
-			my $tmp = $lines[ 0 ];
-			$lines[ 0 ] = $lines[ 1 ];
-			$lines[ 1 ] = $tmp;
-			$_ = join( "\n", @lines ) . "\n";
-		}
-		if ( !( $lines[ 0 ] =~ m/^From / ) ) {
-			$ENV{ PATH } = "/bin:/usr/bin:/usr/local/bin";
-			my $date = `date "+%a %b %d %T %Y"`;
-			chomp $date;
-			$_ = "From unknown $date\n" . $_;
-		}
-	}
-	print join("", @mails );
-	exit 0;
+my @blocks= make_list($status{blocks});
+$status{blocks_array} = [];
+if (@blocks && $status{"pending"} ne 'fixed' && ! length($status{done})) {
+    for my $b (@blocks) {
+        my %s = %{get_bug_status($b)};
+        next if $s{"pending"} eq 'fixed' || length $s{done};
+	push @{$status{blocks_array}}, {bug_num => $b, subject => $s{subject}, status => \%s};
+    }
 }
-print "Content-Type: text/html\n\n";
-
-print "\n";
-print "\n" . 
-    "$debbugs::gProject $debbugs::gBug report logs - $short\n" .
-    "\n" .
-    '' .
-    "\n";
-print "

" . "$debbugs::gProject $debbugs::gBug report logs - $short" . - "
" . htmlsanit($status{subject}) . "

\n"; - -print "$descriptivehead\n"; -printf "

View this report as an mbox folder.

", mboxurl($ref); -print "
"; -print "$log"; -print $tail_html; - -print "\n"; - -exit 0; + +if ($buglog !~ m#^\Q$gSpoolDir/db#) { + $status{archived} = 1; +} + +my $descriptivehead = $indexentry; + +print $q->header(-type => "text/html", + -charset => 'utf-8', + (length $mtime)?(-last_modified => $mtime):(), + ); + +print fill_in_template(template => 'cgi/bugreport', + variables => {status => \%status, + package => $packages_affects{'package'}, + affects => $packages_affects{'affects'}, + log => $log, + bug_num => $ref, + version_graph => $version_graph, + msg => $msg, + isstrongseverity => \&Debbugs::Status::isstrongseverity, + html_escape => \&Debbugs::CGI::html_escape, + looks_like_number => \&Scalar::Util::looks_like_number, + make_list => \&Debbugs::Common::make_list, + }, + hole_var => {'&package_links' => \&Debbugs::CGI::package_links, + '&bug_links' => \&Debbugs::CGI::bug_links, + '&version_url' => \&Debbugs::CGI::version_url, + '&bug_url' => \&Debbugs::CGI::bug_url, + '&strftime' => \&POSIX::strftime, + '&maybelink' => \&Debbugs::CGI::maybelink, + }, + );