From: Graham Percival <graham@percival-music.ca>
Date: Fri, 9 Dec 2011 05:34:56 +0000 (-0800)
Subject: Avoid comparison of unsigned < 0
X-Git-Tag: release/2.15.22-1~8
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=59c56667425ec6fae59655cf01ee724e024c0ebd;p=lilypond.git

Avoid comparison of unsigned < 0

  PyArg_ParseTuple (args, "s#|i", &track, &track_size, ...
returns the length as an int:
  http://docs.python.org/c-api/arg.html#PyArg_ParseTuple
---

diff --git a/python/midi.c b/python/midi.c
index 187268b78e..0a8599d0e2 100644
--- a/python/midi.c
+++ b/python/midi.c
@@ -356,7 +356,7 @@ static PyObject *
 pymidi_parse_track (PyObject *self, PyObject *args)
 {
   unsigned char *track, *track_end;
-  unsigned long track_size;
+  int track_size;
   int clocks_max;
 
   debug_print ("%s", "\n");
@@ -398,9 +398,11 @@ midi_parse (unsigned char **midi,unsigned  char *midi_end, int clocks_max)
   division = get_number (midi, *midi + 2, 2) * 4;
 
 
+  /*
   if (division < 0)
-    /* return midi_error (cannot handle non-metrical time"); */
+    return midi_error (cannot handle non-metrical time");
     ;
+  */
   *midi += header_len - 6;
 
   pymidi = PyList_New (0);