Tuplet brackets should reliably not follow kneed beams, regardless of whether Beam...

This affects input/regression/tuplet-number-kneed-beam-horizontal-fit,
and the following:
{
  \override TupletBracket.bracket-visibility = ##t
  \times 1/2 { c8 c''' c c''' }
}

Is it safe to call Beam::is_knee in Tuplet_bracket::calc_position_and_height?

diff --git a/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly b/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly
index db09b94e234ba9f936e61b5b82d64b16033b365c..21f17d18279ce674d9427cad9e599ed732ad1a8d 100644 (file)
--- a/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly
+++ b/input/regression/tuplet-number-kneed-beam-horizontal-fit.ly
@@ -3,7 +3,10 @@
 \header {
   texidoc = "Tuplet numbers are placed next to the beam unless there is
 insufficient horizontal space for them, in which case bracket-based
-positioning is used and a programming error is issued."
+positioning is used and a programming error is issued.
+
+The first tuplet number should be between stems; the second should be
+below the noteheads."
 }
 
 #(ly:expect-warning (_ "not enough space for tuplet number against beam"))

diff --git a/lily/tuplet-bracket.cc b/lily/tuplet-bracket.cc
index f4b4456812d0c45130a446d894cba119be12903f..04e67fbdecd781138e098877c997ec78b69c8daa 100644 (file)
--- a/lily/tuplet-bracket.cc
+++ b/lily/tuplet-bracket.cc
@@ -523,7 +523,7 @@ Tuplet_bracket::calc_position_and_height (Grob *me_grob, Real *offset, Real *dy)
   Real x1 = robust_relative_extent (rgr, commonx, X_AXIS)[RIGHT];
   bool follow_beam = par_beam
                      && get_grob_direction (par_beam) == dir
-                     && !to_boolean (par_beam->get_property ("knee"));
+                     && !Beam::is_knee (par_beam);
 
   vector<Offset> points;
   if (columns.size ()