From: Hilko Bengen Date: Wed, 30 Mar 2011 18:39:46 +0000 (+0200) Subject: perlcritic: Variable declared in conditional statement X-Git-Url: https://git.donarmstrong.com/?p=wannabuild.git;a=commitdiff_plain;h=268c80fda1e7620c658adb9106095ca64674ea17 perlcritic: Variable declared in conditional statement This should not cause any behavioral changes. --- diff --git a/lib/WB/QD.pm b/lib/WB/QD.pm index 25d2fb0..58b4527 100644 --- a/lib/WB/QD.pm +++ b/lib/WB/QD.pm @@ -52,8 +52,9 @@ sub readsourcebins { if ($srcs->{$p->{'name'}}) { next if (vercmp($srcs->{$p->{'name'}}->{'version'}, $p->{'version'}) > 0); } - my @a = split(/,? /, $p->{'binary'}) if $p->{'binary'}; - $p->{'binary'} = \@a; + if ($p->{'binary'}) { + $p->{'binary'} = [ split(/,? /, $p->{'binary'}) ]; + } $srcs->{$p->{'name'}} = $p; } close $S;