]> git.donarmstrong.com Git - wannabuild.git/commitdiff
perlcritic: Variable declared in conditional statement
authorHilko Bengen <bengen@debian.org>
Wed, 30 Mar 2011 18:39:46 +0000 (20:39 +0200)
committerAndreas Barth <aba@not.so.argh.org>
Wed, 30 Mar 2011 19:42:07 +0000 (21:42 +0200)
This should not cause any behavioral changes.

lib/WB/QD.pm

index 25d2fb0234e3f7e0db684ed6dee4b8e81619614c..58b452788f39a0b813434908449c46bfecee5794 100644 (file)
@@ -52,8 +52,9 @@ sub readsourcebins {
             if ($srcs->{$p->{'name'}}) {
                 next if (vercmp($srcs->{$p->{'name'}}->{'version'}, $p->{'version'}) > 0);
             }
-            my @a = split(/,? /, $p->{'binary'}) if $p->{'binary'};
-            $p->{'binary'} = \@a;
+            if ($p->{'binary'}) {
+                $p->{'binary'} = [ split(/,? /, $p->{'binary'}) ];
+            }
             $srcs->{$p->{'name'}} = $p;
         }
         close $S;