]> git.donarmstrong.com Git - qmk_firmware.git/commit
Simplify split_common Code significantly (#4772)
authorJames Churchill <pelrun@gmail.com>
Thu, 17 Jan 2019 18:08:14 +0000 (04:08 +1000)
committerDrashna Jaelre <drashna@live.com>
Thu, 17 Jan 2019 18:08:14 +0000 (10:08 -0800)
commit28929ad0174bdcb38e09f6d272a23b9be6aa430c
tree3d3568df6a3f7292ccfcedd616cb1bbc8839804c
parent5fcca9a226b2ab0b1335396e25c37e4b2a261a06
Simplify split_common Code significantly (#4772)

* Eliminate separate slave loop

Both master and slave run the standard keyboard_task main loop now.

* Refactor i2c/serial specific code

Simplify some of the preprocessor mess by using common function names.

* Fix missing #endif

* Move direct pin mapping support from miniaxe to split_common

For boards with more pins than sense--sorry, switches.

* Reordering and reformatting only

* Don't run matrix_scan_quantum on slave side

* Clean up the offset/slaveOffset calculations

* Cut undebounced matrix size in half

* Refactor debouncing

* Minor fixups

* Split split_common transport and debounce code into their own files

Can now be replaced with custom versions per keyboard using
CUSTOM_TRANSPORT = yes and CUSTOM_DEBOUNCE = yes

* Refactor debounce for non-split keyboards too

* Update handwired/xealous to build using new split_common

* Fix debounce breaking basic test

* Dodgy method to allow a split kb to only include one of i2c/serial

SPLIT_TRANSPORT = serial or SPLIT_TRANSPORT = i2c will include only
that driver code in the binary.

SPLIT_TRANSPORT = custom (or anything else) will include neither, the
keyboard must supply it's own code

if SPLIT_TRANSPORT is not defined then the original behaviour (include
both avr i2c and serial code) is maintained.

This could be better but it would require explicitly updating all the
existing split keyboards.

* Enable LTO to get lets_split/sockets under the line

* Add docs for SPLIT_TRANSPORT, CUSTOM_MATRIX, CUSTOM_DEBOUNCE

* Remove avr-specific sei() from split matrix_setup

Not needed now that slave doesn't have a separate main loop.
Both sides (on avr) call sei() in lufa's main() after exiting
keyboard_setup().

* Fix QUANTUM_LIB_SRC references and simplify SPLIT_TRANSPORT.

* Add comments and fix formatting.
24 files changed:
common_features.mk
docs/config_options.md
docs/getting_started_make_guide.md
keyboards/handwired/xealous/debounce.c [new file with mode: 0644]
keyboards/handwired/xealous/rules.mk
keyboards/lets_split/sockets/config.h
keyboards/lets_split/sockets/rules.mk
keyboards/miniaxe/config.h
keyboards/miniaxe/matrix.c [deleted file]
keyboards/miniaxe/rules.mk
quantum/config_common.h
quantum/debounce.c [new file with mode: 0644]
quantum/debounce.h [new file with mode: 0644]
quantum/matrix.c
quantum/split_common/i2c.h
quantum/split_common/matrix.c
quantum/split_common/matrix.h
quantum/split_common/serial.h
quantum/split_common/split_flags.h
quantum/split_common/split_util.c
quantum/split_common/split_util.h
quantum/split_common/transport.c [new file with mode: 0644]
quantum/split_common/transport.h [new file with mode: 0644]
tmk_core/common/keyboard.h