X-Git-Url: https://git.donarmstrong.com/?p=dsa-puppet.git;a=blobdiff_plain;f=modules%2Fpuppetmaster%2Flib%2Fpuppet%2Fparser%2Ffunctions%2Fgen_tlsa_entry.rb;h=1257ae81c9731d5889e9f698b64403bae39bdc5e;hp=2c826b9653b19d17f650036eec3357b128b7ec06;hb=cdf648b13dacc11edd25af11c93a67dbe7097743;hpb=90461a264b17c567a0d673317d424897bea75571

diff --git a/modules/puppetmaster/lib/puppet/parser/functions/gen_tlsa_entry.rb b/modules/puppetmaster/lib/puppet/parser/functions/gen_tlsa_entry.rb
index 2c826b96..1257ae81 100644
--- a/modules/puppetmaster/lib/puppet/parser/functions/gen_tlsa_entry.rb
+++ b/modules/puppetmaster/lib/puppet/parser/functions/gen_tlsa_entry.rb
@@ -4,32 +4,32 @@ module Puppet::Parser::Functions
     hostname = args.shift()
     port = args.shift()
 
-    if port.kind_of?(String)
-      ports = port.split()
-    else
+    if port.kind_of?(Array)
       ports = port
+    else
+      ports = [port]
     end
 
     res = []
     res << "; cert #{certfile} for #{hostname}:#{ports}."
-    ports.each { |port|
-      cf = certfile
-      if File.exist?(cf)
-        cmd = ['swede', 'create', '--usage=3', '--selector=1', '--mtype=1', '--certificate', cf, '--port', port.to_s, hostname]
+    ports.each do |port|
+      if File.exist?(certfile)
+        cmd = ['swede', 'create', '--usage=3', '--selector=1', '--mtype=1', '--certificate', certfile, '--port', port.to_s, hostname]
         IO.popen(cmd, "r") {|i| res << i.read }
       else
-        res << "; certfile #{cf} did not exist to create TLSA record for #{hostname}:#{port}."
+        res << "; certfile #{certfile} did not exist to create TLSA record for #{hostname}:#{port}."
       end
 
-      if cf.gsub!(/\.crt$/, '-new.crt') and File.exist?(cf)
-        cmd = ['swede', 'create', '--usage=3', '--selector=1', '--mtype=1', '--certificate', cf, '--port', port.to_s, hostname]
+      cfnew = certfile.gsub(/\.crt$/, '-new.crt')
+      if cfnew != certfile and File.exist?(cfnew)
+        cmd = ['swede', 'create', '--usage=3', '--selector=1', '--mtype=1', '--certificate', cfnew, '--port', port.to_s, hostname]
         new_entry = ''
         IO.popen(cmd, "r") {|i| new_entry = i.read }
         if not res.include?(new_entry)
           res << new_entry
         end
       end
-    }
+    end
 
     return res.join("\n")
   end