From: Don Armstrong Date: Wed, 31 Dec 2008 19:07:41 +0000 (+0100) Subject: * check whether the bug is archived before assuming its ok X-Git-Tag: release/2.6.0~461^2~73 X-Git-Url: https://git.donarmstrong.com/?p=debbugs.git;a=commitdiff_plain;h=de819a65ec7c79dad87afb7ce81b08c7da7c93c1 * check whether the bug is archived before assuming its ok * indicate an unknown bug number properly * Set src:foo on new packages if we're dealing with a source package assignment * Try to solve some of the undefined value in concatenation problems --- diff --git a/scripts/process b/scripts/process index cbaaa50..11c692e 100755 --- a/scripts/process +++ b/scripts/process @@ -224,7 +224,7 @@ if ($tryref >= 0) { my $bfound; ($bfound, $data)= &lockreadbugmerge($tryref); - if ($bfound) { + if ($bfound and not $data->{archived}) { $ref= $tryref; } else { &sendmessage(create_mime_message( @@ -236,7 +236,7 @@ if ($tryref >= 0) References => join(' ',grep {defined $_} $header{'message-id'},$data->{msgid}), Precedence => 'bulk', "X-$gProject-PR-Message" => 'error', - ],message_body_template('process_unknown_bug_number', + ],message_body_template('mail/process_unknown_bug_number', {subject => $subject, date => $header{date}, baddress => $baddress, @@ -449,8 +449,8 @@ if ($codeletter eq 'D' || $codeletter eq 'F') To => "$data->{originator}", Subject => "$gBug#$ref closed by $markedby ($header{'subject'})", "Message-ID" => "", - "In-Reply-To" => "$data->{msgid}", - References => join(' ',grep {defined $_} $header{'message-id'},$data->{msgid}), + (defined $data->{msgid})?("In-Reply-To" => $data->{msgid}):(), + References => join(' ',grep {defined $_} ($header{'message-id'},$data->{msgid})), "X-$gProject-PR-Message" => "they-closed $ref", "X-$gProject-PR-Package" => "$data->{package}", "X-$gProject-PR-Keywords" => "$data->{keywords}", @@ -499,7 +499,8 @@ if ($ref<0) { # new bug report $data->{fixed_versions} = []; if (defined $pheader{source}) { - $data->{package} = $pheader{source}; + # source packages are identified by the src: prefix + $data->{package} = 'src:'.$pheader{source}; } elsif (defined $pheader{package}) { $data->{package} = $pheader{package}; } elsif (defined $config{default_package}) {