From: Don Armstrong Date: Sun, 11 Jan 2009 06:57:18 +0000 (-0800) Subject: * revert previous change, as it was wrong X-Git-Tag: release/2.6.0~461^2~69 X-Git-Url: https://git.donarmstrong.com/?p=debbugs.git;a=commitdiff_plain;h=89c921ea1cc1577e381843348fe54c802cf10dfc * revert previous change, as it was wrong * properly fix the handling of pkg by moving it ahead of the user/usertag selection --- diff --git a/cgi/pkgreport.cgi b/cgi/pkgreport.cgi index 7be6241..a856a80 100755 --- a/cgi/pkgreport.cgi +++ b/cgi/pkgreport.cgi @@ -226,16 +226,15 @@ if (defined $param{maintenc}) { delete $param{maintenc} } - -if (not grep {exists $param{$_}} keys %package_search_keys and exists $param{users}) { - $param{usertag} = [make_list($param{users})]; -} - if (exists $param{pkg}) { $param{package} = $param{pkg}; delete $param{pkg}; } +if (not grep {exists $param{$_}} keys %package_search_keys and exists $param{users}) { + $param{usertag} = [make_list($param{users})]; +} + my %bugusertags; my %ut; my %seen_users; @@ -246,7 +245,6 @@ for my $user (map {split /[\s*,\s*]+/} make_list($param{users}||[])) { } if (defined $param{usertag}) { - my $do_not_add_usertags = grep {exists $param{$_}} keys %package_search_keys; for my $usertag (make_list($param{usertag})) { my %select_ut = (); my ($u, $t) = split /:/, $usertag, 2; @@ -255,7 +253,7 @@ if (defined $param{usertag}) { $t = join(",", keys(%select_ut)); } add_user($u,\%ut,\%bugusertags,\%seen_users,\%cats,\%hidden); - push @{$param{tag}}, split /,/, $t unless $do_not_add_usertags; + push @{$param{tag}}, split /,/, $t; } }