From: Niels Thykier <niels@thykier.net>
Date: Wed, 3 Aug 2016 21:12:13 +0000 (+0000)
Subject: Libravatar: Lazy-load LWP::UserAgent
X-Git-Tag: release/2.6.0~187
X-Git-Url: https://git.donarmstrong.com/?p=debbugs.git;a=commitdiff_plain;h=6d58a53155cd78fd9ae2b8726da7dd9fc179ffbd

Libravatar: Lazy-load LWP::UserAgent

LWP::UserAgent costs about 0.05s to load, but we only need it when the
image is not already cached locally.  Given we cache results for an
hour, it is fairly likely to be cached on subsequent requests.

Signed-off-by: Niels Thykier <niels@thykier.net>
---

diff --git a/Debbugs/Libravatar.pm b/Debbugs/Libravatar.pm
index d051090..4c4bcd0 100644
--- a/Debbugs/Libravatar.pm
+++ b/Debbugs/Libravatar.pm
@@ -39,7 +39,6 @@ use Libravatar::URL;
 use CGI::Simple;
 use Debbugs::CGI qw(cgi_parameters);
 use Digest::MD5 qw(md5_hex);
-use LWP::UserAgent;
 use File::Temp qw(tempfile);
 use File::LibMagic;
 use Cwd qw(abs_path);
@@ -109,6 +108,8 @@ sub retrieve_libravatar{
             return $temp_location;
         }
     }
+    require LWP::UserAgent;
+
     my $dest_type;
     eval {
         my $uri = libravatar_url(email => $param{email},
diff --git a/cgi/libravatar.cgi b/cgi/libravatar.cgi
index c0ff013..276b392 100755
--- a/cgi/libravatar.cgi
+++ b/cgi/libravatar.cgi
@@ -13,7 +13,6 @@ use Debbugs::Libravatar qw(:libravatar);
 
 use Libravatar::URL;
 
-use LWP::UserAgent;
 use HTTP::Request;
 
 use CGI::Simple;