From: Don Armstrong <don@donarmstrong.com>
Date: Tue, 3 Jan 2017 18:16:22 +0000 (-0800)
Subject: properly check close and closedir
X-Git-Tag: release/2.6.0~148
X-Git-Url: https://git.donarmstrong.com/?p=debbugs.git;a=commitdiff_plain;h=519ade10f5bd1ae57cdbdcb3388d03241557a765

properly check close and closedir

 - Thanks to Ian Jackson for noticing that we weren't properly checking
   whether the decompression program properly exited by checking the
   return value of close(). See
   22635.45523.288493.760480@chiark.greenend.org.uk for discussion
---

diff --git a/examples/debian/versions/build-versions-db b/examples/debian/versions/build-versions-db
index 2d52c61..3098587 100755
--- a/examples/debian/versions/build-versions-db
+++ b/examples/debian/versions/build-versions-db
@@ -161,6 +161,8 @@ sub read_packages {
 	update_package_version($db,$db2,$dist,$arch,$pkg,$ver,$time) unless
 	    $extra_source_only;
     }
+    close($PACKAGES) or
+	die "Error while closing ${packages}: $!";
 }
 
 
@@ -208,7 +210,8 @@ for my $suite (@{$suites}) {
 	    read_packages($db,$db2,$packages, $viscomponent,$arch,$suite);
 	}
 
-	closedir $COMPONENT;
+	closedir $COMPONENT or
+	    die "Unable to closedir $componentdir: $!";
     }
 }
 }