From: Steinar H. Gunderson <sesse@rietz>
Date: Wed, 7 Mar 2007 17:48:29 +0000 (+0000)
Subject: Slight optimization/simplification.
X-Git-Url: https://git.donarmstrong.com/?p=bugscan.git;a=commitdiff_plain;h=4910392b828be13f7b22cd63e6411032dac5547b

Slight optimization/simplification.
---

diff --git a/scanlib.pm b/scanlib.pm
index 068b9b4..b1ef13a 100644
--- a/scanlib.pm
+++ b/scanlib.pm
@@ -371,11 +371,13 @@ my $_version_cache = {};
 sub get_status() {
 	my ($bugnr, $bug, $dist) = @_;
 
-	my $status = 'pending';
-
 	my @versions = Debbugs::Status::getversions($bug->{'package'}, $dist, undef);
 	my @sourceversions = Debbugs::Status::makesourceversions($bug->{'package'}, undef, @versions);
 
+	if (length($bug->{'done'}) and
+	    (not @sourceversions or not @{$bug->{'fixed_versions'}})) {
+		return 'done';
+	}
 	if (@sourceversions) {
 		my $max_buggy = Debbugs::Status::max_buggy(bug => $bugnr,
 			 sourceversions => \@sourceversions,
@@ -383,18 +385,12 @@ sub get_status() {
 		 	 fixed => $bug->{'fixed_versions'},
 			 version_cache => $_version_cache,
 			 package => $bug->{'package'});
-		if ($max_buggy eq 'absent') {
-			$status = 'absent';
-		} elsif ($max_buggy eq 'fixed') {
-			$status = 'done';
+		if ($max_buggy eq 'absent' || $max_buggy eq 'fixed') {
+			return $max_buggy;
 		}
 	}
-	if (length($bug->{'done'}) and
-	    (not @sourceversions or not @{$bug->{'fixed_versions'}})) {
-		$status = 'done';
-	}
 
-	return $status;
+	return 'pending';
 }
 
 sub check_worry {