X-Git-Url: https://git.donarmstrong.com/?p=bugscan.git;a=blobdiff_plain;f=scanlib.pm;h=25aafcd9ec7a139145da1319041da561191c7a39;hp=f7b4bd1199e5a4dc64b75ecba95bac99913fe9c8;hb=6535c7957521d2d4f852c2a2772b53dd8a905e52;hpb=71e6cb7e3cc7f577df4b8b947b16477252c04dbd

diff --git a/scanlib.pm b/scanlib.pm
index f7b4bd1..25aafcd 100644
--- a/scanlib.pm
+++ b/scanlib.pm
@@ -14,7 +14,7 @@
 #   %packagelist    - map from packagename to bugreports
 #   %NMU            - map with NMU information
 
-use lib qw(/org/bugs.debian.org/perl/);
+use lib qw(/org/bugs.debian.org/perl);
 use LWP::UserAgent;
 use Debbugs::MIME qw(decode_rfc1522 encode_rfc1522);
 use Debbugs::Packages;
@@ -208,36 +208,55 @@ sub scanspooldir() {
 			}
 		}
 		next if $skip==1;
+	
+		my %disttags = ();	
+		$disttags{'oldstable'}    = grep(/^woody$/, @tags);
+		$disttags{'stable'}       = grep(/^sarge$/, @tags);
+		$disttags{'testing'}      = grep(/^etch$/, @tags);
+		$disttags{'unstable'}     = grep(/^sid$/, @tags);
+		$disttags{'experimental'} = grep(/^experimental$/, @tags);
 		
-		my $oldstable_tag    = grep(/^woody$/, @tags);
-		my $stable_tag       = grep(/^sarge$/, @tags);
-		my $testing_tag      = grep(/^etch$/, @tags);
-		my $unstable_tag     = grep(/^sid$/, @tags);
-		my $experimental_tag = grep(/^experimental$/, @tags);
-
-		# default according to dondelelcaro 2006-11-11
-		if (!$oldstable_tag && !$stable_tag && !$testing_tag && !$unstable_tag && !$experimental_tag) {
-			$testing_tag = 1;
-			$unstable_tag = 1;
-			$experimental_tag = 1;
-		}
-
-		# only bother to check the versioning status for the distributions indicated by the tags 
-		my $status_oldstable    = get_status($f, $bug, 'oldstable')    if ($oldstable_tag);
-		my $status_stable       = get_status($f, $bug, 'stable')       if ($stable_tag);
-		my $status_testing      = get_status($f, $bug, 'testing')      if ($testing_tag);
-		my $status_unstable     = get_status($f, $bug, 'unstable')     if ($unstable_tag);
-		my $status_experimental = get_status($f, $bug, 'experimental') if ($experimental_tag);
-
 		my $relinfo = "";
-		$relinfo .= (($oldstable_tag    && $status_oldstable    eq 'pending') ? "O" : "");
-		$relinfo .= (($stable_tag       && $status_stable       eq 'pending') ? "S" : "");
-		$relinfo .= (($testing_tag      && $status_testing      eq 'pending') ? "T" : "");
-		$relinfo .= (($unstable_tag     && $status_unstable     eq 'pending') ? "U" : "");
-		$relinfo .= (($experimental_tag && $status_experimental eq 'pending') ? "E" : "");
-		
-		next if $relinfo eq '' and not $premature{$f};
-		$premature{$f}++ if $relinfo eq '';
+		if (defined($section{$bug->{'package'}}) && $section{$bug->{'package'}} eq 'pseudo') {
+			# versioning information makes no sense for pseudo packages,
+			# just use the tags
+			for my $dist qw(oldstable stable testing unstable experimental) {
+				$relinfo .= uc(substr($dist, 0, 1)) if $disttags{$dist};
+			}
+			next if (length($bug->{'done'}));
+		} else {
+			# default according to dondelelcaro 2006-11-11
+			if (!$disttags{'oldstable'} && !$disttags{'stable'} && !$disttags{'testing'} && !$disttags{'unstable'} && !$disttags{'experimental'}) {
+				$disttags{'testing'} = 1;
+				$disttags{'unstable'} = 1;
+				$disttags{'experimental'} = 1;
+			}
+
+			# only bother to check the versioning status for the distributions indicated by the tags 
+			for my $dist qw(oldstable stable testing unstable experimental) {
+				local $SIG{__WARN__} = sub {};
+
+				next if (!$disttags{$dist});
+
+				my $presence = Debbugs::Status::bug_presence(
+					bug => $f, 
+					status => $bug, 
+					dist => $dist, 
+					arch => [ qw(alpha amd64 arm hppa i386 ia64 mips mipsel powerpc s390 sparc) ]
+				);
+
+				# ignore bugs that are absent/fixed in this distribution, include everything
+				# else (that is, "found" which says that the bug is present, and undef, which
+				# indicates that no versioning information is present and it's not closed
+				# unversioned)
+				if (!defined($presence) || ($presence ne 'absent' && $presence ne 'fixed')) {
+					$relinfo .= uc(substr($dist, 0, 1));
+				}
+			}
+			
+			next if $relinfo eq '' and not $premature{$f};
+			$premature{$f}++ if $relinfo eq '';
+		}
 
 		$taginfo = "[";
 		$taginfo .= ($bug->{'keywords'} =~ /\bpending\b/        ? "P" : " ");
@@ -265,7 +284,7 @@ sub scanspooldir() {
 				}
 			}
 
-			$packagelist{$_} .= " $f";
+			push @{$packagelist{$_}}, $f;
 		}
 
 		if ($relinfo eq "") { # or $relinfo eq "U" # confuses e.g. #210306
@@ -294,9 +313,10 @@ sub readstatus() {
 		if (m/^[0-9]+ \[/) {
 			($bug,$subject)=split(/ /, $_, 2);
 			$bugs{$bug}=$subject;
-			$packagelist{$pkg} .= "$bug ";
+			push @{$packagelist{$pkg}}, $bug;
 		} else {
 			($pkg,$sect, $mnt)=split(/ /, $_, 3);
+			next if (!defined($pkg));
 			$section{$pkg}=$sect;
 			$maintainer{$pkg}=$mnt;
 		}
@@ -372,39 +392,15 @@ sub wwwname() {
 #	"<A HREF=\"${btsURL}/db/pa/l$name.html\">$name</A>";
 }
 
-my $_version_cache = {};
-sub get_status() {
-	my ($bugnr, $bug, $dist) = @_;
-
-	my @versions = Debbugs::Status::getversions($bug->{'package'}, $dist, undef);
-	my @sourceversions = Debbugs::Status::makesourceversions($bug->{'package'}, undef, @versions);
-
-	if (length($bug->{'done'}) and
-	    (not @sourceversions or not @{$bug->{'fixed_versions'}})) {
-		return 'done';
-	}
-	if (@sourceversions) {
-		my $max_buggy = Debbugs::Status::max_buggy(bug => $bugnr,
-			 sourceversions => \@sourceversions,
-		 	 found => $bug->{'found_versions'},
-		 	 fixed => $bug->{'fixed_versions'},
-			 version_cache => $_version_cache,
-			 package => $bug->{'package'});
-		if ($max_buggy eq 'absent' || $max_buggy eq 'fixed') {
-			return $max_buggy;
-		}
-	}
-
-	return 'pending';
-}
-
 sub check_worry {
 	my ($status) = @_;
 
 	if ($status =~ m/^\[[^]]*I/ or
 	    $status =~ m/ \[[^]]*X/ or
-            ($status =~ m/ \[[^]]*[OSUE]/ and $status !~ m/ \[[^]]*T/)) {
+            $status !~ m/ \[[^]]*T/) {
 		return 0;
 	}
 	return 1;
 }
+
+1;