From c311254aa558f21f5a90d3c65456eb91e5ac3d89 Mon Sep 17 00:00:00 2001 From: Don Armstrong Date: Tue, 2 Dec 2008 20:10:53 -0800 Subject: [PATCH] Add Last-Modified: header support to mbox download (closes: #456786) --- cgi/bugreport.cgi | 12 ++++++++---- debian/changelog | 1 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/cgi/bugreport.cgi b/cgi/bugreport.cgi index 46b2eb4b..c50d5860 100755 --- a/cgi/bugreport.cgi +++ b/cgi/bugreport.cgi @@ -159,13 +159,17 @@ my @log; if ( $mbox ) { my $date = strftime "%a %b %d %T %Y", localtime; if (@records > 1) { - print qq(Content-Disposition: attachment; filename="bug_${ref}.mbox"\n); - print "Content-Type: text/plain\n\n"; + print $q->header(-type => "text/plain", + content_disposition => qq(attachment; filename="bug_${ref}.mbox"), + (length $mtime)?(-last_modified => $mtime):(), + ); } else { $msg_num++; - print qq(Content-Disposition: attachment; filename="bug_${ref}_message_${msg_num}.mbox"\n); - print "Content-Type: message/rfc822\n\n"; + print $q->header(-type => "message/rfc822", + content_disposition => qq(attachment; filename="bug_${ref}_message_${msg_num}.mbox"), + (length $mtime)?(-last_modified => $mtime):(), + ); } if ($mbox_status_message and @records > 1) { my $status_message=''; diff --git a/debian/changelog b/debian/changelog index 8e289d54..865fc141 100644 --- a/debian/changelog +++ b/debian/changelog @@ -235,6 +235,7 @@ debbugs (2.4.2) UNRELEASED; urgency=low * Resolve two XSS (closes: #504608) * Strip BOM before regexes involving spaces (closes: #488554) * Display link to full log again (closes: #507506) + * Add Last-Modified: header support to mbox download (closes: #456786) -- Colin Watson Fri, 20 Jun 2003 18:57:25 +0100 -- 2.39.5