From c0c8fcbc31be4c77e6ec7bd2858e7ce997624789 Mon Sep 17 00:00:00 2001
From: dms <dms@c11ca15a-4712-0410-83d8-924469b57eb5>
Date: Thu, 21 Nov 2002 13:30:30 +0000
Subject: [PATCH] - strictify - forgot to use $sth->finish... does this
 free/unlock mem used?

git-svn-id: https://svn.code.sf.net/p/infobot/code/trunk/blootbot@657 c11ca15a-4712-0410-83d8-924469b57eb5
---
 src/Modules/Factoids.pl | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/Modules/Factoids.pl b/src/Modules/Factoids.pl
index 45f8554..9ca5c54 100644
--- a/src/Modules/Factoids.pl
+++ b/src/Modules/Factoids.pl
@@ -5,7 +5,10 @@
 #     Splitted: SQLExtras.pl
 #
 
-if (&IsParam("useStrict")) { use strict; }
+use strict;
+
+use vars qw($dbh $who);
+use vars qw(%param);
 
 ###
 # Usage: &CmdFactInfo($faqtoid, $query);
@@ -671,6 +674,7 @@ sub CmdFactStats {
 
     } elsif ($type =~ /^(2|too)long$/i) {
 	my @list;
+	my $query;
 
 	# factoid_key.
 	$query = "SELECT factoid_key FROM factoids WHERE length(factoid_key) >= $param{'maxKeySize'}";
@@ -679,14 +683,16 @@ sub CmdFactStats {
 	while (my @row = $sth->fetchrow_array) {
 	    push(@list,$row[0]);
 	}
+	$sth->finish;
 
 	# factoid_value.
-	my $query = "SELECT factoid_key,factoid_value FROM factoids WHERE length(factoid_value) >= $param{'maxDataSize'}";
+	$query = "SELECT factoid_key,factoid_value FROM factoids WHERE length(factoid_value) >= $param{'maxDataSize'}";
 	$sth = $dbh->prepare($query);
 	$sth->execute;
 	while (my @row = $sth->fetchrow_array) {
 	    push(@list,sprintf("\002%s\002 - %s", length($row[1]), $row[0]));
 	}
+	$sth->finish;
 
 	if (scalar @list == 0) {
 	    return "good. no factoids exceed length.";
-- 
2.39.2