From aaebcb91e46df5236f819e54392934edc31118ed Mon Sep 17 00:00:00 2001 From: Han-Wen Nienhuys Date: Sat, 6 Jan 2007 20:34:40 +0100 Subject: [PATCH 1/1] document coverage of Score::disconnect_from_context --- lily/score-engraver.cc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/lily/score-engraver.cc b/lily/score-engraver.cc index 91cca081e7..b70ead4349 100644 --- a/lily/score-engraver.cc +++ b/lily/score-engraver.cc @@ -99,6 +99,20 @@ Score_engraver::connect_to_context (Context *c) d->add_listener (GET_LISTENER (finish), ly_symbol2scm ("Finish")); } +/* + uncovered: + + check_removal always returns false for Score contexts, it has been that way +since I joined the project. There is a reason for this: The typeset score is +stored in the Score_engraver, which in turn is accessed through the +Global_context returned by ly:run-translator. So the score-translator must be +connected to the score-context after run-translator finishes. + +I plan to change this: we should junk run-translator, and instead keep track +of both context and translator in the SCM code, and access the typeset score +directly via the created global-translator. Then it would be possible to +disconnect score-translators at iteration time. -es + */ void Score_engraver::disconnect_from_context () { -- 2.39.2