From a1db5ed472c85bb6bc031caebaa002273614f2dc Mon Sep 17 00:00:00 2001
From: Steve Hancock <perltidy@users.sourceforge.net>
Date: Tue, 11 Jun 2024 21:41:55 -0700
Subject: [PATCH] updates for perlcritic

---
 .perlcriticrc                  | 6 ++++++
 lib/Perl/Tidy/Formatter.pm     | 1 +
 lib/Perl/Tidy/IOScalar.pm      | 3 +--
 lib/Perl/Tidy/IOScalarArray.pm | 3 +--
 4 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/.perlcriticrc b/.perlcriticrc
index f72c88a0..8fc71ccb 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -8,6 +8,7 @@
 
 # Some useful links:
 # https://metacpan.org/dist/Perl-Critic/view/lib/Perl/Critic/PolicySummary.pod
+# https://metacpan.org/pod/Perl::Critic::PolicySummary
 # https://manpages.ubuntu.com/manpages/xenial/man1/perlcritic.1p.html
 # https://perlmaven.com/perl-critic
 
@@ -59,6 +60,11 @@ short_subroutine_statements = 2
 [InputOutput::RequireBriefOpen]
 lines=30
 
+# Perltidy modules IOScalar.pm and IOScalarArray.pm provide a print function,
+# but I had to turn this off because the 'allow' option does not seem to work
+[-Subroutines::ProhibitBuiltinHomonyms]
+# allow=print
+
 #---------------------------------------------------
 # Policies to be skipped or adjusted for severity=3:
 #---------------------------------------------------
diff --git a/lib/Perl/Tidy/Formatter.pm b/lib/Perl/Tidy/Formatter.pm
index b72a5917..8adda126 100644
--- a/lib/Perl/Tidy/Formatter.pm
+++ b/lib/Perl/Tidy/Formatter.pm
@@ -14668,6 +14668,7 @@ sub update_sub_call_paren_info {
         # must be called once per file before first call to sub try_3
         %try_3_cache      = ();
         %is_oo_call_cache = ();
+        return;
     } ## end sub initialize_try_3_cache
 
     sub try_3 {
diff --git a/lib/Perl/Tidy/IOScalar.pm b/lib/Perl/Tidy/IOScalar.pm
index 841a4946..628076fb 100644
--- a/lib/Perl/Tidy/IOScalar.pm
+++ b/lib/Perl/Tidy/IOScalar.pm
@@ -94,8 +94,7 @@ EOM
     return $self->[0]->[$i];
 } ## end sub getline
 
-sub print    ## no critic (Subroutines::ProhibitBuiltinHomonyms)
-{
+sub print {
     my ( $self, $msg ) = @_;
     my $mode = $self->[1];
     if ( $mode ne 'w' ) {
diff --git a/lib/Perl/Tidy/IOScalarArray.pm b/lib/Perl/Tidy/IOScalarArray.pm
index f654c017..1e5fed1f 100644
--- a/lib/Perl/Tidy/IOScalarArray.pm
+++ b/lib/Perl/Tidy/IOScalarArray.pm
@@ -90,8 +90,7 @@ EOM
     return $self->[0]->[$i];
 } ## end sub getline
 
-sub print    ## no critic (Subroutines::ProhibitBuiltinHomonyms)
-{
+sub print {
     my ( $self, $msg ) = @_;
     my $mode = $self->[1];
     if ( $mode ne 'w' ) {
-- 
2.39.5