From 9ff7bbb226f060a4068ee6a454fd3f2c910e1480 Mon Sep 17 00:00:00 2001 From: Steve Hancock Date: Sat, 17 Nov 2018 21:33:33 -0800 Subject: [PATCH] Turned VERSION checking on in perlcritic --- .perlcriticrc | 4 ---- dev-bin/build.pl | 22 ++++++++++++++++++++++ 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/.perlcriticrc b/.perlcriticrc index 2440ac13..17a1c4ba 100644 --- a/.perlcriticrc +++ b/.perlcriticrc @@ -16,10 +16,6 @@ severity = 4 # There is a stringy eval in Formatter.pm which is essential. [-BuiltinFunctions::ProhibitStringyEval] -# maintaining VERSION numbers for all internal modules introduces -# needless maintenance issues -[-Modules::RequireVersionVar] - # Tidy.pm exports 'perltidy'. Changing this could break existing scripts. [-Modules::ProhibitAutomaticExportation] diff --git a/dev-bin/build.pl b/dev-bin/build.pl index 507910dc..1df8158e 100755 --- a/dev-bin/build.pl +++ b/dev-bin/build.pl @@ -315,6 +315,28 @@ sub update_version_number { my @sources = ( $lib_path . "Tidy.pm", $lib_path . "Tidy.pod", $bin_path . "perltidy", ); push @sources, "local-docs/ChangeLog.pod"; + my @more = qw( + Tidy/Debugger.pm + Tidy/DevNull.pm + Tidy/Diagnostics.pm + Tidy/FileWriter.pm + Tidy/Formatter.pm + Tidy/HtmlWriter.pm + Tidy/IOScalar.pm + Tidy/IOScalarArray.pm + Tidy/IndentationItem.pm + Tidy/LineBuffer.pm + Tidy/LineSink.pm + Tidy/LineSource.pm + Tidy/Logger.pm + Tidy/Tokenizer.pm + Tidy/VerticalAligner.pm + Tidy/VerticalAligner/Alignment.pm + Tidy/VerticalAligner/Line.pm + ); + foreach my $module (@more) { + push @sources, $lib_path . $module; + } my $Tidy_pm_file = $lib_path . "Tidy.pm"; -- 2.39.5