From 751587ab3eac9e2f32b085bddf45ef50d03ea866 Mon Sep 17 00:00:00 2001 From: Han-Wen Nienhuys Date: Wed, 10 Jan 2007 02:47:03 +0100 Subject: [PATCH] Only set stopped_tuplets_ when actually erasing a tuplet bracket. Fixes odd spacing and programming errors with Cary. --- lily/spacing-spanner.cc | 4 ++++ lily/tuplet-engraver.cc | 8 +++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lily/spacing-spanner.cc b/lily/spacing-spanner.cc index 3177368245..42dfe5997b 100644 --- a/lily/spacing-spanner.cc +++ b/lily/spacing-spanner.cc @@ -318,6 +318,9 @@ Spacing_spanner::musical_column_spacing (Grob *me, if (!Paper_column::is_musical (right_col)) { + /* + reconsider this: breaks with wide marks/tempos/etc. + */ Real left_col_stick_out = robust_relative_extent (left_col, left_col, X_AXIS)[RIGHT]; compound_fixed_note_space = max (left_col_stick_out, options->increment_); @@ -429,6 +432,7 @@ Spacing_spanner::fills_measure (Grob *me, Item *left, Item *col) return false; } + /* Read hints from L and generate springs. */ diff --git a/lily/tuplet-engraver.cc b/lily/tuplet-engraver.cc index b95150ce10..cd8038494b 100644 --- a/lily/tuplet-engraver.cc +++ b/lily/tuplet-engraver.cc @@ -108,9 +108,11 @@ Tuplet_engraver::process_music () Moment now = now_mom(); for (vsize i = tuplets_.size (); i --; ) { - stopped_tuplets_.push_back (tuplets_[i]); if (tuplets_[i].stop_moment_ == now) - tuplets_.erase (tuplets_.begin () + i); + { + stopped_tuplets_.push_back (tuplets_[i]); + tuplets_.erase (tuplets_.begin () + i); + } } for (vsize i = 0; i < stopped_tuplets_.size (); i++) @@ -134,7 +136,7 @@ Tuplet_engraver::process_music () bracket->set_bound (RIGHT, bracket->get_bound (LEFT)); number->set_bound (RIGHT, - stopped_tuplets_[i].bracket_->get_bound (LEFT)); + stopped_tuplets_[i].bracket_->get_bound (LEFT)); } // todo: scrap last_tuplets_, use stopped_tuplets_ only. -- 2.39.5