From 59c56667425ec6fae59655cf01ee724e024c0ebd Mon Sep 17 00:00:00 2001 From: Graham Percival Date: Thu, 8 Dec 2011 21:34:56 -0800 Subject: [PATCH] Avoid comparison of unsigned < 0 PyArg_ParseTuple (args, "s#|i", &track, &track_size, ... returns the length as an int: http://docs.python.org/c-api/arg.html#PyArg_ParseTuple --- python/midi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/python/midi.c b/python/midi.c index 187268b78e..0a8599d0e2 100644 --- a/python/midi.c +++ b/python/midi.c @@ -356,7 +356,7 @@ static PyObject * pymidi_parse_track (PyObject *self, PyObject *args) { unsigned char *track, *track_end; - unsigned long track_size; + int track_size; int clocks_max; debug_print ("%s", "\n"); @@ -398,9 +398,11 @@ midi_parse (unsigned char **midi,unsigned char *midi_end, int clocks_max) division = get_number (midi, *midi + 2, 2) * 4; + /* if (division < 0) - /* return midi_error (cannot handle non-metrical time"); */ + return midi_error (cannot handle non-metrical time"); ; + */ *midi += header_len - 6; pymidi = PyList_New (0); -- 2.39.2