From 46c75064f5caa7466dc239e74c09804df477be66 Mon Sep 17 00:00:00 2001 From: Mike Solomon Date: Thu, 28 Apr 2011 10:03:20 -0400 Subject: [PATCH] Adds a regtest for glissando index. Also fixes a variable declaration in the glissando engraver. --- input/regression/glissando-chord.ly | 5 ----- input/regression/glissando-index.ly | 14 ++++++++++++++ lily/glissando-engraver.cc | 4 +--- 3 files changed, 15 insertions(+), 8 deletions(-) create mode 100644 input/regression/glissando-index.ly diff --git a/input/regression/glissando-chord.ly b/input/regression/glissando-chord.ly index e140c38d8e..27ae104037 100644 --- a/input/regression/glissando-chord.ly +++ b/input/regression/glissando-chord.ly @@ -15,9 +15,4 @@ c1 \glissando s1 \set glissandoMap = #'((2 . 0) (1 . 0) (0 . 0)) 1 \glissando s1 c - \unset glissandoMap - \once \override Voice . Glissando #'style = - #(lambda (grob) - (if (eq? 1 (ly:grob-property grob 'glissando-index)) 'zigzag 'default)) - 1 \glissando s1 } diff --git a/input/regression/glissando-index.ly b/input/regression/glissando-index.ly new file mode 100644 index 0000000000..9b2d99cd11 --- /dev/null +++ b/input/regression/glissando-index.ly @@ -0,0 +1,14 @@ +% FIXME: this is a fake version number to allow git master +% to compile. See discussion on lilypond-devel. +\version "2.13.61" + +\header { + texidoc = "Individual glissandi within a chord can be tweaked." +} + +\relative c' { + \once \override Voice . Glissando #'style = + #(lambda (grob) + (if (eq? 1 (ly:grob-property grob 'glissando-index)) 'zigzag 'default)) + 1 \glissando s1 +} diff --git a/lily/glissando-engraver.cc b/lily/glissando-engraver.cc index 08f420c128..ebd2bb32c7 100644 --- a/lily/glissando-engraver.cc +++ b/lily/glissando-engraver.cc @@ -48,7 +48,6 @@ private: bool stop_glissandi; Stream_event *event_; - SCM map; vector note_column_1; vector note_column_2; }; @@ -56,7 +55,6 @@ private: Glissando_engraver::Glissando_engraver () { event_ = 0; - map = SCM_EOL; start_glissandi = false; stop_glissandi = false; } @@ -82,7 +80,7 @@ Glissando_engraver::acknowledge_note_column (Grob_info info) if (start_glissandi) { extract_grob_set (g, "note-heads", note_heads); - map = get_property ("glissandoMap"); + SCM map = get_property ("glissandoMap"); if (map == SCM_EOL) for (vsize i = 0; i < note_heads.size (); i++) { -- 2.39.5