From 37f6a1eaef9271bdad5625f05898927c247b0e1c Mon Sep 17 00:00:00 2001
From: Steve Hancock <perltidy@users.sourceforge.net>
Date: Thu, 14 Nov 2024 15:49:10 -0800
Subject: [PATCH] add calls to croak

---
 lib/Perl/Tidy.pm            | 7 +++----
 lib/Perl/Tidy/FileWriter.pm | 6 +++---
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/lib/Perl/Tidy.pm b/lib/Perl/Tidy.pm
index ea9391ff..8f93929c 100644
--- a/lib/Perl/Tidy.pm
+++ b/lib/Perl/Tidy.pm
@@ -735,14 +735,14 @@ EOM
         my $flag = shift;
         if   ($flag) { goto ERROR_EXIT }
         else         { goto NORMAL_EXIT }
-        croak "unexpected return to Exit";
+        croak "unexpected return to sub Exit";
     } ## end sub Exit
 
     sub Die {
         my $msg = shift;
         Warn($msg);
         Exit(1);
-        croak "unexpected return to Die";
+        croak "unexpected return from sub Exit";
     } ## end sub Die
 
     sub Fault {
@@ -771,8 +771,7 @@ $pkg reports VERSION='$VERSION'.
 ==============================================================================
 EOM
 
-        # This return is to keep Perl-Critic from complaining.
-        return;
+        croak "unexpected return from sub Die";
     } ## end sub Fault
 
     # extract various dump parameters
diff --git a/lib/Perl/Tidy/FileWriter.pm b/lib/Perl/Tidy/FileWriter.pm
index 9165adbe..a65ae2c2 100644
--- a/lib/Perl/Tidy/FileWriter.pm
+++ b/lib/Perl/Tidy/FileWriter.pm
@@ -17,6 +17,7 @@ package Perl::Tidy::FileWriter;
 use strict;
 use warnings;
 our $VERSION = '20240903.06';
+use Carp;
 
 use constant DEVEL_MODE   => 0;
 use constant EMPTY_STRING => q{};
@@ -87,7 +88,7 @@ BEGIN {
 sub Die {
     my ($msg) = @_;
     Perl::Tidy::Die($msg);
-    return;
+    croak "unexpected return from Perl::Tidy::Die";
 }
 
 sub Fault {
@@ -126,8 +127,7 @@ $pkg reports VERSION='$VERSION'.
 ==============================================================================
 EOM
 
-    # This return is to keep Perl-Critic from complaining.
-    return;
+    croak "unexpected return from sub Die";
 } ## end sub Fault
 
 sub warning {
-- 
2.39.5