From 0e26a525aa7291c4a953048b163b423a779bacac Mon Sep 17 00:00:00 2001
From: Don Armstrong <don@volo>
Date: Sat, 14 Apr 2007 14:48:55 -0700
Subject: [PATCH]  * Add quotes around retitle'd titles (closes: #419202)  *
 Fix usertag visible_cat code in service.in

---
 debian/changelog   | 1 +
 scripts/service.in | 8 +++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 829afd29..ad298432 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -166,6 +166,7 @@ debbugs (2.4.2) UNRELEASED; urgency=low
     - pkgindex.cgi limits its output with pagination (closes: #23018)
     - lc submitter address for comparsion in pkgreport.cgi
       (closes: #415628)
+    - Add quotes around retitle'd titles (closes: #419202)
 
   
  -- Colin Watson <cjwatson@debian.org>  Fri, 20 Jun 2003 18:57:25 +0100
diff --git a/scripts/service.in b/scripts/service.in
index 0ffcd202..28b8cdba 100755
--- a/scripts/service.in
+++ b/scripts/service.in
@@ -336,11 +336,13 @@ END
 	if (@cats) {
 	    &transcript("Added usercategory $catname.\n\n");
 	    $u->{"categories"}->{$catname} = [ @cats ];
-	    $u->{visible_cats}{$catname} = $hidden;
+	    if (not $hidden) {
+		 push @{$u->{visible_cats}},$catname;
+	    }
 	} else {
 	    &transcript("Removed usercategory $catname.\n\n");
 	    delete $u->{"categories"}->{$catname};
-	    delete $u->{visible_cats}{$catname};
+	    @{$u->{visible_cats}} = grep {$_ ne $catname} @{$u->{visible_cats}};
 	}
 	$u->write();
     } elsif (m/^usertags?\s+\#?(-?\d+)\s+(([=+-])\s*)?(\S.*)?$/i) {
@@ -893,7 +895,7 @@ END
                 &addmaintainers($data);
 		my $oldtitle = $data->{subject};
                 $data->{subject}= $newtitle;
-                $action= "Changed $gBug title to $newtitle from $oldtitle.";
+                $action= "Changed $gBug title to `$newtitle' from `$oldtitle'.";
                 &savebug;
                 &transcript("$action\n");
                 if (length($data->{done})) {
-- 
2.39.5