]>
git.donarmstrong.com Git - debbugs.git/log
Don Armstrong [Fri, 9 Jun 2017 19:34:02 +0000 (12:34 -0700)]
remove common.pl and old cgi code which is unused
Don Armstrong [Mon, 29 May 2017 14:33:47 +0000 (07:33 -0700)]
fix flie/file typo which broke usertags in bug reports
Don Armstrong [Sat, 29 Apr 2017 15:42:56 +0000 (08:42 -0700)]
Fix breakage caused by cdn.libravatar.org not setting Content-Type
- Actually test using libmagic and adjust type on that basis
Don Armstrong [Sun, 9 Apr 2017 23:26:04 +0000 (16:26 -0700)]
remove UTF8 warnings
Don Armstrong [Sun, 2 Apr 2017 21:42:29 +0000 (14:42 -0700)]
change fix to #858671 to split source with split_status_fields
Some consumers of get_bug_status via SOAP were not handling split packages
Don Armstrong [Sun, 2 Apr 2017 21:42:05 +0000 (14:42 -0700)]
remove two checks where dpkg now follows policy
foo- is not a legal version number
Don Armstrong [Fri, 31 Mar 2017 02:26:13 +0000 (19:26 -0700)]
prefix src: to all source packages
Don Armstrong [Fri, 31 Mar 2017 02:25:55 +0000 (19:25 -0700)]
Split source file properly
Thanks to James McCoy for the start of the patch
Don Armstrong [Fri, 27 Jan 2017 16:50:36 +0000 (08:50 -0800)]
include experimental in the default removal tags
Don Armstrong [Tue, 3 Jan 2017 18:16:22 +0000 (10:16 -0800)]
properly check close and closedir
- Thanks to Ian Jackson for noticing that we weren't properly checking
whether the decompression program properly exited by checking the
return value of close(). See
22635.45523.288493.760480@chiark.greenend.org.uk for discussion
Don Armstrong [Mon, 2 Jan 2017 18:27:31 +0000 (10:27 -0800)]
the versions database is rebuilt each time
- Because we allow more than one version, we need to rebuild the
versions database each time
Don Armstrong [Fri, 30 Dec 2016 00:19:55 +0000 (16:19 -0800)]
fix xzip/bzip2 regex
Don Armstrong [Fri, 30 Dec 2016 00:13:49 +0000 (16:13 -0800)]
support bzip2 (oldstable)
Don Armstrong [Thu, 29 Dec 2016 21:12:40 +0000 (13:12 -0800)]
build-versions-db now updates in-place
- remove all of the mv bits
Don Armstrong [Thu, 29 Dec 2016 21:10:33 +0000 (13:10 -0800)]
add update and --no-update options
+ Abstract out main routine
+ move versions time cleanup here
+ Hopefully this will avoid the issues of failures screwing up the
database
Don Armstrong [Thu, 29 Dec 2016 00:58:03 +0000 (16:58 -0800)]
IO::Uncompress is too slow; use open_compressed_file
Don Armstrong [Thu, 17 Nov 2016 01:15:05 +0000 (17:15 -0800)]
debbugs-web now breaks/replaces debbugs << 2.4.2
Don Armstrong [Thu, 17 Nov 2016 01:09:37 +0000 (17:09 -0800)]
use dh $@ and debehlper version 9
Don Armstrong [Thu, 17 Nov 2016 00:46:30 +0000 (16:46 -0800)]
Fix clone removing all other blocks instead of add
+ (Closes: #820044). Thanks to James Clarke.
Don Armstrong [Mon, 14 Nov 2016 15:46:05 +0000 (07:46 -0800)]
add back set -e in case of failure
Don Armstrong [Mon, 14 Nov 2016 15:45:19 +0000 (07:45 -0800)]
remove compprefix
Don Armstrong [Sun, 13 Nov 2016 00:07:09 +0000 (16:07 -0800)]
build-versions-db doesn't need hostname
Don Armstrong [Sat, 12 Nov 2016 22:55:38 +0000 (14:55 -0800)]
Handle Packages.xz etc.
Handle the removal of packages.gz while building the versions database
Don Armstrong [Sat, 24 Sep 2016 21:40:01 +0000 (14:40 -0700)]
send out the right charset on all requests
Don Armstrong [Wed, 7 Sep 2016 19:02:50 +0000 (12:02 -0700)]
document fix of #584922 by Niels
Niels Thykier [Sat, 6 Aug 2016 10:14:55 +0000 (10:14 +0000)]
D/Config: Add missing </P> in default html_tail
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Fri, 5 Aug 2016 20:12:42 +0000 (20:12 +0000)]
Drop more unused variables
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Fri, 5 Aug 2016 18:10:01 +0000 (18:10 +0000)]
Libravatar: Add caching of "negative" libravatar results
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Sun, 21 Aug 2016 09:46:32 +0000 (09:46 +0000)]
Set LC_ALL to an UTF-8 locale before running tests
To avoid noisy warnings from some tests that implicitly expect to be
run under an UTF-8 locale.
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Sun, 21 Aug 2016 10:24:20 +0000 (10:24 +0000)]
quitcgi: Return 400/500 status codes
Signed-off-by: Niels Thykier <niels@thykier.net>
Don Armstrong [Tue, 6 Sep 2016 17:20:45 +0000 (10:20 -0700)]
add notification settings to travis.yml
Don Armstrong [Mon, 5 Sep 2016 16:11:13 +0000 (09:11 -0700)]
Fix (and test) setting summary/outlook in Control: messages (Closes: #836613).
Don Armstrong [Mon, 5 Sep 2016 16:09:16 +0000 (09:09 -0700)]
create_config now calls BAIL_OUT on its own
Don Armstrong [Mon, 5 Sep 2016 16:05:38 +0000 (09:05 -0700)]
abstract out create config in tests
Don Armstrong [Sat, 3 Sep 2016 13:38:13 +0000 (06:38 -0700)]
make already runs test rules
Don Armstrong [Sat, 3 Sep 2016 13:22:48 +0000 (06:22 -0700)]
depend on libmagic, gravatar-url and www-perl
Don Armstrong [Sat, 3 Sep 2016 13:14:53 +0000 (06:14 -0700)]
try a different approach to using system perl
Don Armstrong [Sat, 3 Sep 2016 13:01:59 +0000 (06:01 -0700)]
system is in quotes
Don Armstrong [Sat, 3 Sep 2016 12:55:08 +0000 (05:55 -0700)]
only use the system perl install
Don Armstrong [Fri, 2 Sep 2016 21:46:45 +0000 (14:46 -0700)]
add PREREQ_PM for makefile
Don Armstrong [Fri, 2 Sep 2016 17:54:36 +0000 (12:54 -0500)]
add travis.yml
Don Armstrong [Mon, 29 Aug 2016 09:07:22 +0000 (02:07 -0700)]
stop double printing in run_rsync
Don Armstrong [Wed, 10 Aug 2016 20:33:55 +0000 (13:33 -0700)]
update testcover rule
Don Armstrong [Wed, 10 Aug 2016 19:40:59 +0000 (12:40 -0700)]
remove double colon in Debbugs::CGI
Don Armstrong [Wed, 10 Aug 2016 19:37:47 +0000 (12:37 -0700)]
Use ETags; return timestamp not is_valid
- Add test for libravatar.cgi
- retrieve_libravatar and cache_location now return a timestamp, not
is_valid which can then be used to calculate the Etag
- Use HTTP::Server::Simple::CGI::Environment
Niels Thykier [Fri, 5 Aug 2016 16:22:09 +0000 (16:22 +0000)]
Drop unused my $vars
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Wed, 3 Aug 2016 20:51:20 +0000 (20:51 +0000)]
Libravatar: Refactor cache handling to avoid unncessary stat
The basic pattern of the code we are dealing with is:
my $path = cache_location(...);
if (valid_cache($path)) {
...;
}
With cache_location possibly doing a stat() of $path and valid_cache
doing at least one stat() as well. Rewrite it so that cache_location
always stats and checks the cache (since we always need it). This way
we can now guarantee this flow requires at *most* 3 stats rather than
5.
The replacement for the above code becomes:
my ($path, $is_valid) = cache_location(...);
if ($is_valid) {
...;
}
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Wed, 3 Aug 2016 21:28:59 +0000 (21:28 +0000)]
libravatar.cgi: Drop unused import/module loads
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Wed, 3 Aug 2016 21:12:13 +0000 (21:12 +0000)]
Libravatar: Lazy-load LWP::UserAgent
LWP::UserAgent costs about 0.05s to load, but we only need it when the
image is not already cached locally. Given we cache results for an
hour, it is fairly likely to be cached on subsequent requests.
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Wed, 3 Aug 2016 21:10:30 +0000 (21:10 +0000)]
Prefer "use Exporter qw(import)" to inheriting from it
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Thu, 4 Aug 2016 18:54:19 +0000 (18:54 +0000)]
d/control: Add missing Build-Depends for test
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Wed, 3 Aug 2016 19:57:05 +0000 (19:57 +0000)]
Standardize on using <br> (as opposed to <br/>)
Previously, the code used a bit of both. Since the HTML pages are
HTML, standardize on "<br>".
Signed-off-by: Niels Thykier <niels@thykier.net>
Niels Thykier [Wed, 3 Aug 2016 19:52:05 +0000 (19:52 +0000)]
html_tail.tmpl: Add missing </p>
Signed-off-by: Niels Thykier <niels@thykier.net>
Don Armstrong [Wed, 3 Aug 2016 14:35:19 +0000 (07:35 -0700)]
ignore Extra-Source-Only: yes packages and make sure the last entry gets inserted
Niels Thykier [Wed, 13 Jul 2016 19:15:31 +0000 (19:15 +0000)]
Add viewport in HTML
Signed-off-by: Niels Thykier <niels@thykier.net>
Don Armstrong [Mon, 18 Jul 2016 03:26:49 +0000 (20:26 -0700)]
it should be decode_utf8, not encode_utf8
Don Armstrong [Thu, 16 Jun 2016 16:38:00 +0000 (09:38 -0700)]
switch mailbox mime type to application/mbox
Don Armstrong [Mon, 18 Jul 2016 02:36:07 +0000 (19:36 -0700)]
Call encode_utf8 in generate_package_info
- This change fixes the issue where package maintainers names were
double encoded
Don Armstrong [Mon, 18 Jul 2016 02:20:55 +0000 (19:20 -0700)]
fix captialization of cache control
Don Armstrong [Fri, 10 Jun 2016 20:48:31 +0000 (13:48 -0700)]
set cache-control for pkgreport to 300 seconds
Don Armstrong [Fri, 10 Jun 2016 04:04:49 +0000 (21:04 -0700)]
test for Etag support in bugreport
Don Armstrong [Thu, 2 Jun 2016 00:54:26 +0000 (17:54 -0700)]
switch 17_version_cgi.t to use DebbugsTest::HTTPServer
Don Armstrong [Wed, 1 Jun 2016 19:06:43 +0000 (12:06 -0700)]
add etag and caching support to bugreport.cgi
- Calculate etag based on file modification times and all parameters
- Set etag everywhere
- Use reasonable cache retention times
- 5m minimum
- 10m for head requests and bug logs
- 7d for bug attachments (which should never change, really)
Don Armstrong [Wed, 1 Jun 2016 19:06:20 +0000 (12:06 -0700)]
abstract out no_such_bug
Don Armstrong [Wed, 1 Jun 2016 19:05:22 +0000 (12:05 -0700)]
move CGI parameter definitions earlier
Don Armstrong [Wed, 1 Jun 2016 18:07:31 +0000 (11:07 -0700)]
Make usertag_file_from_email a public function
Don Armstrong [Sun, 15 May 2016 14:59:07 +0000 (07:59 -0700)]
add test for version.cgi cache control
Don Armstrong [Wed, 13 Apr 2016 02:35:13 +0000 (19:35 -0700)]
set etags and cache-control headers
This should make the version.cgi significantly faster
- the html now should be alive for one day
- the images should live for 300 seconds
- etags should be calculated quickly, and in general before very many
things are parsed
Don Armstrong [Wed, 13 Apr 2016 02:34:39 +0000 (19:34 -0700)]
add calculate_etags and etags_do_not_match methods
Don Armstrong [Wed, 13 Apr 2016 02:34:20 +0000 (19:34 -0700)]
Make munge_url use repeatable sorting
Don Armstrong [Tue, 29 Mar 2016 00:22:54 +0000 (17:22 -0700)]
document fixes that Frank Lichtenheld contributed
Don Armstrong [Tue, 29 Mar 2016 00:21:04 +0000 (17:21 -0700)]
fix inversion of date/versions in Debbugs::Status leading to negative times argument
Frank Lichtenheld [Sun, 27 Mar 2016 15:01:46 +0000 (17:01 +0200)]
Control: Add missing full stop at the end of "Changed" messages
This leads to broken links for at least the forwarded-to case.
(Closes: #782740)
Signed-off-by: Don Armstrong <don@donarmstrong.com>
Frank Lichtenheld [Sun, 27 Mar 2016 13:26:20 +0000 (15:26 +0200)]
Bugreport: Fix problems with reassign message
* Matched hardcoded "Bug" instead of $config{bug} (which leads
to problems at least in the test suite)
* Use package_links() wrong. package_links() already adds HTML.
(Closes: #767327)
Signed-off-by: Don Armstrong <don@donarmstrong.com>
Frank Lichtenheld [Sun, 27 Mar 2016 13:24:15 +0000 (15:24 +0200)]
Extend bugreport test cases to check the output of some control messages
This exposes #767327 (wrong package links in "reassigned" message)
as a test failure.
Signed-off-by: Don Armstrong <don@donarmstrong.com>
Don Armstrong [Fri, 12 Feb 2016 21:01:03 +0000 (13:01 -0800)]
cloning had the blocking reversed
Bugs which were cloned had the block/blockedby sense reversed. This has
now been cleaned up.
Paul Wise [Thu, 15 Oct 2015 14:40:44 +0000 (22:40 +0800)]
Remove an obsolete comment
Don Armstrong [Thu, 1 Oct 2015 00:29:08 +0000 (17:29 -0700)]
handle receips state properly; check for unescaped output in mbox
Don Armstrong [Thu, 1 Oct 2015 00:14:01 +0000 (17:14 -0700)]
Fix mbox output of bugreports to properly use filehandle
Write test to actually test mbox output
Closes: #800497
Don Armstrong [Wed, 30 Sep 2015 03:41:26 +0000 (20:41 -0700)]
import :read in bugreport.cgi
Don Armstrong [Wed, 30 Sep 2015 03:31:32 +0000 (20:31 -0700)]
Add IO::InnerFile support to Debbugs::Log and use it
Use the inner_file handle in cgi/bugreport and Debbugs::CGI::Bugreport
to avoid having the entire file in memory all of the time
Eventually we will want to use an index to avoid having to read every
single line of the bug log for every single message. Some day. [If
you're reading this, you could make that day sooner!]
Don Armstrong [Sat, 26 Sep 2015 22:58:49 +0000 (15:58 -0700)]
change the scope of tempdir so that it stays in scope until after display_entity is done
Don Armstrong [Wed, 23 Sep 2015 16:17:15 +0000 (09:17 -0700)]
also use a filesystem in handle_email_message to avoid running out of memory
Don Armstrong [Wed, 23 Sep 2015 16:01:07 +0000 (11:01 -0500)]
use tmpdir for bugs instead of memory to avoid trouble with large bugs
Don Armstrong [Sat, 4 Jul 2015 23:39:03 +0000 (16:39 -0700)]
document fix for #790716 in changelog
Rafael Laboissiere [Tue, 30 Jun 2015 21:54:15 +0000 (23:54 +0200)]
Plural/singular agreement in error message
Make the error text message correctly respect the singular/plural
agreement with the number of errors. We have now "with 1 error"
instead of "with 1 errors".
Also, change the 07_control_limit unit test accordingly.
Dave Loyall [Thu, 11 Jun 2015 19:46:21 +0000 (14:46 -0500)]
point at config.debian's new location
Don Armstrong [Mon, 25 May 2015 17:38:43 +0000 (10:38 -0700)]
remove debbugging effective_type output
Don Armstrong [Mon, 25 May 2015 17:17:12 +0000 (10:17 -0700)]
use Sys::Hostname::hostname instead of hostname --fqdn
Don Armstrong [Fri, 15 May 2015 23:18:00 +0000 (16:18 -0700)]
Fix SOAP module hack to work around Date/Time encoding which broke in newer versions of SOAP::Lite. (Closes: #785405)
Don Armstrong [Tue, 24 Feb 2015 05:00:57 +0000 (21:00 -0800)]
we know that the statement is ok; use $1 to avoid taint issues
Don Armstrong [Sun, 22 Feb 2015 05:55:13 +0000 (21:55 -0800)]
next release will be 2.6.0; document more issues which have been fixed
Don Armstrong [Sat, 21 Feb 2015 22:53:58 +0000 (14:53 -0800)]
perl 5.14 does not support named capture groups, apparently
Don Armstrong [Sat, 21 Feb 2015 22:23:53 +0000 (14:23 -0800)]
it's tags, not tag
Don Armstrong [Sat, 21 Feb 2015 19:25:37 +0000 (11:25 -0800)]
allow arbitrarily complex boolean operations in usercategories selection statements
Don Armstrong [Sat, 21 Feb 2015 08:05:01 +0000 (00:05 -0800)]
add test for get_bug_order_index; fix faulty regex in while()
Don Armstrong [Sat, 21 Feb 2015 07:49:51 +0000 (23:49 -0800)]
add missing /g
Don Armstrong [Sat, 21 Feb 2015 07:45:18 +0000 (23:45 -0800)]
support or matching in fields in usercategories
Virginia King [Thu, 29 Jan 2015 20:25:52 +0000 (20:25 +0000)]
Minor edits for clarity
Virginia King [Thu, 29 Jan 2015 19:58:09 +0000 (19:58 +0000)]
Fixed MORE code block formatting