]>
git.donarmstrong.com Git - debbugs.git/log
Don Armstrong [Wed, 1 Jun 2016 19:06:43 +0000 (12:06 -0700)]
add etag and caching support to bugreport.cgi
- Calculate etag based on file modification times and all parameters
- Set etag everywhere
- Use reasonable cache retention times
- 5m minimum
- 10m for head requests and bug logs
- 7d for bug attachments (which should never change, really)
Don Armstrong [Wed, 1 Jun 2016 19:06:20 +0000 (12:06 -0700)]
abstract out no_such_bug
Don Armstrong [Wed, 1 Jun 2016 19:05:22 +0000 (12:05 -0700)]
move CGI parameter definitions earlier
Don Armstrong [Wed, 1 Jun 2016 18:07:31 +0000 (11:07 -0700)]
Make usertag_file_from_email a public function
Don Armstrong [Sun, 15 May 2016 14:59:07 +0000 (07:59 -0700)]
add test for version.cgi cache control
Don Armstrong [Wed, 13 Apr 2016 02:35:13 +0000 (19:35 -0700)]
set etags and cache-control headers
This should make the version.cgi significantly faster
- the html now should be alive for one day
- the images should live for 300 seconds
- etags should be calculated quickly, and in general before very many
things are parsed
Don Armstrong [Wed, 13 Apr 2016 02:34:39 +0000 (19:34 -0700)]
add calculate_etags and etags_do_not_match methods
Don Armstrong [Wed, 13 Apr 2016 02:34:20 +0000 (19:34 -0700)]
Make munge_url use repeatable sorting
Don Armstrong [Tue, 29 Mar 2016 00:22:54 +0000 (17:22 -0700)]
document fixes that Frank Lichtenheld contributed
Don Armstrong [Tue, 29 Mar 2016 00:21:04 +0000 (17:21 -0700)]
fix inversion of date/versions in Debbugs::Status leading to negative times argument
Frank Lichtenheld [Sun, 27 Mar 2016 15:01:46 +0000 (17:01 +0200)]
Control: Add missing full stop at the end of "Changed" messages
This leads to broken links for at least the forwarded-to case.
(Closes: #782740)
Signed-off-by: Don Armstrong <don@donarmstrong.com>
Frank Lichtenheld [Sun, 27 Mar 2016 13:26:20 +0000 (15:26 +0200)]
Bugreport: Fix problems with reassign message
* Matched hardcoded "Bug" instead of $config{bug} (which leads
to problems at least in the test suite)
* Use package_links() wrong. package_links() already adds HTML.
(Closes: #767327)
Signed-off-by: Don Armstrong <don@donarmstrong.com>
Frank Lichtenheld [Sun, 27 Mar 2016 13:24:15 +0000 (15:24 +0200)]
Extend bugreport test cases to check the output of some control messages
This exposes #767327 (wrong package links in "reassigned" message)
as a test failure.
Signed-off-by: Don Armstrong <don@donarmstrong.com>
Don Armstrong [Fri, 12 Feb 2016 21:01:03 +0000 (13:01 -0800)]
cloning had the blocking reversed
Bugs which were cloned had the block/blockedby sense reversed. This has
now been cleaned up.
Paul Wise [Thu, 15 Oct 2015 14:40:44 +0000 (22:40 +0800)]
Remove an obsolete comment
Don Armstrong [Thu, 1 Oct 2015 00:29:08 +0000 (17:29 -0700)]
handle receips state properly; check for unescaped output in mbox
Don Armstrong [Thu, 1 Oct 2015 00:14:01 +0000 (17:14 -0700)]
Fix mbox output of bugreports to properly use filehandle
Write test to actually test mbox output
Closes: #800497
Don Armstrong [Wed, 30 Sep 2015 03:41:26 +0000 (20:41 -0700)]
import :read in bugreport.cgi
Don Armstrong [Wed, 30 Sep 2015 03:31:32 +0000 (20:31 -0700)]
Add IO::InnerFile support to Debbugs::Log and use it
Use the inner_file handle in cgi/bugreport and Debbugs::CGI::Bugreport
to avoid having the entire file in memory all of the time
Eventually we will want to use an index to avoid having to read every
single line of the bug log for every single message. Some day. [If
you're reading this, you could make that day sooner!]
Don Armstrong [Sat, 26 Sep 2015 22:58:49 +0000 (15:58 -0700)]
change the scope of tempdir so that it stays in scope until after display_entity is done
Don Armstrong [Wed, 23 Sep 2015 16:17:15 +0000 (09:17 -0700)]
also use a filesystem in handle_email_message to avoid running out of memory
Don Armstrong [Wed, 23 Sep 2015 16:01:07 +0000 (11:01 -0500)]
use tmpdir for bugs instead of memory to avoid trouble with large bugs
Don Armstrong [Sat, 4 Jul 2015 23:39:03 +0000 (16:39 -0700)]
document fix for #790716 in changelog
Rafael Laboissiere [Tue, 30 Jun 2015 21:54:15 +0000 (23:54 +0200)]
Plural/singular agreement in error message
Make the error text message correctly respect the singular/plural
agreement with the number of errors. We have now "with 1 error"
instead of "with 1 errors".
Also, change the 07_control_limit unit test accordingly.
Dave Loyall [Thu, 11 Jun 2015 19:46:21 +0000 (14:46 -0500)]
point at config.debian's new location
Don Armstrong [Mon, 25 May 2015 17:38:43 +0000 (10:38 -0700)]
remove debbugging effective_type output
Don Armstrong [Mon, 25 May 2015 17:17:12 +0000 (10:17 -0700)]
use Sys::Hostname::hostname instead of hostname --fqdn
Don Armstrong [Fri, 15 May 2015 23:18:00 +0000 (16:18 -0700)]
Fix SOAP module hack to work around Date/Time encoding which broke in newer versions of SOAP::Lite. (Closes: #785405)
Don Armstrong [Tue, 24 Feb 2015 05:00:57 +0000 (21:00 -0800)]
we know that the statement is ok; use $1 to avoid taint issues
Don Armstrong [Sun, 22 Feb 2015 05:55:13 +0000 (21:55 -0800)]
next release will be 2.6.0; document more issues which have been fixed
Don Armstrong [Sat, 21 Feb 2015 22:53:58 +0000 (14:53 -0800)]
perl 5.14 does not support named capture groups, apparently
Don Armstrong [Sat, 21 Feb 2015 22:23:53 +0000 (14:23 -0800)]
it's tags, not tag
Don Armstrong [Sat, 21 Feb 2015 19:25:37 +0000 (11:25 -0800)]
allow arbitrarily complex boolean operations in usercategories selection statements
Don Armstrong [Sat, 21 Feb 2015 08:05:01 +0000 (00:05 -0800)]
add test for get_bug_order_index; fix faulty regex in while()
Don Armstrong [Sat, 21 Feb 2015 07:49:51 +0000 (23:49 -0800)]
add missing /g
Don Armstrong [Sat, 21 Feb 2015 07:45:18 +0000 (23:45 -0800)]
support or matching in fields in usercategories
Virginia King [Thu, 29 Jan 2015 20:25:52 +0000 (20:25 +0000)]
Minor edits for clarity
Virginia King [Thu, 29 Jan 2015 19:58:09 +0000 (19:58 +0000)]
Fixed MORE code block formatting
Virginia King [Thu, 29 Jan 2015 19:22:45 +0000 (19:22 +0000)]
Fixed MORE code block formatting
Virginia King [Thu, 29 Jan 2015 19:19:04 +0000 (19:19 +0000)]
Fixed code block formatting
Virginia King [Thu, 29 Jan 2015 19:14:09 +0000 (19:14 +0000)]
Updated the installation instructions
Virginia King [Thu, 29 Jan 2015 17:14:31 +0000 (17:14 +0000)]
Adjusted README.md with minor structural changes and edits
Virginia King [Thu, 29 Jan 2015 16:02:01 +0000 (16:02 +0000)]
Merge remote-tracking branch 'don/master' into pindy/docs
Don Armstrong [Wed, 21 Jan 2015 06:56:43 +0000 (22:56 -0800)]
move scripts/config to examples/
Don Armstrong [Wed, 21 Jan 2015 06:31:23 +0000 (22:31 -0800)]
depend on apache2 or httpd
Don Armstrong [Thu, 15 Jan 2015 01:18:57 +0000 (17:18 -0800)]
switch to using Require all granted from old Options allow,deny
Don Armstrong [Thu, 15 Jan 2015 01:08:29 +0000 (17:08 -0800)]
use + for symlinks and multiviews; newer apache doesn't like it otherwise
Don Armstrong [Thu, 15 Jan 2015 01:03:40 +0000 (17:03 -0800)]
we don't need to expose the txt directory either
Don Armstrong [Thu, 15 Jan 2015 01:01:22 +0000 (17:01 -0800)]
remove irrelevant configuration options which have a sane default from the configuration file
Don Armstrong [Thu, 15 Jan 2015 01:00:49 +0000 (17:00 -0800)]
we shouldn't expose db
Don Armstrong [Thu, 15 Jan 2015 00:54:23 +0000 (16:54 -0800)]
use /var/log/apache2/ as the default error log location
Don Armstrong [Fri, 21 Nov 2014 23:02:55 +0000 (15:02 -0800)]
allow " in other places too (HTML::Escape doesn't always use ' anymore)
Don Armstrong [Thu, 6 Nov 2014 04:26:32 +0000 (20:26 -0800)]
Stop URLs at " too. Thanks to Vincent Lefevre (Closes: #766354).
Virginia King [Wed, 14 Jan 2015 08:43:04 +0000 (19:43 +1100)]
Super basic intro
Don Armstrong [Tue, 11 Nov 2014 22:52:06 +0000 (14:52 -0800)]
ignore addresses which do not have @ to work around people who use improperly formatted From: address lines
Don Armstrong [Tue, 11 Nov 2014 22:51:35 +0000 (14:51 -0800)]
use uri_escape_utf8 instead of uri_escape
Don Armstrong [Thu, 6 Nov 2014 01:03:57 +0000 (17:03 -0800)]
Add affects to bugreport.cgi package info header (Closes: #609687).
Don Armstrong [Fri, 31 Oct 2014 06:24:06 +0000 (23:24 -0700)]
Merge remote-tracking branch 'pindy/pindy/docs'
Virginia King [Tue, 28 Oct 2014 12:24:11 +0000 (23:24 +1100)]
Replaced dead website link with current pages
Virginia King [Tue, 28 Oct 2014 12:14:46 +0000 (23:14 +1100)]
Converted to markdown
Virginia King [Tue, 28 Oct 2014 09:56:28 +0000 (20:56 +1100)]
Added contributing section
Don Armstrong [Mon, 27 Oct 2014 19:29:18 +0000 (12:29 -0700)]
fix the hidden parameters not being included in the pkgindex template
Don Armstrong [Fri, 26 Sep 2014 18:10:22 +0000 (11:10 -0700)]
fix missing semicolon; check that HTTP_HOST is defined
Don Armstrong [Fri, 26 Sep 2014 17:47:50 +0000 (10:47 -0700)]
unfinalize; document XSS fix
Don Armstrong [Fri, 26 Sep 2014 17:28:58 +0000 (10:28 -0700)]
fix XSS in version.cgi
Don Armstrong [Thu, 4 Sep 2014 15:37:42 +0000 (08:37 -0700)]
cleanup_eval_fail should match all croak messages; was missing /m
Don Armstrong [Wed, 30 Jul 2014 21:10:46 +0000 (14:10 -0700)]
remove leading and trailing spaces in references and replyto
Don Armstrong [Tue, 29 Jul 2014 20:00:55 +0000 (13:00 -0700)]
fix multipart messages when quoting the body; bodyhandle does not necessarily exist in those cases; fixes #756427
Don Armstrong [Tue, 29 Jul 2014 05:38:27 +0000 (22:38 -0700)]
Add reply links to individual bug messages with headers (closes: #412815). Thanks to martin krafft, Paul Wise, and Julien Valroff.
Don Armstrong [Sat, 30 Nov 2013 04:35:40 +0000 (20:35 -0800)]
eliminate convert to utf8 warning
Don Armstrong [Fri, 30 May 2014 00:47:37 +0000 (17:47 -0700)]
handle undefined headers by just returning ''
Don Armstrong [Wed, 7 May 2014 01:41:53 +0000 (18:41 -0700)]
fix the links to reassigned packages in the html entries
Don Armstrong [Wed, 7 May 2014 01:41:28 +0000 (18:41 -0700)]
fix #747267 by causing the closing regex to require a space, or some other non-word character
Don Armstrong [Wed, 23 Apr 2014 15:55:17 +0000 (08:55 -0700)]
don't go past end of @msg when setting
Don Armstrong [Mon, 21 Apr 2014 23:09:12 +0000 (16:09 -0700)]
handle package, msgid, and keywords being undefined
Don Armstrong [Wed, 16 Apr 2014 17:10:46 +0000 (10:10 -0700)]
Also check for package being defined before checking package for spaces and slashes
Don Armstrong [Wed, 16 Apr 2014 17:10:17 +0000 (10:10 -0700)]
check for package being defined before source regex
Don Armstrong [Tue, 15 Apr 2014 23:42:29 +0000 (16:42 -0700)]
Because we now properly decode UTF8, in order to strip the BOM, we
need to strip \N{U+FEFF}, not 0xEFBBBF.
Don Armstrong [Fri, 7 Feb 2014 20:06:51 +0000 (12:06 -0800)]
switch the libravatar url to not prefix with http://
Don Armstrong [Sat, 30 Nov 2013 23:57:44 +0000 (15:57 -0800)]
Support CVEs surrounded by parenthesis (closes: #662228). Thanks to Ari Pollak.
Don Armstrong [Sat, 30 Nov 2013 23:41:11 +0000 (15:41 -0800)]
Fix title of $gBug (closes: #546383). Thanks to Jakub Wilk.
Don Armstrong [Sat, 30 Nov 2013 03:02:21 +0000 (19:02 -0800)]
revert part of
593feb86 ; Source_maintainer has a different format, and this wouldn't parse maintainers properly anyway; this fixes #730835
Don Armstrong [Fri, 29 Nov 2013 19:37:27 +0000 (11:37 -0800)]
set cleanup=>1 and use remove_tree instead to hopefully clean up tempdir residue
Don Armstrong [Fri, 29 Nov 2013 19:23:28 +0000 (11:23 -0800)]
we need to unlink the temporary file name, not the temporary file handle
Don Armstrong [Thu, 21 Nov 2013 05:34:34 +0000 (21:34 -0800)]
handle source maintainer having the archive name properly
Don Armstrong [Tue, 29 Oct 2013 20:56:53 +0000 (13:56 -0700)]
uri_escape e-mails in libravatar (closes: #728034). Thanks to Fabien Givors for pointing this out and providing a patch.
Don Armstrong [Wed, 2 Oct 2013 00:29:24 +0000 (17:29 -0700)]
add $gLibravatarCacheDir
Don Armstrong [Wed, 2 Oct 2013 00:29:07 +0000 (17:29 -0700)]
fix cache location regex
Don Armstrong [Tue, 1 Oct 2013 23:42:35 +0000 (16:42 -0700)]
Debbugs::Libravatar requires convert from imagemagick
Don Armstrong [Tue, 1 Oct 2013 23:00:32 +0000 (16:00 -0700)]
set content type even if we use apache to serve the file
Don Armstrong [Tue, 1 Oct 2013 22:03:44 +0000 (15:03 -0700)]
serve_cache is not exported by Debbugs::Libravatar
Don Armstrong [Tue, 1 Oct 2013 21:53:59 +0000 (14:53 -0700)]
Merge branch 'master' into don/libravatar
Don Armstrong [Tue, 1 Oct 2013 21:50:25 +0000 (14:50 -0700)]
attachments must be encoded into octets
Don Armstrong [Tue, 1 Oct 2013 19:40:37 +0000 (12:40 -0700)]
Merge branch 'master' into don/libravatar
Conflicts:
Debbugs/CGI/Bugreport.pm
debian/control
Don Armstrong [Tue, 1 Oct 2013 19:39:12 +0000 (12:39 -0700)]
use sub style of constants to avoid needing mod_perl always
Don Armstrong [Tue, 1 Oct 2013 19:19:27 +0000 (12:19 -0700)]
remove useless my $_ in encode_utf8_structure
Don Armstrong [Tue, 1 Oct 2013 19:19:08 +0000 (12:19 -0700)]
fix sigchild and sigpipe handling in test
Don Armstrong [Tue, 1 Oct 2013 19:18:47 +0000 (12:18 -0700)]
specify encoding in Debbugs/MIME.pm pod
Don Armstrong [Tue, 1 Oct 2013 19:17:51 +0000 (12:17 -0700)]
use abs location for libmagic and fix retrieve libravatar spelling mistake
Don Armstrong [Tue, 1 Oct 2013 19:15:06 +0000 (12:15 -0700)]
fix how e-mails are passed to the avatar script