]> git.donarmstrong.com Git - lilypond.git/log
lilypond.git
13 years agoDoc: CG: add bib2texi.py to website scripts.
Graham Percival [Thu, 19 Aug 2010 14:32:28 +0000 (15:32 +0100)]
Doc: CG: add bib2texi.py to website scripts.

13 years agoBuild: use bibs for website build.
Graham Percival [Thu, 19 Aug 2010 14:27:06 +0000 (15:27 +0100)]
Build: use bibs for website build.

Adds it to the "make website"; previous commit added it to the
"make doc" stuff.

13 years agoBuild: remove ~ from editor names in .bst.
Graham Percival [Thu, 19 Aug 2010 14:03:35 +0000 (15:03 +0100)]
Build: remove ~ from editor names in .bst.

13 years agoWebsite build: use .bib files for the references.
Graham Percival [Thu, 19 Aug 2010 13:08:18 +0000 (14:08 +0100)]
Website build: use .bib files for the references.

13 years agoBuild: bib2html+html2texi => bib2texi.
Graham Percival [Wed, 18 Aug 2010 14:36:57 +0000 (15:36 +0100)]
Build: bib2html+html2texi => bib2texi.

Partial fix for 1162.

13 years agoBuild: remove superfulous {} in .bib.
Graham Percival [Thu, 19 Aug 2010 11:41:16 +0000 (12:41 +0100)]
Build: remove superfulous {} in .bib.

13 years agoBuild: remove \cite{} from bibs.
Graham Percival [Thu, 19 Aug 2010 11:26:09 +0000 (12:26 +0100)]
Build: remove \cite{} from bibs.

The output has just been [] for a while, and nobody
noticed/complained, and nobody's particularly interested in our
bibliography stuff anyway.

13 years agoCompile fix
Till Paala [Thu, 19 Aug 2010 10:59:36 +0000 (13:59 +0300)]
Compile fix

13 years agoDoc-de: updates to simultaneous and spacing
Till Paala [Thu, 19 Aug 2010 10:05:52 +0000 (13:05 +0300)]
Doc-de: updates to simultaneous and spacing

13 years agoDocs: Hymn template: ragged-bottom not needed
Trevor Daniels [Thu, 19 Aug 2010 08:33:23 +0000 (09:33 +0100)]
Docs: Hymn template: ragged-bottom not needed

13 years agoDocs: NR 2.1 Vocal
Trevor Daniels [Thu, 19 Aug 2010 08:22:58 +0000 (09:22 +0100)]
Docs: NR 2.1 Vocal

 - add Score layouts (first draft)

13 years agoDoc: CG: cleanup formatting in releases chapter.
Graham Percival [Wed, 18 Aug 2010 12:17:15 +0000 (13:17 +0100)]
Doc: CG: cleanup formatting in releases chapter.

13 years agoscripts/auxiliar/doc-section.sh Define NAME before using $NAME
Carl Sorensen [Wed, 18 Aug 2010 16:28:12 +0000 (10:28 -0600)]
scripts/auxiliar/doc-section.sh  Define NAME before using $NAME

13 years agoAdd scripts/auxiliar/cg-section.sh plus documentation
Carl Sorensen [Wed, 18 Aug 2010 16:00:59 +0000 (10:00 -0600)]
Add scripts/auxiliar/cg-section.sh plus documentation

13 years agoRemove unused lines from scripts/auxiliar/doc-section.sh
Carl Sorensen [Wed, 18 Aug 2010 14:42:33 +0000 (08:42 -0600)]
Remove unused lines from scripts/auxiliar/doc-section.sh

13 years agoBuild -- Add scripts/auxiliar/doc-section.sh
Carl Sorensen [Wed, 18 Aug 2010 14:10:00 +0000 (08:10 -0600)]
Build -- Add scripts/auxiliar/doc-section.sh

13 years agoDocs: add py script to check cross-references
Trevor Daniels [Wed, 18 Aug 2010 11:59:43 +0000 (12:59 +0100)]
Docs: add py script to check cross-references

 - for use by doc editors to check cross-references
   in the doc tree are correct

 - run at top level of git repository

 - see comments for known issues

 - files to be checked/excluded are in ref_check.tely

13 years agoDocs: NR 2.1.7 References for choral
Trevor Daniels [Tue, 17 Aug 2010 22:44:20 +0000 (23:44 +0100)]
Docs: NR 2.1.7 References for choral

 - first draft

13 years agoDocs: NR -- add information on partcombine and autoBeamOff
Carl Sorensen [Tue, 17 Aug 2010 16:44:16 +0000 (10:44 -0600)]
Docs: NR -- add information on partcombine and autoBeamOff

13 years agoDoc: Usage.itely - more script line breaks
James Lowe [Tue, 17 Aug 2010 06:12:36 +0000 (07:12 +0100)]
Doc: Usage.itely - more script line breaks

Second script example edited to avoid running off edge of PDF

Split script using trailing backslash

Also edited comment within script as it too was running of edge of PDF

13 years agoFix #544.
Neil Puttock [Tue, 17 Aug 2010 15:12:31 +0000 (16:12 +0100)]
Fix #544.

* input/regression (partial-polymetric.ly):

  new regtest

* lily/parser.yy (command-element):

  simplify syntax construction for \partial: call single constructor,
  soft-coded in scheme

* scm/ly-syntax-constructor (partial):

  new syntax-constructor for \partial using descend-to-context to set
  measurePosition

13 years agoDoc-de: update and check of rhythms.itely
Till Paala [Tue, 17 Aug 2010 15:00:13 +0000 (18:00 +0300)]
Doc-de: update and check of rhythms.itely

13 years agoAdd point-and-click to non-default rehearsal marks.
Neil Puttock [Tue, 17 Aug 2010 14:39:10 +0000 (15:39 +0100)]
Add point-and-click to non-default rehearsal marks.

* lily/parser.yy (command_element):

  call make-mark-set via MAKE_SYNTAX so input location can be used

* scm/ly-syntax-constructors.scm (make-mark-set):

  set 'origin for MarkEvent

* scm/music-functions.scm (make-mark-set):

  move to ly-syntax-constructors.scm

13 years agoDoc-de: updates and check of repeats.itely
Till Paala [Tue, 17 Aug 2010 12:37:42 +0000 (15:37 +0300)]
Doc-de: updates and check of repeats.itely

13 years agoDocs: NR 2.1 Vocal music: rework section headings
Trevor Daniels [Tue, 17 Aug 2010 12:11:20 +0000 (13:11 +0100)]
Docs: NR 2.1 Vocal music: rework section headings

 - move material around to make a clearer distinction
   between common and special notation (nothing has been
   deleted)

 - add new section headings to cover specific types of
   vocal music

 - much material remains to be added at places indicated
   by TBC (to be completed), and TODOs.

13 years agoDoc-de: 2. update and check of pitches.itely
Till Paala [Tue, 17 Aug 2010 09:20:34 +0000 (12:20 +0300)]
Doc-de: 2. update and check of pitches.itely

13 years agoDocs: amend vocal ensemble templates - texidocs
Trevor Daniels [Tue, 17 Aug 2010 09:20:16 +0000 (10:20 +0100)]
Docs: amend vocal ensemble templates - texidocs

 - update commits in texidocs

13 years agoDocs: amend vocal ensemble template
Trevor Daniels [Tue, 17 Aug 2010 09:11:32 +0000 (10:11 +0100)]
Docs: amend vocal ensemble template

 - remove erroneous skips in Lyrics

13 years agoDocs: add hymn template to vocal snippet list
Trevor Daniels [Tue, 17 Aug 2010 09:00:46 +0000 (10:00 +0100)]
Docs: add hymn template to vocal snippet list

 - I missed this changed file when I ran makelsr.py

13 years agoDoc: Usage.itely - script example line breaks
James Lowe [Mon, 16 Aug 2010 14:30:16 +0000 (15:30 +0100)]
Doc: Usage.itely - script example line breaks

Script example is too long for a single line and causes information to
run of edge of PDF.

Split up script using trailing backslash onto multiple line

13 years agoDocs: CG: Shorten lines so all the line is visible in html
Trevor Daniels [Mon, 16 Aug 2010 16:42:03 +0000 (17:42 +0100)]
Docs: CG: Shorten lines so all the line is visible in html

13 years agoT1041 - Add descriptions for \bookOutputSuffix and \bookOutputName to documents ...
Ian Hulin [Mon, 16 Aug 2010 13:47:36 +0000 (14:47 +0100)]
T1041 - Add descriptions for \bookOutputSuffix and \bookOutputName to documents (NR).

13 years agoDoc-fr: fundamental
Jean-Charles Malahieude [Mon, 16 Aug 2010 14:34:43 +0000 (16:34 +0200)]
Doc-fr: fundamental

- fix xref to convert-ly
- strip whitespace

13 years agoMerge branch 'master' of git+ssh://git.savannah.gnu.org/srv/git/lilypond
David Kastrup [Mon, 16 Aug 2010 10:41:46 +0000 (12:41 +0200)]
Merge branch 'master' of git+ssh://git.savannah.gnu.org/srv/git/lilypond

13 years agolilypond-book.itely: commit a fix for issue 1221
David Kastrup [Mon, 16 Aug 2010 10:38:54 +0000 (12:38 +0200)]
lilypond-book.itely: commit a fix for issue 1221

13 years agoDocs: LM Templates: add hymn tune template
Trevor Daniels [Mon, 16 Aug 2010 09:11:18 +0000 (10:11 +0100)]
Docs: LM Templates: add hymn tune template

13 years agoDoc: slightly better explanation of \espressivo.
Graham Percival [Mon, 16 Aug 2010 08:30:50 +0000 (09:30 +0100)]
Doc: slightly better explanation of \espressivo.

13 years agoDoc: 989 - 4 more reg tests added
James Lowe [Sat, 14 Aug 2010 19:19:23 +0000 (20:19 +0100)]
Doc: 989 - 4 more reg tests added

Dynamics-context-textspan.ly
Dynamics-custom-text-spanner-postfix.ly
Dymanics-hairpin-length.ly
Dynamics-text-spanner-postfix.ly

Removed extremely poor (and confusing) example of what was already covered by \espressivo

Removed index reference to Hal Leonard

13 years agoCompile fix
Till Paala [Sun, 15 Aug 2010 22:57:57 +0000 (01:57 +0300)]
Compile fix

13 years agoDoc-de: 1. update of pitches.itely
Till Paala [Sun, 15 Aug 2010 22:02:38 +0000 (01:02 +0300)]
Doc-de: 1. update of pitches.itely

13 years agoMerge branch 'lilypond/translation' of ssh://git.sv.gnu.org/srv/git/lilypond into...
Till Paala [Sun, 15 Aug 2010 21:59:59 +0000 (00:59 +0300)]
Merge branch 'lilypond/translation' of ssh://git.sv.gnu.org/srv/git/lilypond into lilypond/translation

13 years agoCompiling fix
Till Paala [Sun, 15 Aug 2010 21:59:05 +0000 (00:59 +0300)]
Compiling fix

13 years agoDoc-fr: running.itely fully translated
Jean-Charles Malahieude [Sun, 15 Aug 2010 18:43:14 +0000 (20:43 +0200)]
Doc-fr: running.itely fully translated

13 years agoDoc: CG: begin cleaning up Releases chapter.
Graham Percival [Sun, 15 Aug 2010 17:14:33 +0000 (18:14 +0100)]
Doc: CG: begin cleaning up Releases chapter.

13 years agoDoc-de: updates to the notation manual
Till Paala [Sun, 15 Aug 2010 16:28:43 +0000 (19:28 +0300)]
Doc-de: updates to the notation manual

Updating files
*keyboard.itely
* notation-appendices.itely
*notation.itely
*percussion.itely

13 years agoDoc-de: update and check of input.itely
Till Paala [Sun, 15 Aug 2010 15:57:02 +0000 (18:57 +0300)]
Doc-de: update and check of input.itely

13 years agoDoc-de: updates to the notation manual
Till Paala [Sun, 15 Aug 2010 14:25:33 +0000 (17:25 +0300)]
Doc-de: updates to the notation manual

Updates for
  *chords.itely
  *expressive.itely
  *fretted-strings.itely

13 years agoDoc: CG: add warning about test-output-distance.
Graham Percival [Sat, 14 Aug 2010 11:53:52 +0000 (12:53 +0100)]
Doc: CG: add warning about test-output-distance.

This duplicates the later warning, but we need it at that point
for Bug Squad people.

13 years agoDoc-fr: some more strings in docu-fr.po
Jean-Charles Malahieude [Sat, 14 Aug 2010 12:43:44 +0000 (14:43 +0200)]
Doc-fr: some more strings in docu-fr.po

13 years agoDoc-fr: notation-appendices update
Jean-Charles Malahieude [Sat, 14 Aug 2010 12:43:00 +0000 (14:43 +0200)]
Doc-fr: notation-appendices update

13 years agoDoc-fr: typos and strip whitespaces
Jean-Charles Malahieude [Sat, 14 Aug 2010 12:41:55 +0000 (14:41 +0200)]
Doc-fr: typos and strip whitespaces

13 years agoFix merge errors from previous patch
Carl Sorensen [Fri, 13 Aug 2010 23:23:39 +0000 (17:23 -0600)]
Fix merge errors from previous patch

13 years agoFix 1198: Fix displayLilyMusic for \time and #(set-time-signature)
Carl Sorensen [Thu, 5 Aug 2010 02:28:58 +0000 (20:28 -0600)]
Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature)

create TimeSignatureMusic to allow the display to work properly

* scm/define-music-callbacks.scm
  Create a new file for music callbacks that are used by iterators to
  create music events.  Moved multimeasure rest and ottava callbacks from
  scm/define-music-types.scm.
  Added callback for TimeSignatureMusic.

* scm/define-music-display-methods.scm
  define a display method for TimeSignatureMusic
  remove extra-display-methods for ContextSpeccedMusic and Timing that
  caught \time

* scm/define-music-properties.scm
  define beat-structure as a music property

* scm/define-music-types.scm
  Move callbacks for multimeasure rests and ottava to scm/define-music-callbacks.scm
  add TimeSignatureMusic

* scm/lily.scm
  Add scm/define-music-callbacks.scm to load list

* scm/music-functions.scm
  replace calls to make-beam-rule-time-signature-set with calls
  to make-music 'TimeSignatureMusic

13 years agopage.scm: Remove duplicate exported binding.
Patrick McCarty [Fri, 13 Aug 2010 23:04:25 +0000 (16:04 -0700)]
page.scm: Remove duplicate exported binding.

13 years agoFix compile.
Patrick McCarty [Fri, 13 Aug 2010 22:56:51 +0000 (15:56 -0700)]
Fix compile.

Any double quotes in docstrings must be escaped.

Also, clean up line breaks in the example.

13 years agoAdd independent control of thickness and offset for underline markup
Kieren MacMillan [Thu, 27 May 2010 15:48:37 +0000 (09:48 -0600)]
Add independent control of thickness and offset for underline markup

13 years agoSlight correction for markup-path-linejoin.ly.
Patrick McCarty [Fri, 13 Aug 2010 22:22:34 +0000 (15:22 -0700)]
Slight correction for markup-path-linejoin.ly.

13 years agoAdd regression tests for \path markup command.
Patrick McCarty [Fri, 13 Aug 2010 21:42:46 +0000 (14:42 -0700)]
Add regression tests for \path markup command.

13 years agoRemove traces of 'connected-shape.
Patrick McCarty [Fri, 13 Aug 2010 19:17:18 +0000 (12:17 -0700)]
Remove traces of 'connected-shape.

Since 'path is a superset of the functionality provided by
'connected-shape, we no longer need 'connected-shape.

13 years agoImplement \eyeglasses with `make-path-markup'.
Patrick McCarty [Sat, 19 Jun 2010 10:37:40 +0000 (03:37 -0700)]
Implement \eyeglasses with `make-path-markup'.

This commit reworks PostScript command sequence used for \eyeglasses to
use the new path markup command.

By doing so, \eyeglasses can now be used with the SVG backend as well as
the PS backend.

13 years agoAdd a new \path markup command.
Patrick McCarty [Sat, 19 Jun 2010 04:06:18 +0000 (21:06 -0700)]
Add a new \path markup command.

Details on usage are found in the docstring.

13 years agoUse 'path instead of 'connected-shape.
Patrick McCarty [Tue, 27 Jul 2010 22:29:08 +0000 (15:29 -0700)]
Use 'path instead of 'connected-shape.

Though this is slightly more complicated, 'connected-shape is really
just a special case of 'path.

13 years agoMake the origin of a connected-shape configurable.
Patrick McCarty [Fri, 13 Aug 2010 19:50:26 +0000 (12:50 -0700)]
Make the origin of a connected-shape configurable.

`connected-shape-min-max' assumes that the path will start at point
'(0 . 0), so we want to decouple this, permitting the origin to start
anywhere.

13 years agoExtract `connected-shape-min-max' into a new routine.
Patrick McCarty [Sat, 24 Jul 2010 03:30:31 +0000 (20:30 -0700)]
Extract `connected-shape-min-max' into a new routine.

Other procedures may want access to this routine, since it calculates
the exact extents of any path.

13 years agoAdd warnings for invalid 'path styles.
Patrick McCarty [Mon, 21 Jun 2010 22:03:26 +0000 (15:03 -0700)]
Add warnings for invalid 'path styles.

Since there are only six styles, it is trivial to do error checking
here.

13 years agoSupport configurable join and cap styles for 'path.
Patrick McCarty [Sat, 19 Jun 2010 03:16:06 +0000 (20:16 -0700)]
Support configurable join and cap styles for 'path.

13 years agoDoc-de: update and check of notation-appendices
Till Paala [Fri, 13 Aug 2010 20:41:07 +0000 (23:41 +0300)]
Doc-de: update and check of notation-appendices

13 years agoRelease: bump version.
Graham Percival [Fri, 13 Aug 2010 20:18:46 +0000 (21:18 +0100)]
Release: bump version.

13 years agoBuild: fix goof in previous fix. release/2.13.30-1
Graham Percival [Fri, 13 Aug 2010 19:23:54 +0000 (20:23 +0100)]
Build: fix goof in previous fix.

13 years agoBuild: dist fix.
Graham Percival [Fri, 13 Aug 2010 19:07:51 +0000 (20:07 +0100)]
Build: dist fix.

13 years agoRelease: update news.
Graham Percival [Fri, 13 Aug 2010 18:36:21 +0000 (19:36 +0100)]
Release: update news.

13 years agoMerge commit 'origin' into release/unstable
Graham Percival [Fri, 13 Aug 2010 18:36:05 +0000 (19:36 +0100)]
Merge commit 'origin' into release/unstable

13 years agoDoc-de: updating linking
Till Paala [Fri, 13 Aug 2010 18:08:36 +0000 (21:08 +0300)]
Doc-de: updating linking

13 years agoDoc-de: update and check of changing-defaults
Till Paala [Fri, 13 Aug 2010 18:08:04 +0000 (21:08 +0300)]
Doc-de: update and check of changing-defaults

13 years agoFix 1084.
Joe Neeman [Fri, 6 Aug 2010 22:35:47 +0000 (15:35 -0700)]
Fix 1084.

Don't include irrelevant contents when checking for equality of files.

13 years agoFix 1201.
Joe Neeman [Fri, 13 Aug 2010 17:30:40 +0000 (10:30 -0700)]
Fix 1201.

Initialize all variables in Line_details.

13 years agoFix doc string for fret-diagrams-xo-label.ly
Carl Sorensen [Fri, 13 Aug 2010 14:00:29 +0000 (08:00 -0600)]
Fix doc string for fret-diagrams-xo-label.ly

13 years agoDoc: CG: updates to Bug Squad.
Graham Percival [Fri, 13 Aug 2010 12:26:17 +0000 (13:26 +0100)]
Doc: CG: updates to Bug Squad.

13 years agoDoc-de: updates to the website
Till Paala [Fri, 13 Aug 2010 10:54:45 +0000 (13:54 +0300)]
Doc-de: updates to the website

13 years agoDocs: AU: document shell redirects
Trevor Daniels [Fri, 13 Aug 2010 09:55:32 +0000 (10:55 +0100)]
Docs: AU: document shell redirects

 - thanks, Eluze, Graham

13 years agoDoc-de: updating macros and ancient notation
Till Paala [Fri, 13 Aug 2010 08:30:34 +0000 (11:30 +0300)]
Doc-de: updating macros and ancient notation

13 years agoDoc-de: updates for the learning manual
Till Paala [Fri, 13 Aug 2010 08:25:08 +0000 (11:25 +0300)]
Doc-de: updates for the learning manual

13 years agoDoc-de: updating includes and essay
Till Paala [Fri, 13 Aug 2010 07:23:21 +0000 (10:23 +0300)]
Doc-de: updating includes and essay

Updates to includes files, essay and exending

13 years agoCorrect German translator's name in authors.itexi
Till Paala [Fri, 13 Aug 2010 07:10:24 +0000 (10:10 +0300)]
Correct German translator's name in authors.itexi

13 years agoAdd scripts/auxiliar/update-patch-version
Carl Sorensen [Fri, 13 Aug 2010 03:35:23 +0000 (21:35 -0600)]
Add scripts/auxiliar/update-patch-version

Add script that will update all of the version strings in
snippets if the version changes between initial posting and
final approval

13 years agoFix 1063: Nested property revert
Rodolfo Zitellini [Thu, 27 May 2010 03:30:00 +0000 (21:30 -0600)]
Fix 1063:  Nested property revert

13 years agoCreate ly:grob-chain-callback from chain_callback
Mike Solomon [Thu, 12 Aug 2010 22:56:34 +0000 (23:56 +0100)]
Create ly:grob-chain-callback from chain_callback

Signed-off-by: Neil Puttock <n.puttock@gmail.com>
13 years agoCopy input location from original event for MultiMeasureTextEvent.
Neil Puttock [Thu, 12 Aug 2010 19:52:37 +0000 (20:52 +0100)]
Copy input location from original event for MultiMeasureTextEvent.

This preserves the point-and-click info from the originating TextScriptEvent.

* scm/ly-syntax-constructors.scm (script-to-mmrest-text):

  read 'origin, copy to new event

13 years agoRelease: update news.
Graham Percival [Thu, 12 Aug 2010 13:05:58 +0000 (14:05 +0100)]
Release: update news.

13 years agoDoc: CG: bump memory recommendation for VM.
Graham Percival [Thu, 12 Aug 2010 12:40:08 +0000 (13:40 +0100)]
Doc: CG: bump memory recommendation for VM.

13 years agoBuild: fix 1167.
Graham Percival [Sat, 7 Aug 2010 05:25:29 +0000 (06:25 +0100)]
Build: fix 1167.

I think it works.  It doesn't seem to mess up the offline build,
at least.  I'm not 100% certain about the exact url, but it
definitely changes the url, so I guess we'll just have to wait
until 2.13.30 to see if it really works or not?

13 years agoDoc: CG: improve website build instructions.
Graham Percival [Thu, 12 Aug 2010 08:10:35 +0000 (09:10 +0100)]
Doc: CG: improve website build instructions.

13 years agoDoc-fr: tweaks.itely full review
Jean-Charles Malahieude [Wed, 11 Aug 2010 21:01:31 +0000 (23:01 +0200)]
Doc-fr: tweaks.itely full review

13 years agoDoc: CG: add instructions for renaming a snippet.
Graham Percival [Tue, 10 Aug 2010 15:33:48 +0000 (16:33 +0100)]
Doc: CG: add instructions for renaming a snippet.

13 years agoDocs: AU: output can be directed to a folder
Trevor Daniels [Wed, 11 Aug 2010 07:50:03 +0000 (08:50 +0100)]
Docs: AU: output can be directed to a folder

 - thanks again, Eluze

13 years agoWeb: optimise example scroll-bar
Trevor Daniels [Tue, 10 Aug 2010 22:30:38 +0000 (23:30 +0100)]
Web: optimise example scroll-bar

 - move text slightly to left within scroll-bar so first
   character is not lost in IE

 - increase length as far as possible; anything greater and
   the scroll-bar runs off the right margin of the column
   in small windows

13 years agoWeb: Remove linebreak from URL reference.
Patrick McCarty [Tue, 10 Aug 2010 21:19:37 +0000 (14:19 -0700)]
Web: Remove linebreak from URL reference.

13 years agoWeb-fr: Make links in all top level pages bold
Jean-Charles Malahieude [Tue, 10 Aug 2010 17:34:25 +0000 (19:34 +0200)]
Web-fr: Make links in all top level pages bold

13 years agoWeb: add email address
Trevor Daniels [Tue, 10 Aug 2010 15:15:29 +0000 (16:15 +0100)]
Web: add email address

13 years agoWeb: Make links in all top level pages bold
Trevor Daniels [Tue, 10 Aug 2010 14:59:13 +0000 (15:59 +0100)]
Web: Make links in all top level pages bold

 - thanks for the suggestion, Graham