David Kastrup [Wed, 28 Jul 2010 13:49:48 +0000 (15:49 +0200)]
feta-accordion.mf, convertrules.py, musicxml2ly.py, accordion-discant-symbols.ly: sanitize accordion symbol names
Symbol names like "accordion.accStdbase" are turned into
"accordion.stdbass" in order to get more consistent and obvious names.
Conversion rule is provided as well, and the single snippet is adapted.
James Lowe [Tue, 27 Jul 2010 07:31:40 +0000 (08:31 +0100)]
Doc: 989 - reg test chord-scripts.ly added to NR
No new snippet added, but new examples added and modified
in sections pertaining to chorded notes, chord mode and chord repetition
to illustrate the usage and limits of chorded notes with
articulations, ornamentation and dynamics attached to chords.
Added some cross referecences and an additional entry in known issues for
chordmode rather than show an example that 'wouldn't do anything'
Neil Puttock [Mon, 26 Jul 2010 22:01:34 +0000 (23:01 +0100)]
Fix #765: Display method for \ottava.
Since \ottava currently uses ApplyContext to set the relevant context
properties which trigger creation of an ottava bracket, the information
useful to its display method (i.e., the octavation) is inaccessible: the only
music property which can be extracted is the argument to ApplyContext, its
procedure.
By wrapping the existing code which creates an ottava bracket (make-ottava-set)
in a synthetic event, the octavation can be passed as a music property, thus making
it accessible from a display method.
* input/regression/display-lily-tests.ly:
add test for \ottava
* ly/music-functions-init.ly (ottava):
create ottava bracket via synthetic OttavaMusic
* scm/define-music-display-methods.scm:
add display method for \ottava, which simply catches OttavaMusic and reads
'ottava-number
Neil Puttock [Mon, 26 Jul 2010 00:02:52 +0000 (01:02 +0100)]
Fix #1192.
System separator positioning depends on correct calculation of the
paper-system property 'staff-refpoint-extent, but this is incorrect for
systems which include Staff-like contexts since the
Vertically_spaced_contexts_engraver fails to acknowledge axis-groups whose
origin context is aliased to Staff.
Though it's simple to enhance the axis-group acknowledger to detect aliased
contexts, a better solution is to remove the Vertically_spaced_context_engraver:
spaceability is now determined by 'staff-affinity, so the engraver's more
limited functionality can be folded into System::get_paper_system ().
* lily/system.cc (get_paper_system):
calculate 'staff-refpoint-extent via VerticalAlignment and
Page_layout_problem::is_spaceable ()
remove 'spaceable-staves
* lily/vertically-spaced-context-engraver.cc:
delete
* ly/engraver-init.ly:
remove Vertically_spaced_context_engraver and verticallySpacedContexts
- The "real music" example overrides the line-width in the call
to lilypond, but the overriden length is too small, resulting
in an unwanted line break. Note that if the line-width is not
overridden the break occurs at the end of measure 2, resulting
in a collision of the phrasing slur with the 6/4 time signature.
This example should be reconsidered as part of issue 1015.
- Use explicitly instantiated voices (thanks Neil)
First, it becomes a better example to show newcomers.
It also ensures the voice contexts remain visible so collision
avoidance works correctly, even if a break occurs at the end
of measure 3. However, if the overridden line-width is
removed the break occurs after measure 2, and causes the
phrasing slur to collide with the 6/4 time signature, even with
explicit voice declarations.
Patrick McCarty [Wed, 14 Jul 2010 02:29:13 +0000 (19:29 -0700)]
Fix #413.
The `convert-to-png' procedure did not account for the 'landscape
setting, so a portrait orientation was always used.
This commit fixes the issue, so that width and height dimensions are
swapped whenever landscape orientation is set for full-page PNG output.
Additionally, I extracted some common routines from `convert-to-pdf' and
`convert-to-png' into three separate procedures: `output-width-height',
`output-resolution', and `output-filename'.
James Lowe [Mon, 12 Jul 2010 23:13:35 +0000 (00:13 +0100)]
Doc: Additions to Repeats Section in NR
Corrected typo
Made following examples more consistent with the preceding ones.
Expanded some examples to help user work through some functions
Minor re-arranging of paragraphs and examples.
-) Remove all checks for exactly one or two notes as arguments to a
tremolo repeat
-) Create proper beaming for multi-note tremolo (so far, the
chord-tremolo-engraver always assumed exactly two beamed notes)
-) Extend the make-repeat function to scale the notes properly also
in the case of multi-note tremolos
patch from issue 1786041 on codereview.appspot.com
James Lowe [Sun, 11 Jul 2010 22:12:57 +0000 (23:12 +0100)]
Doc: 989 - tidy up last checkin
Change files names of snippets to match doctitle
Edited relevant snippet list (to remove old file names)
Edited NR itely files to reflect change of snippet name