Janek Warchol [Mon, 22 Aug 2011 21:31:28 +0000 (23:31 +0200)]
include lines in breve X-extent (issue 1814)
char box of breve glyphs is widened to include
the lines, not only notehead. This will allow
Lily to calculate collisions with breves
correctly. It shouldn't change how breves
are aligned in note columns.
Flush all ports after each file, flush stdout after displaying all options
So far, the output of the safe.ly regtest showed up randomly
in some later regtest, because stdout was buffered when redirected
to a file.
This patch flushes all ports after each processed file (only relevant
when multiple files are processed at once).
Unfortunately, it seems stdout is not an open Scheme port when
Scheme doesn't print anything to stdout. So, when displaying all
options, we have to flush stdout directly after printing all
options.
Fix 1805: Ignore AmbitusAccidental in slur/phrasing slur engraving
Slurs and Phrasing slurs don't need to listen for ambitus accidentals,
so instead of acklowledging the accidental interface, we are only
acknowleding inline-accidental.
Janek Warchoł [Sun, 13 Mar 2011 10:33:25 +0000 (11:33 +0100)]
Ends of barlines are hidden in staff lines.
Barlines are made a little shorter, so that the end of the barline doesn't touch
the outer edge of staff line - it ends in the middle of staff line now.
This prevets artifacts in pdf viewing and printing.
Wol [Fri, 29 Jul 2011 21:43:13 +0000 (22:43 +0100)]
Modify chord handling to handle guitar capos
chord-name-engraver now calls a shim between it and the chord formatter
in order to print capo chords
chord-name-scm has had capo-handler added. If requested it prints both
the original chord, and the transposed chord.
define-context-properties adds the properties capoPitch to declare the
capo transposition, and capoVertical to make the chords print in column
rather than row form.
-) Add basic_progress function
-) use it for 'Processing xxx.ly...' message
-) new ly:basic-progress
-) get rid of the success function, use basic_progress instead
Fix 1293: Use quote env in latex instead of quotation
The quotation environment is meant for larger quotations, and it adds an indent for the first line of each paragraph, which we definitely don't want to have in lilypond-book snippets...
Fix 1821: Write pathes for ly-to-tely to a separate file rather than passing as cmd line args
For out-of-source builds, the collated files list has the whole absolute path
for each and every file (>1000 for our regtests), which blows up the cmd line
length to values that don't work with the shell (<=131000 chars allowed...).
This patch takes the list in the makefile and writes the filenames in several
patches (300 at a time for now) to a .list file and then passes just this one
file to lys-to-tely, which reads in the whole long list of file names from that
file. The trick is that while make can handle long variables, we can't pass
it to ly-to-tely on the cmd line, but have to use a helper file.
Fix 1529: hashed snippet filename changes should not count as log differences
If the contents of a regtest change, the regtest gets a new hash and
thus a new filename. Unfortunately, this will be detected by
output-distance as a change and will show up in the regtest analysis.
To work around this, I'm simply extracting the old and the new filename
before we compare the log files and if they differ, I replace the old
filename with the new filename in the old log file. Thus, it will
appear as if the new filename was also used in the baseline and it
will not be flagged as a difference.
Mike Solomon [Thu, 1 Sep 2011 12:57:48 +0000 (14:57 +0200)]
Implements unpure-pure-containers in LilyPond.
These structures free functions from needing to be pre-registered as
pure in define-grobs.scm. For example, if one has a function foo
that is the unpure callback for a given property and bar that is the
pure callback, the generalized syntax for these containers is:
All of the pure/unpure distinctions that require a back and forth
between .scm and .cc files can, in theory, be eliminated by
using these containers. Furthermore, all of the functions whose
pure equivalents are hard-coded can now take different pure equivalents
(see input/regression/unpure-pure-container.ly).
Graham Percival [Thu, 1 Sep 2011 06:58:23 +0000 (07:58 +0100)]
Add regtest for \contextStringTuning.
Somebody might want to make a better test / better texidoc, but at
the moment I just want to have something in there. This function
was not previously tested.
I'm sorry, but I still cannot build git master from scratch when I
have this commit attached. Please discuss the situation on
lilypond-devel, and put an updated patch on Rietveld so that James
can test the build.
Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode
Detection code basically copied from LaTeX and adjusted (texinfo is
just an awkward latex dialect with different active characters,
so we can extract the values in exactly the same way!)
Lilypond-book: Get rid of lilyquote option, use quote instead
The only difference between the lilyquote and quote options
so far was that with lilyquote the texinfo and doctitle
was outside the example block. We didn't use quote together
with those texinfo texts, so there is really no need to
have both.
Furthermore, those texinfo options were documented as 'obscure'
options, used internally for the lilypond documentation,
so this shouldn't break external scores, either.
Fix 1816: Lilypond-book: Give images 1mm less linewidth
lilypond creates images that are wider than allowed (~0.5-1mm too wide), so
workaround this by removing 1mm from the linewidth.
Also remove code that makes the fragment snippet option imply
ragged-right. Since single-line snippets are now formatted
ragged-right anyway by default in lilypond, we don't need to set
this explicitly. And multi-line snippets are usually not desired
to be printed ragged-right.
Graham Percival [Tue, 30 Aug 2011 05:36:35 +0000 (06:36 +0100)]
Merge segfault regtests
We haven't had a release in a month. More to the point, we
haven't had a regtest comparison in a month.
http://code.google.com/p/lilypond/issues/detail?id=1821
is not going away any time soon. It involves complicated stuff in
the build system, which nobody wants to touch.
As a temporary workaround, I will now reduce the number of
regression tests. This commit merges segfault fixes.
Mike Solomon [Mon, 29 Aug 2011 14:29:16 +0000 (16:29 +0200)]
Better pure height approximations of stem tremolos.
Before this patch, stem-tremolo pure heights wer always centered at
the offset of their Y parent (often 0), which means that tremolos
were not being considered correctly in horizontal spacing. This
patch fixes that. The regression test stem-tremolo-note-column.ly
now correctly checks for this - before, it only worked because flags
were combined with stems and created a Y-extent that overshot the
flag ending. Making more accurate flag extents broke this regression
test, and this patch rectifies it.