From: mtei <2170248+mtei@users.noreply.github.com>
Date: Thu, 18 Oct 2018 16:30:48 +0000 (+0900)
Subject: optimize rgblight_effect_alternating(void)
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=db03b76910c486cd27c175ae85efeeaa183b1c98;p=qmk_firmware.git

optimize rgblight_effect_alternating(void)

rgblight_effect_alternating (void) calls rgblight_sethsv_at () RGBLED_NUM times. As a result, rgblight_set () is called RGBLED_NUM + 1 times. This is wasteful processing.
---

diff --git a/quantum/rgblight.c b/quantum/rgblight.c
index 03f77cc80..94e9c0a3b 100644
--- a/quantum/rgblight.c
+++ b/quantum/rgblight.c
@@ -860,13 +860,13 @@ void rgblight_effect_alternating(void){
   last_timer = timer_read();
 
   for(int i = 0; i<RGBLED_NUM; i++){
-		  if(i<RGBLED_NUM/2 && pos){
-			  rgblight_sethsv_at(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, i);
-		  }else if (i>=RGBLED_NUM/2 && !pos){
-			  rgblight_sethsv_at(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, i);
-		  }else{
-			  rgblight_sethsv_at(rgblight_config.hue, rgblight_config.sat, 0, i);
-		  }
+      if(i<RGBLED_NUM/2 && pos){
+          sethsv(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, (LED_TYPE *)&led[i]);
+      }else if (i>=RGBLED_NUM/2 && !pos){
+          sethsv(rgblight_config.hue, rgblight_config.sat, rgblight_config.val, (LED_TYPE *)&led[i]);
+      }else{
+          sethsv(rgblight_config.hue, rgblight_config.sat, 0, (LED_TYPE *)&led[i]);
+      }
   }
   rgblight_set();
   pos = (pos + 1) % 2;