From: Don Armstrong <don@donarmstrong.com>
Date: Sun, 6 May 2007 07:23:00 +0000 (-0700)
Subject: fix incorrect lexical variables in Debbugs
X-Git-Tag: release/2.6.0~565^2~11
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=c9783b2486e6ec5ec601b7ad404ee45a9bf0e442;p=debbugs.git

fix incorrect lexical variables in Debbugs
---

diff --git a/Debbugs/CGI.pm b/Debbugs/CGI.pm
index 8e4cdd0f..1e87bb77 100644
--- a/Debbugs/CGI.pm
+++ b/Debbugs/CGI.pm
@@ -37,7 +37,7 @@ use Mail::Address;
 use POSIX qw(ceil);
 use Storable qw(dclone);
 
-my %URL_PARAMS = ();
+our %URL_PARAMS = ();
 
 
 BEGIN{
@@ -213,10 +213,6 @@ sub quitcgi {
 }
 
 
-my %common_bugusertags;
-
-
-
 =head HTML
 
 =head2 htmlize_bugs
@@ -459,10 +455,10 @@ sub htmlize_maintlinks {
 }
 
 
-my $_maintainer;
-my $_maintainer_rev;
+our $_maintainer;
+our $_maintainer_rev;
 
-my $_pseudodesc;
+our $_pseudodesc;
 sub getpseudodesc {
     return $_pseudodesc if $_pseudodesc;
     my %pseudodesc;
diff --git a/Debbugs/Common.pm b/Debbugs/Common.pm
index 7a06f88f..453720fc 100644
--- a/Debbugs/Common.pm
+++ b/Debbugs/Common.pm
@@ -190,7 +190,7 @@ first address parsed.
 =cut
 
 
-my %_parsedaddrs;
+our %_parsedaddrs;
 sub getparsedaddrs {
     my $addr = shift;
     return () unless defined $addr;
@@ -200,8 +200,8 @@ sub getparsedaddrs {
     return wantarray?@{$_parsedaddrs{$addr}}:$_parsedaddrs{$addr}[0];
 }
 
-my $_maintainer;
-my $_maintainer_rev;
+our $_maintainer;
+our $_maintainer_rev;
 sub getmaintainers {
     return $_maintainer if $_maintainer;
     my %maintainer;
@@ -244,7 +244,7 @@ FLOCKs the passed file. Use unfilelock to unlock it.
 
 =cut
 
-my @filelocks;
+our @filelocks;
 our @cleanups;
 
 sub filelock {
diff --git a/Debbugs/Packages.pm b/Debbugs/Packages.pm
index 664f8225..a5c2cacb 100644
--- a/Debbugs/Packages.pm
+++ b/Debbugs/Packages.pm
@@ -52,9 +52,9 @@ source package names.
 
 =cut
 
-my $_pkgsrc;
-my $_pkgcomponent;
-my $_srcpkg;
+our $_pkgsrc;
+our $_pkgcomponent;
+our $_srcpkg;
 sub getpkgsrc {
     return $_pkgsrc if $_pkgsrc;
     return {} unless defined $Debbugs::Packages::gPackageSource;
@@ -116,7 +116,7 @@ with any duplicates removed.
 
 =cut
 
-my %_binarytosource;
+our %_binarytosource;
 sub binarytosource {
     my ($binname, $binver, $binarch) = @_;
 
@@ -173,7 +173,7 @@ returned, without the architecture.
 
 =cut
 
-my %_sourcetobinary;
+our %_sourcetobinary;
 sub sourcetobinary {
     my ($srcname, $srcver) = @_;
 
@@ -204,7 +204,7 @@ architecture
 
 =cut
 
-my %_versions;
+our %_versions;
 sub getversions {
     my ($pkg, $dist, $arch) = @_;
     return () unless defined $gVersionIndex;
@@ -251,7 +251,7 @@ version numbers differ from binary version numbers.
 
 =cut
 
-my %_sourceversioncache = ();
+our %_sourceversioncache = ();
 sub makesourceversions {
     my $pkg = shift;
     my $arch = shift;
diff --git a/Debbugs/Status.pm b/Debbugs/Status.pm
index 22d81834..0cc0af9a 100644
--- a/Debbugs/Status.pm
+++ b/Debbugs/Status.pm
@@ -546,7 +546,7 @@ Returns undef on failure.
 =cut
 
 # This will eventually need to be fixed before we start using mod_perl
-my $version_cache = {};
+our $version_cache = {};
 sub bug_archiveable{
      my %param = validate_with(params => \@_,
 			       spec   => {bug => {type => SCALAR,