From: David Kastrup <dak@gnu.org>
Date: Sun, 10 May 2015 12:17:48 +0000 (+0200)
Subject: Issue 4384: Remove convert-ly rule \shiftOff -> \undo\shiftOn
X-Git-Tag: release/2.19.21-1~28
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=c1793a8d3c9943293ebcd5725dcbfa26bb2d99ad;p=lilypond.git

Issue 4384: Remove convert-ly rule \shiftOff -> \undo\shiftOn

For the rationale, see
<URL:https://codereview.appspot.com/190500043/#msg1>

The presence of the rule will cause similarly surprising effects to
users as it would to the current state of documentation translations.

Even if it were properly mentioned in the diagnostic description of
the conversion rule, people would rarely look closely enough to
notice.
---

diff --git a/python/convertrules.py b/python/convertrules.py
index 05beeec455..8dc8e9160a 100644
--- a/python/convertrules.py
+++ b/python/convertrules.py
@@ -3741,7 +3741,6 @@ def conv(str):
     str = re.sub (r'\bimplicitTimeSignatureVisibility\b', 'initialTimeSignatureVisibility', str)
     str = re.sub ('(' + before_id + r'[a-g])((?:sharp){1,2}|(?:flat){1,2})'
                   + after_id, r'\1-\2', str)
-    str = re.sub (r'\\shiftOff\b', r'\\undo\\shiftOn', str)
     return str
 
 # Guidelines to write rules (please keep this at the end of this file)