From: Carl Sorensen <c_sorensen@byu.edu>
Date: Sat, 1 Nov 2008 14:11:57 +0000 (-0600)
Subject: Fix poor automatic fretboard calculation
X-Git-Tag: release/2.11.64-1~102
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=be352a75321ec4b71df2fe491a5c97dc99ed381c;p=lilypond.git

Fix poor automatic fretboard calculation

Improve the automatic fretboard calculation algorithm by changing
the sort order of the notes.

This improvement broke the example on improving automatic fretboards
by specifying a string.  I could not find another example, so I
removed the existing example.  I wanted to leave the text in case
somebody had the problem in the future.

This improvement also fixed the poor diagram for c:9 in the
predefined fretboards section of fretted-strings.itely
---

diff --git a/Documentation/user/fretted-strings.itely b/Documentation/user/fretted-strings.itely
index 77c5006191..9802858c50 100644
--- a/Documentation/user/fretted-strings.itely
+++ b/Documentation/user/fretted-strings.itely
@@ -1036,25 +1036,6 @@ note need be manually placed on a string; the rest of
 the notes will then be placed appropriately by the @code{FretBoards}
 context.
 
-@lilypond[quote,ragged-right,verbatim]
-<<
-  \context ChordNames {
-     \chordmode { 
-       c1 c 
-     }
-  }
-  \context FretBoards {
-    < c g c' e' g'> 1
-    < c g\4 c' e' g'> 1
-  }
-  \context Staff {
-    \clef "treble_8"
-    < c g c' e' g'> 1
-    < c g c' e' g'> 1
-  }  
->>
-@end lilypond
-
 @cindex fret diagrams, adding fingerings
 @cindex fingerings, adding to fret diagrams
 
diff --git a/scm/translation-functions.scm b/scm/translation-functions.scm
index 3767a18be2..901bff0944 100644
--- a/scm/translation-functions.scm
+++ b/scm/translation-functions.scm
@@ -236,9 +236,9 @@
   (define (note-pitch a)
     (ly:event-property a 'pitch))
 
-  (define (note-pitch<? a b)
-    (ly:pitch<? (note-pitch a)
-		(note-pitch b)))
+  (define (note-pitch>? a b)
+    (ly:pitch<? (note-pitch b)
+		(note-pitch a)))
 
   (define (note-finger ev)
     (let* ((articulations (ly:event-property ev 'articulations))
@@ -339,6 +339,6 @@
 			   specified-frets))
 			   
 	       )))
-   (sort notes note-pitch<?))
+   (sort notes note-pitch>?))
 
   string-fret-fingering-tuples)