From: Steve Hancock <perltidy@users.sourceforge.net>
Date: Thu, 5 Mar 2020 15:05:46 +0000 (-0800)
Subject: Fix RT#132059, -dac was not working
X-Git-Tag: 20200619~135
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=aede2057f417f1c634da114ec803724f91427548;p=perltidy.git

Fix RT#132059, -dac was not working
---

diff --git a/BUGS.md b/BUGS.md
index 1ec2b487..a64b8ae1 100644
--- a/BUGS.md
+++ b/BUGS.md
@@ -38,6 +38,21 @@ perltidy is untangling complex ternary statements. Use the iteration parameter
 **-it=2** if it is important that the results be unchanged on subsequent passes,
 but note that this doubles the run time.
 
+## Perltidy does not look for here-document targets inside of quoted strings
+
+For example, consider the following script
+
+```
+print "${ \<<END1 }${ \<<END2 }";
+Hello 
+END1
+World 
+END2
+```
+
+Perltidy will not look for the here-doc targets within the quotes, so it
+will not format the script correctly.
+
 ## Latest Bug and Wishlist at CPAN:
 
 For the latest list of bugs and feature requests at CPAN see:
diff --git a/MANIFEST b/MANIFEST
index e2d52ae6..cc8c9c51 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -1,3 +1,4 @@
+.pre-commit-hooks.yaml
 bin/perltidy
 BUGS.md
 CHANGES.md
@@ -61,6 +62,7 @@ t/snippets13.t
 t/snippets14.t
 t/snippets15.t
 t/snippets16.t
+t/snippets17.t
 t/snippets2.t
 t/snippets3.t
 t/snippets4.t
diff --git a/dev-bin/build.pl b/dev-bin/build.pl
index 842e3b74..483ca8d0 100755
--- a/dev-bin/build.pl
+++ b/dev-bin/build.pl
@@ -573,6 +573,10 @@ git add -A  [or whatever]
 git commit
 git tag -a $new_VERSION;
 
+You should also push any new tags:
+
+git push origin --tags
+
 To avoid error, I put this last command in a script $runme 
 EOM
         hitcr();
@@ -586,6 +590,7 @@ sub make_tag_script {
         print RUN <<EOM;
 #!/bin/sh
 git tag -a $new_VERSION
+git push origin --tags
 unlink \$0;
 EOM
     }
diff --git a/lib/Perl/Tidy/Formatter.pm b/lib/Perl/Tidy/Formatter.pm
index faa0f5e7..38e94a04 100644
--- a/lib/Perl/Tidy/Formatter.pm
+++ b/lib/Perl/Tidy/Formatter.pm
@@ -7752,8 +7752,11 @@ EOM
         # we have to flush ..
         if (
 
-            # if there is a side comment
-            ( ( $type eq '#' ) && !$rOpts->{'delete-side-comments'} )
+	    # if there is a side comment...
+            # Even if we deleted it! Otherwise,
+	    # i-K indexing will have a gap and be incorrect ( see RT #132059)
+            ## ( ( $type eq '#' ) && !$rOpts->{'delete-side-comments'} )
+            $type eq '#'
 
             # if this line ends in a quote
             # NOTE: This is critically important for insuring that quoted lines
diff --git a/local-docs/Release-Checklist.md b/local-docs/Release-Checklist.md
index 8aadf475..8915e2e8 100644
--- a/local-docs/Release-Checklist.md
+++ b/local-docs/Release-Checklist.md
@@ -40,3 +40,10 @@
 - Update CPAN tickets
 - Upload release to sourceforge
 - Update web sites
+- Be sure to run the RUNME.sh file to tag this version and also push the tags to github. Check that the tags are uploaded at:
+
+   https://github.com/perltidy/perltidy/tags
+
+- If you forget, or need to modify tags, see the directions in the book:
+
+   https://git-scm.com/book/en/v2/Git-Basics-Tagging
diff --git a/t/snippets/packing_list.txt b/t/snippets/packing_list.txt
index a959c9d4..4ac53628 100644
--- a/t/snippets/packing_list.txt
+++ b/t/snippets/packing_list.txt
@@ -154,6 +154,7 @@
 ../snippets16.t	rt131288.def
 ../snippets16.t	rt130394.rt130394
 ../snippets16.t	git18.def
+../snippets16.t	here2.def
 ../snippets2.t	angle.def
 ../snippets2.t	arrows1.def
 ../snippets2.t	arrows2.def
@@ -314,4 +315,5 @@
 ../snippets9.t	rt98902.def
 ../snippets9.t	rt98902.rt98902
 ../snippets9.t	rt99961.def
-../snippets16.t	here2.def
+../snippets17.t	rt132059.def
+../snippets17.t	rt132059.rt132059