From: Steve Hancock Date: Sun, 24 Jul 2022 20:21:32 +0000 (-0700) Subject: update comments X-Git-Tag: 20220613.03~5 X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=8fe8d78eedb7a350ecde6afa266c840a9085ba3c;p=perltidy.git update comments --- diff --git a/lib/Perl/Tidy/Formatter.pm b/lib/Perl/Tidy/Formatter.pm index e421f137..d70c7e92 100644 --- a/lib/Perl/Tidy/Formatter.pm +++ b/lib/Perl/Tidy/Formatter.pm @@ -2910,8 +2910,6 @@ sub set_whitespace_flags { # space between something like $i and ( in 'snippets/space2.in' # for $i ( 0 .. 20 ) { - # FIXME: eventually, type 'i' could be split into multiple - # token types so this can be a hardwired rule. elsif ( $last_type eq 'i' && $last_token =~ /^[\$\%\@]/ ) { $ws = WS_YES; } diff --git a/lib/Perl/Tidy/HtmlWriter.pm b/lib/Perl/Tidy/HtmlWriter.pm index 03ea24a3..11369e3c 100644 --- a/lib/Perl/Tidy/HtmlWriter.pm +++ b/lib/Perl/Tidy/HtmlWriter.pm @@ -385,7 +385,6 @@ BEGIN { ); # These token types will all be called identifiers for now - # FIXME: could separate user defined modules as separate type my @identifier = qw< i t U C Y Z G :: CORE::>; @token_short_names{@identifier} = ('i') x scalar(@identifier); diff --git a/lib/Perl/Tidy/Tokenizer.pm b/lib/Perl/Tidy/Tokenizer.pm index eddc1809..ecca17b3 100644 --- a/lib/Perl/Tidy/Tokenizer.pm +++ b/lib/Perl/Tidy/Tokenizer.pm @@ -2061,15 +2061,14 @@ EOM #------------------------------------------------------- # Do full scan for anything following a pointer, such as # $cref->&*; # a postderef - # This is part of POINTER_LOGIC update but always ok #------------------------------------------------------- if ( $last_nonblank_token eq '->' ) { } - ############################### + #------------------------------ # quick scan with leading sigil - ############################### + #------------------------------ elsif ( !$id_scan_state && $i_plus_1 <= $max_token_index && $fast_scan_context{$tok} ) @@ -2115,10 +2114,10 @@ EOM } } - ############################ + #--------------------------- # Quick scan with leading -> # Look for ->[ and ->{ - ############################ + #--------------------------- elsif ( $tok eq '->' && $i < $max_token_index @@ -2132,9 +2131,9 @@ EOM $context = UNKNOWN_CONTEXT; } - ####################################### + #-------------------------------------- # Verify correctness during development - ####################################### + #-------------------------------------- if ( VERIFY_FASTSCAN && $fast_scan_type ) { # We will call the full method @@ -2162,9 +2161,9 @@ EOM } } - ################################################### + #------------------------------------------------- # call full scanner if fast method did not succeed - ################################################### + #------------------------------------------------- if ( !$fast_scan_type ) { scan_identifier(); } @@ -5734,9 +5733,7 @@ sub operator_expected { my ( $prev_type, $tok, $next_type ) = @{$rarg}; # Types 'k', '}' and 'Z' depend on context - # FIXME: Types 'i', 'n', 'v', 'q' currently also temporarily depend on - # context but that dependence could eventually be eliminated with better - # token type definition + # Types 'i', 'n', 'v', 'q' currently also temporarily depend on context. # identifier... if ( $last_nonblank_type eq 'i' ) { @@ -5876,9 +5873,7 @@ sub operator_expected { # 'J'; not 'q'; or maybe mark as type 'Y' elsif ( $last_nonblank_type eq 'q' ) { $op_expected = OPERATOR; - if ( $last_nonblank_token eq 'prototype' ) - ##|| $last_nonblank_token eq 'switch' ) - { + if ( $last_nonblank_token eq 'prototype' ) { $op_expected = TERM; } }