From: Han-Wen Nienhuys Date: Tue, 30 Jul 2002 00:07:24 +0000 (+0000) Subject: clean input/bugs/ X-Git-Tag: release/1.5.72~83 X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=8cec62a4c42d7971da4b49c14735629d7298fa1c;p=lilypond.git clean input/bugs/ --- diff --git a/Documentation/user/refman.itely b/Documentation/user/refman.itely index c83c680dbc..cd1aeedaf4 100644 --- a/Documentation/user/refman.itely +++ b/Documentation/user/refman.itely @@ -344,6 +344,8 @@ of a chord is not supported in a simple way. It can be achieved by moving the tie-engraver into the Thread context and turning on and off ties per Thread. +Switching staffs when a tie is active will not work. + @node Automatic note splitting @subsection Automatic note splitting @c FIXME: This subsection doesn't belong in @ref{Note entry}. @@ -1154,6 +1156,14 @@ the grob property @code{auto-knee-gap}. Auto knee beams can not be used together with hara kiri staffs. +[TODO from bugs] + +The Automatic beamer does not put @strong{unfinished} beams on the +last notes of a score. + +Formatting of ties is a difficult subject. LilyPond often does not +give optimal results. + @menu * Setting automatic beam behavior :: @end menu @@ -4104,6 +4114,11 @@ marking: The syntax and semantics of markup texts are not clean, and both syntax and semantics are slated for a rewrite. +LilyPond does not do kerning, and there generally spaces texts +slightly too wide. + + + @node Global layout @section Global layout diff --git a/input/bugs/auto-beam.ly b/input/bugs/auto-beam.ly deleted file mode 100644 index 8aa77c3e0b..0000000000 --- a/input/bugs/auto-beam.ly +++ /dev/null @@ -1,19 +0,0 @@ -\version "1.5.68" - -\header { - -texidoc="The Automatic beamer does not put @strong{unfinished} beams -on the last notes of a score." -} - -\score { - < - \context Staff=a\notes\relative c'' { - a8 a8 a2. a8 a8 - } - \notes\relative c'' { - a8 a a a a2 - a8 a a a - } - > -} diff --git a/input/bugs/broken-tuplet.ly b/input/bugs/broken-tuplet.ly deleted file mode 100644 index e4de8988a4..0000000000 --- a/input/bugs/broken-tuplet.ly +++ /dev/null @@ -1,18 +0,0 @@ -\version "1.5.68" - -\header { - -texidoc = "tuplet bracket doesn't behave properly at line break. Not a real problem." -} - -\score{ - \notes\relative c''< - { % broken cresc dumps core - c2 c4*2/3 \times 2/3 { c( c c } - c4 c c c - } > - \paper{ - indent = 0. - linewidth=30.\mm - } -} diff --git a/input/bugs/cross-staff-tie.ly b/input/bugs/cross-staff-tie.ly deleted file mode 100644 index 1ce21c8e8b..0000000000 --- a/input/bugs/cross-staff-tie.ly +++ /dev/null @@ -1,21 +0,0 @@ -\header { - - texidoc = "Tie code is not prepared for staff changes." -} - - -\version "1.5.68" -\score { \notes - \context PianoStaff < - \context Staff = up { \clef G - c'2 ~ \translator Staff=down c' - } - \context Staff = down { \clef F - s1 - } - > - \paper { } -} - - - diff --git a/input/bugs/mmrest-collide.ly b/input/bugs/mmrest-collide.ly deleted file mode 100644 index e65342f2f5..0000000000 --- a/input/bugs/mmrest-collide.ly +++ /dev/null @@ -1,18 +0,0 @@ -\version "1.5.68" -\header { -texidoc="multi-measure-rests (bar 2) should `collide' (ie, not clash) - with notes, just as normal rests (bar 1)." -} - -\score { - \notes\context Staff < - \context Voice=one \relative c''{ - d d d d - d d d d - } - \context Voice=two { - r1 - R - } - > -} \ No newline at end of file diff --git a/input/bugs/sammartini.ly b/input/bugs/sammartini.ly deleted file mode 100644 index e77ad1fe17..0000000000 --- a/input/bugs/sammartini.ly +++ /dev/null @@ -1,65 +0,0 @@ - -% -% bug: 1st tuplet spacing weird. - -\include "paper16.ly" - -stemDown = \property Voice.Stem \override #'direction = #-1 -stemUp = \property Voice.Stem \override #'direction = #1 -stemBoth = \property Voice.Stem \revert #'direction - -viola = \notes \relative c' \context Voice = viola { - - \stemDown g'8. b,16 - s1 s2. r4 - g -} - -oboes = \notes \relative c'' \context Voice = oboe { - \stemUp s4 g8. b,16 c8 r - \grace - \times 2/3 { } - < - { \times 2/3 { a8 g c } \! c2 } - \context Voice = oboeTwo { - \stemDown - \grace { - \stemDown - [f,16 g] } - f8 e e2 - } - > - \stemBoth - \grace <)b8. d8.-\trill> | - [ < )f8. a>] <)b,8 d> r [ ] r | - [ < )e8. g>] -} - -hoomPah = \repeat unfold 8 \notes - \transpose c' { c8 \stemDown c'8 \stemUp } - -bassvoices = \notes \relative c' { - c4 g8. b,16 - \autochange Staff \hoomPah - \translator Staff = down - \stemDown [c8 c'8] r4 - r4 - < {\stemUp r2 } - \context Voice = reallyLow {\stemDown g2 ~ | g4 c8 } > -} - -\score { - \context PianoStaff \notes < - \context Staff = up < \time 2/2 - \viola - \oboes - > - \context Staff = down < \time 2/2 \clef bass - \bassvoices - > - > - \midi { } - \paper { - indent = 0.0 - linewidth = 15.0 \cm } -} diff --git a/input/bugs/text-kerning.ly b/input/bugs/text-kerning.ly deleted file mode 100644 index 1b7d8578dd..0000000000 --- a/input/bugs/text-kerning.ly +++ /dev/null @@ -1,16 +0,0 @@ -\version "1.5.68" - - -\header { -texidoc = "LilyPond doesn't kern text, but TeX does, leading to skewed results: the VAVAVAVA takes less space than LilyPond thinks it does." } - -\score { - \notes \relative c'' < \context Voice { -% c16 c16 c16 c16 c4 - c4 c4 c4 - } -\context Lyrics \lyrics { foobar4 -- VAVAVAVAV4 -- foobar4 } > - - - \paper { linewidth = -10.0\cm } -} diff --git a/lily/include/my-lily-parser.hh b/lily/include/my-lily-parser.hh index 8d514f7b7d..c30fca5742 100644 --- a/lily/include/my-lily-parser.hh +++ b/lily/include/my-lily-parser.hh @@ -35,7 +35,6 @@ public: void do_init_file (); void parse_file ( String init_string, String file_string); - void set_version_check (bool ignore); public: Duration default_duration_; diff --git a/lily/lexer.ll b/lily/lexer.ll index cbaea6e861..ebeba72848 100644 --- a/lily/lexer.ll +++ b/lily/lexer.ll @@ -654,8 +654,8 @@ valid_version_b (String s) Lilypond_version ver (s); if (! ((ver >= oldest_version) && (ver <= current))) { - non_fatal_error (_f ("incorrect lilypond version: %s (%s, %s)", ver.string (), oldest_version.string (), current.string ())); - non_fatal_error (_ ("Consider converting the input with the convert-ly script")); + non_fatal_error (_f ("Incorrect lilypond version: %s (%s, %s)", ver.string (), oldest_version.string (), current.string ())); + non_fatal_error (_ ("Consider updating the input with the convert-ly script")); return false; } return true; diff --git a/lily/my-lily-parser.cc b/lily/my-lily-parser.cc index 4dbf2cca64..f79fee6660 100644 --- a/lily/my-lily-parser.cc +++ b/lily/my-lily-parser.cc @@ -33,10 +33,6 @@ My_lily_parser::~My_lily_parser () scm_gc_unprotect_object (default_header_->self_scm()); } -void -My_lily_parser::set_version_check (bool) -{ -} void My_lily_parser::parse_file (String init, String s) diff --git a/lily/parse-scm.cc b/lily/parse-scm.cc index 66f46482e5..8badd2cb01 100644 --- a/lily/parse-scm.cc +++ b/lily/parse-scm.cc @@ -84,7 +84,7 @@ parse_handler (void * data, SCM tag, SCM args) /* The following is a kludge; we should probably search for - [a-z][0-9] a note, and start before that. + [a-z][0-9] (a note), and start before that. */ ps->nchars = 1; diff --git a/lily/scores.cc b/lily/scores.cc index edb7704f18..4680cd2a0b 100644 --- a/lily/scores.cc +++ b/lily/scores.cc @@ -149,7 +149,7 @@ do_one_file (String init_string, String file_string) source_global->set_path (&global_path); { My_lily_parser parser (source_global); - parser.set_version_check (false); + progress_indication (_f ("Now processing: `%s'", file_string.to_str0 ())); progress_indication ("\n"); parser.parse_file (init_string, file_string);