From: Don Armstrong <don@donarmstrong.com>
Date: Mon, 11 Aug 2008 19:47:38 +0000 (-0700)
Subject: fix corner case where Debbugs::Versions would return positive or negative numbers
X-Git-Tag: release/2.6.0~474^2~8
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=7ce10a12e339696c9add05ab28e4f6f577482568;p=debbugs.git

fix corner case where Debbugs::Versions would return positive or negative numbers
---

diff --git a/Debbugs/Versions/Dpkg.pm b/Debbugs/Versions/Dpkg.pm
index 9745cbb4..af955f28 100644
--- a/Debbugs/Versions/Dpkg.pm
+++ b/Debbugs/Versions/Dpkg.pm
@@ -124,7 +124,8 @@ sub verrevcmp($$)
 	  }
 	  return 1 if defined $vc and $vc =~ /^\d$/;
 	  return -1 if defined $rc and $rc =~ /^\d$/;
-	  return $first_diff if $first_diff;
+	  return (($first_diff  > 0) ? 1 : -1) if $first_diff;
+	  # return $first_diff if $first_diff;
      }
      return 0;
 }
diff --git a/t/02_version_dpkg.t b/t/02_version_dpkg.t
index 9e8e0b03..e6134557 100644
--- a/t/02_version_dpkg.t
+++ b/t/02_version_dpkg.t
@@ -29,6 +29,17 @@ my @versions = ({a      => '1.0-1',
 		 result => 0,
 		 relation => 'eq',
 		},
+		# q(1.1-20080727-1),q(1.1-20080316-1)
+		{a      => '1.1-20080727-1',
+		 b      => '1.1-20080316-1',
+		 result => 1,
+		 relation => 'gt',
+		},
+		{a      => '1.1-20080316-1',
+		 b      => '1.1-20080727-1',
+		 result => -1,
+		 relation => 'lt',
+		},
 	       );
 
 plan tests => @versions * 2 + 1;