From: Don Armstrong Date: Wed, 17 Sep 2008 16:09:25 +0000 (-0700) Subject: * Fix and/or issue in lock_read_all_merged_bugs X-Git-Tag: release/2.6.0~472^2~6 X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=60562be56efd09c099ad7570580282e03a288d91;p=debbugs.git * Fix and/or issue in lock_read_all_merged_bugs * Fix tiny formatting issue --- diff --git a/Debbugs/Status.pm b/Debbugs/Status.pm index 0a4985f..aefeb9c 100644 --- a/Debbugs/Status.pm +++ b/Debbugs/Status.pm @@ -323,7 +323,7 @@ sub lock_read_all_merged_bugs { my ($bug_num,$location) = @_; my $locks = 0; my @data = (lockreadbug(@_)); - if (not @data and not defined $data[0]) { + if (not @data or not defined $data[0]) { return ($locks,undef); } $locks++; @@ -335,7 +335,7 @@ sub lock_read_all_merged_bugs { filelock("$config{spool_dir}/lock/merge"); $locks++; @data = (lockreadbug(@_)); - if (not @data and not defined $data[0]) { + if (not @data or not defined $data[0]) { unfilelock(); #for merge lock above $locks--; return ($locks,undef); @@ -1095,12 +1095,12 @@ sub bug_presence { my $maxbuggy = 'undef'; if (@sourceversions) { $maxbuggy = max_buggy(bug => $param{bug}, - sourceversions => \@sourceversions, - found => $status{found_versions}, - fixed => $status{fixed_versions}, - package => $status{package}, - version_cache => $version_cache, - ); + sourceversions => \@sourceversions, + found => $status{found_versions}, + fixed => $status{fixed_versions}, + package => $status{package}, + version_cache => $version_cache, + ); } elsif (defined $param{dist} and not exists $pseudo_desc->{$status{package}}) {