From: Stephen Gran <steve@lobefin.net>
Date: Mon, 9 Mar 2009 19:34:48 +0000 (+0000)
Subject: Try to use booleans instead of strings - this can't possibly go wrong
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=49f8b52b7524a67a3af1848099d2e030b6eb623a;p=dsa-puppet.git

Try to use booleans instead of strings - this can't possibly go wrong
Signed-off-by: Stephen Gran <steve@lobefin.net>
---

diff --git a/facts/raidcontroller.rb b/facts/raidcontroller.rb
index 263b16b2..12d140fd 100644
--- a/facts/raidcontroller.rb
+++ b/facts/raidcontroller.rb
@@ -9,7 +9,7 @@ Facter.add("smartarraycontroller") do
 				ishp = "true" if s =~ /RAID bus controller: (.*) Smart Array/
 			}
 		end
-		ishp
+		ishp == "true"
 	end
 end
 
@@ -29,7 +29,7 @@ Facter.add("3warecontroller") do
 				is3w = "true" if x =~ /Vendor: 3ware/
 			}
 		end
-		is3w
+		is3w == "true"
 	end
 end
 
@@ -42,7 +42,7 @@ Facter.add("swraid") do
                                 swraid = "true" if x =~ /md[0-9]+ : active/
                         }
                 end
-                swraid
+                swraid == "true"
 	end
 end
 
diff --git a/manifests/site.pp b/manifests/site.pp
index 4758621b..6b5f001e 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -7,9 +7,8 @@ node default {
     include samhain
     include debian-org
 
-    case $smartarraycontroller {
-        "true":    { include debian-proliant }
-        default: {}
+    if $smartarraycontroller {
+        include debian-proliant
     }
     case $mta {
         "exim4":   { include exim }