From: XScorpion2 <rcalt2vt@gmail.com> Date: Sun, 22 Sep 2019 14:52:33 +0000 (-0500) Subject: Fixing wrapping math logic for timer_expired functions (#6746) X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;h=2f49cae9bcbdd94431659727ef75cfd30f557da8;p=qmk_firmware.git Fixing wrapping math logic for timer_expired functions (#6746) --- diff --git a/tmk_core/common/timer.h b/tmk_core/common/timer.h index 853cb9839..378cf7892 100644 --- a/tmk_core/common/timer.h +++ b/tmk_core/common/timer.h @@ -45,9 +45,9 @@ uint16_t timer_elapsed(uint16_t last); uint32_t timer_elapsed32(uint32_t last); // Utility functions to check if a future time has expired & autmatically handle time wrapping if checked / reset frequently (half of max value) -inline bool timer_expired(uint16_t current, uint16_t last) { return current - last < 0x8000; } +inline bool timer_expired(uint16_t current, uint16_t future) { return (uint16_t)(current - future) < 0x8000; } -inline bool timer_expired32(uint32_t current, uint32_t future) { return current - future < 0x80000000; } +inline bool timer_expired32(uint32_t current, uint32_t future) { return (uint32_t)(current - future) < 0x80000000; } #ifdef __cplusplus }