From: Graham Percival <graham@percival-music.ca>
Date: Thu, 8 Dec 2011 11:07:50 +0000 (-0800)
Subject: Remove default comparison for binary search
X-Git-Tag: release/2.15.22-1~10
X-Git-Url: https://git.donarmstrong.com/?a=commitdiff_plain;ds=sidebyside;h=b062d7bfeaa7baab1e2543417d41898ca5281c79;p=lilypond.git

Remove default comparison for binary search

clang++ complains about this, and we never rely on the default
comparison in our code.

/home/gperciva/src/lilypond/flower/include/std-vector.hh:197:36:
error: 'T' does
      not refer to a value
               Compare less = less<T> (),
                                   ^
/home/gperciva/src/lilypond/flower/include/std-vector.hh:193:19:
note: declared
      here
template<typename T, typename Compare>
                  ^
/home/gperciva/src/lilypond/flower/include/std-vector.hh:197:40:
error:
      expected expression
               Compare less = less<T> (),
---

diff --git a/flower/include/std-vector.hh b/flower/include/std-vector.hh
index 48b34f12ed..020403aea1 100644
--- a/flower/include/std-vector.hh
+++ b/flower/include/std-vector.hh
@@ -194,7 +194,7 @@ template<typename T, typename Compare>
 vsize
 binary_search (vector<T> const &v,
                T const &key,
-               Compare less = less<T> (),
+               Compare less,
                vsize b = 0, vsize e = VPOS)
 {
   vsize lb = lower_bound (v, key, less, b, e);