Try this

diff --git a/modules/unbound/manifests/init.pp b/modules/unbound/manifests/init.pp
index 06395fc9c20c433078496318b4f1dedb1720a414..aa63a5d6c566ea746361fa3b2d269603e399e02e 100644 (file)
--- a/modules/unbound/manifests/init.pp
+++ b/modules/unbound/manifests/init.pp
@@ -10,6 +10,7 @@ class unbound {
 
        $is_recursor   = getfromhash($site::nodeinfo, 'misc', 'resolver-recursive')
        $client_ranges = hiera('allow_dns_query')
+       $empty_client_range = empty($client_ranges)
        $ns            = hiera('nameservers')
 
        package { 'unbound':
@@ -55,7 +56,7 @@ class unbound {
                notify  => Service['unbound']
        }
 
-       if ($is_recursor and not empty($client_ranges)) {
+       if ($is_recursor and not $empty_client_range) { 
                @ferm::rule { 'dsa-dns':
                        domain      => 'ip',
                        description => 'Allow nameserver access',