[Keyboard][S65-X] BACKLIGHT_CAPS_LOCK (#4770)

Replace buggy Caps Lock indicator implementation with new
BACKLIGHT_CAPS_LOCK_INDICATOR feature.

diff --git a/keyboards/s65_x/config.h b/keyboards/s65_x/config.h
index 66bbd6a35920a65a8b61e38f9f6c42e9c5bebaf3..4867652730572bd93803574b43c0c3a514990142 100644 (file)
--- a/keyboards/s65_x/config.h
+++ b/keyboards/s65_x/config.h
@@ -4,7 +4,7 @@
 #include "config_common.h"
 
 /* USB Device descriptor parameter */
-#define PRODUCT         S65-X-RGB
+#define PRODUCT         S65-X RGB
 #define DESCRIPTION     QMK keyboard firmware for S65-X RGB
 #define VENDOR_ID       0xFEED
 #define PRODUCT_ID      0x6060
@@ -22,7 +22,8 @@
 
 /* number of backlight levels */
 #define BACKLIGHT_PIN B7
-#define BACKLIGHT_LEVELS 3
+#define BACKLIGHT_LEVELS 5
+#define BACKLIGHT_CAPS_LOCK
 
 #define RGB_DI_PIN D3
 #define RGBLIGHT_ANIMATIONS
@@ -31,6 +32,7 @@
 #define RGBLIGHT_SAT_STEP 8
 #define RGBLIGHT_VAL_STEP 8
 #define RGBLIGHT_EFFECT_KNIGHT_OFFSET 20
+#define RGBLIGHT_SLEEP
 
 /* COL2ROW or ROW2COL */
 #define DIODE_DIRECTION COL2ROW

diff --git a/keyboards/s65_x/s65_x.c b/keyboards/s65_x/s65_x.c
index 29073750c1672718fd07064093df76d4b47cc05f..844f5cf28bb83500532a5f08df5c92ff64d75639 100644 (file)
--- a/keyboards/s65_x/s65_x.c
+++ b/keyboards/s65_x/s65_x.c
@@ -1,5 +1,4 @@
 #include "s65_x.h"
-#include "led.h"
 
 void matrix_init_kb(void) {
   // put your keyboard start-up code here
@@ -14,11 +13,6 @@ void matrix_scan_kb(void) {
 };
 
 void led_set_kb(uint8_t usb_led) {
-  if (usb_led & (1<<USB_LED_CAPS_LOCK)) {
-    // Turn capslock on
-    PORTB &= ~(1<<7);
-  } else {
-    // Turn capslock off
-    PORTB |= (1<<7);
-  }
+  // put your keyboard LED indicator (ex: Caps Lock LED) toggling code here
+  led_set_user(usb_led);
 }