updates for perlcritic

diff --git a/.perlcriticrc b/.perlcriticrc
index f72c88a077d18e509c103927af2570981086c339..8fc71ccb7c84b4a31e92e6ff7fe57c1d82405317 100644 (file)
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -8,6 +8,7 @@
 
 # Some useful links:
 # https://metacpan.org/dist/Perl-Critic/view/lib/Perl/Critic/PolicySummary.pod
+# https://metacpan.org/pod/Perl::Critic::PolicySummary
 # https://manpages.ubuntu.com/manpages/xenial/man1/perlcritic.1p.html
 # https://perlmaven.com/perl-critic
 
@@ -59,6 +60,11 @@ short_subroutine_statements = 2
 [InputOutput::RequireBriefOpen]
 lines=30
 
+# Perltidy modules IOScalar.pm and IOScalarArray.pm provide a print function,
+# but I had to turn this off because the 'allow' option does not seem to work
+[-Subroutines::ProhibitBuiltinHomonyms]
+# allow=print
+
 #---------------------------------------------------
 # Policies to be skipped or adjusted for severity=3:
 #---------------------------------------------------

diff --git a/lib/Perl/Tidy/Formatter.pm b/lib/Perl/Tidy/Formatter.pm
index b72a5917be7be9068cd697af86ccb7296012fb29..8adda126f2f4030a2014e072968f02ba7c37cb1d 100644 (file)
--- a/lib/Perl/Tidy/Formatter.pm
+++ b/lib/Perl/Tidy/Formatter.pm
@@ -14668,6 +14668,7 @@ sub update_sub_call_paren_info {
         # must be called once per file before first call to sub try_3
         %try_3_cache      = ();
         %is_oo_call_cache = ();
+        return;
     } ## end sub initialize_try_3_cache
 
     sub try_3 {

diff --git a/lib/Perl/Tidy/IOScalar.pm b/lib/Perl/Tidy/IOScalar.pm
index 841a49460af149566050ea96b7e928cb8b4081db..628076fbd2603142c3308bdac5a51c2db8fb4dd7 100644 (file)
--- a/lib/Perl/Tidy/IOScalar.pm
+++ b/lib/Perl/Tidy/IOScalar.pm
@@ -94,8 +94,7 @@ EOM
     return $self->[0]->[$i];
 } ## end sub getline
 
-sub print    ## no critic (Subroutines::ProhibitBuiltinHomonyms)
-{
+sub print {
     my ( $self, $msg ) = @_;
     my $mode = $self->[1];
     if ( $mode ne 'w' ) {

diff --git a/lib/Perl/Tidy/IOScalarArray.pm b/lib/Perl/Tidy/IOScalarArray.pm
index f654c01747bea2a161eaa1eb2013e4614047dc5f..1e5fed1fafa61bc7374ac2c29aededeb59dd5ada 100644 (file)
--- a/lib/Perl/Tidy/IOScalarArray.pm
+++ b/lib/Perl/Tidy/IOScalarArray.pm
@@ -90,8 +90,7 @@ EOM
     return $self->[0]->[$i];
 } ## end sub getline
 
-sub print    ## no critic (Subroutines::ProhibitBuiltinHomonyms)
-{
+sub print {
     my ( $self, $msg ) = @_;
     my $mode = $self->[1];
     if ( $mode ne 'w' ) {