nickometer and verstats: sort descendingly

nickometer: fix undefined warning

git-svn-id: https://svn.code.sf.net/p/infobot/code/trunk/blootbot@288 c11ca15a-4712-0410-83d8-924469b57eb5

diff --git a/src/CommandStubs.pl b/src/CommandStubs.pl
index 4495e10e2fd9e9a216cd96fde377fdd29900b555..a9b27f9befa8a369fdca74cb2a2b3a3c4e6db632 100644 (file)
--- a/src/CommandStubs.pl
+++ b/src/CommandStubs.pl
@@ -296,23 +296,22 @@ sub Modules {
            # step 1.
            my %nickometer;
            foreach (keys %{ $channels{lc $term}{''} }) {
-               my $value = &nickometer($_);
-
-               if (!defined $value) {
-                   &WARN("nickometer: value is undefined.");
+               my $str   = $_;
+               if (!defined $str) {
+                   &WARN("nickometer: nick in chan $term undefined?");
                    next;
                }
-               &DEBUG("value => $value.");
 
+               my $value = &nickometer($str);
                $nickometer{$value}{$_} = 1;
            }
 
            # step 2.
            ### TODO: compact with map?
            my @list;
-           foreach (sort {$a <=> $b} keys %nickometer) {
+           foreach (sort {$b <=> $a} keys %nickometer) {
                my $str = join(", ", sort keys %{$nickometer{$_}});
-               push(@list, "$str ($_ %)");
+               push(@list, "$str ($_%)");
            }
 
            &pSReply( &formListReply(0, "Nickometer list for $term ", @list) );
@@ -698,12 +697,12 @@ sub do_verstats {
                &WARN("sorted{$perc} already exists; FIXME.");
            }
 
-           $sorted{$perc} = "$_ - $count ($perc %)";
+           $sorted{$perc} = "$_ - $count ($perc%)";
        }
 
        ### can be compressed to a map?
        my @list;
-       foreach ( sort { $a <=> $b } keys %sorted ) {
+       foreach ( sort { $b <=> $a } keys %sorted ) {
            push(@list, $sorted{$_});
        }