[project @ 2002-10-31 01:53:21 by cjwatson]

Stop using $`, $&, and $' in urlsanit() and htmlsanit().

diff --git a/cgi/common.pl b/cgi/common.pl
index d4139ce616b061dfb64be0de8ca9404b29a24c53..1d42b72058ebef83ede5f5290adc0452b4c6aeb0 100644 (file)
--- a/cgi/common.pl
+++ b/cgi/common.pl
@@ -217,25 +217,15 @@ sub urlsanit {
     $url =~ s/%/%25/g;
     $url =~ s/\+/%2b/g;
     my %saniarray = ('<','lt', '>','gt', '&','amp', '"','quot');
-    my $out;
-    while ($url =~ m/[<>&"]/) {
-        $out .= $`. '&'. $saniarray{$&}. ';';
-        $url = $';
-    }
-    $out .= $url;
-    return $out;
+    $url =~ s/([<>&"])/\&$saniarray{$1};/g;
+    return $url;
 }
 
 sub htmlsanit {
     my %saniarray = ('<','lt', '>','gt', '&','amp', '"','quot');
     my $in = shift || "";
-    my $out;
-    while ($in =~ m/[<>&"]/) {
-        $out .= $`. '&'. $saniarray{$&}. ';';
-        $in = $';
-    }
-    $out .= $in;
-    return $out;
+    $in =~ s/([<>&"])/\&$saniarray{$1};/g;
+    return $in;
 }
 
 sub bugurl {