* lily/include/music.hh (class Music): include SCM init argument.

* scripts/convert-ly.py (conv): add  # to \property scalar value.

* mf/GNUmakefile: don't install *list.ly

diff --git a/ChangeLog b/ChangeLog
index d31742fd33674cb0372975b142232873f6e75195..6fb9437fa3cf677f25d9a37dbab0e83e082bf0da 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2005-01-14  Han-Wen Nienhuys  <hanwen@xs4all.nl>
+
+       * lily/include/music.hh (class Music): include SCM init argument.
+
+       * scripts/convert-ly.py (conv): add  # to \property scalar value.
+
+       * mf/GNUmakefile: don't install *list.ly
+
 2005-01-14  Jan Nieuwenhuizen  <janneke@gnu.org>
 
        * mf/GNUmakefile (CFF_FILES): Bugfix: only big cheeses and braces.

diff --git a/lily/event.cc b/lily/event.cc
index cd803f87c0e0fbc17e40cf2b511fa412998b35c0..5e93cb84c9ee15e12afa10cb770ab89623f80444 100644 (file)
--- a/lily/event.cc
+++ b/lily/event.cc
@@ -59,13 +59,17 @@ Event::to_relative_octave (Pitch last)
   return last;
 }
   
-Event::Event ()
-  : Music ()
+Event::Event (SCM i)
+  : Music (i)
 {
 }
 
 ADD_MUSIC (Event);
 
+Key_change_ev::Key_change_ev (SCM x)
+  : Event (x)
+{
+}
 void
 Key_change_ev::transpose (Pitch p)
 {

diff --git a/lily/grace-music.cc b/lily/grace-music.cc
index 60599ebcf7ce66b9c6f2533120c0a11215b26a6e..8acff1974740e96e0ca539f4a92f672504c590d5 100644 (file)
--- a/lily/grace-music.cc
+++ b/lily/grace-music.cc
@@ -27,10 +27,9 @@ Grace_music::start_mom () const
   return gl;
 }
 
-Grace_music::Grace_music ()
+Grace_music::Grace_music (SCM x)
+  : Music_wrapper (x)
 {
-  set_property ("iterator-ctor",
-               Grace_iterator::constructor_proc);
 }
 
 ADD_MUSIC (Grace_music);

diff --git a/lily/include/event.hh b/lily/include/event.hh
index 6365b16c8631e168f1c24ad890c29e252225963d..a50e397c4c2988d3696fb50ff214fa5077e7f27b 100644 (file)
--- a/lily/include/event.hh
+++ b/lily/include/event.hh
@@ -20,7 +20,7 @@
 class Event : public Music
 {
 public:
-  Event ();
+  Event (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Event);
   virtual void compress (Moment);
   virtual Moment get_length () const;
@@ -34,6 +34,7 @@ public:
 class Key_change_ev  : public Event
 {
 public:
+  Key_change_ev (SCM);
   SCM pitch_alist ();
   
 protected:

diff --git a/lily/include/grace-music.hh b/lily/include/grace-music.hh
index 63532de6f2f92ee815a390d06ed8705e67c5f804..ea1eaf34143d8fcebb86df5734e8680ac9abb34f 100644 (file)
--- a/lily/include/grace-music.hh
+++ b/lily/include/grace-music.hh
@@ -16,7 +16,7 @@ class Grace_music : public Music_wrapper
 {
 public:
   VIRTUAL_COPY_CONSTRUCTOR (Music, Grace_music);
-  Grace_music ();
+  Grace_music (SCM);
 protected:
   virtual Moment get_length () const;
   virtual Moment start_mom () const;

diff --git a/lily/include/lyric-combine-music.hh b/lily/include/lyric-combine-music.hh
index 566dc9a93f735b75eeb836eb27a9ee89badd55ed..0643f820de7352986a78b4bc9d6e14ca6a0012ce 100644 (file)
--- a/lily/include/lyric-combine-music.hh
+++ b/lily/include/lyric-combine-music.hh
@@ -15,7 +15,7 @@
 class Lyric_combine_music : public Music
 {
 public:
-  Lyric_combine_music ();
+  Lyric_combine_music (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Lyric_combine_music);
 
   Music *get_music () const;

diff --git a/lily/include/music-constructor.hh b/lily/include/music-constructor.hh
index ae20fca36beb5275650e0e32dcc89dac26463ad0..c059abfdc7b3975964825f39b9970edae6cbbec3 100644 (file)
--- a/lily/include/music-constructor.hh
+++ b/lily/include/music-constructor.hh
@@ -10,22 +10,22 @@
 #ifndef MUSIC_CONSTRUCTOR_HH
 #define MUSIC_CONSTRUCTOR_HH
 
-#include "lily-proto.hh"
+#include "lily-guile.hh"
 #include "string.hh"
 #include "global-ctor.hh"
 
 #define ADD_MUSIC(type) \
-Music * _ ## type ## _ctor ()\
+Music * _ ## type ## _ctor (SCM init)\
 {\
-  return new type;\
+  return new type (init);\
 }\
 static void  _ ## type ## _adder () {\
       add_music_ctor (#type, & _ ## type ## _ctor);\
 }\
 ADD_SCM_INIT_FUNC( _ ## type ## _adder_prefix,  _ ## type ## _adder);
 
-void add_music_ctor (String, Music* (*) ());
-Music*make_music (String);
+void add_music_ctor (String, Music* (*) (SCM));
+Music*make_music (String, SCM);
 
 
 

diff --git a/lily/include/music-list.hh b/lily/include/music-list.hh
index c77cccd70f25f77237b5f9a6e86015d2de80d4a1..523fef4464d9ee1377748579c90dcaa94e4e4fd9 100644 (file)
--- a/lily/include/music-list.hh
+++ b/lily/include/music-list.hh
@@ -18,7 +18,7 @@
 class Simultaneous_music : public Music_sequence
 {
 public:
-  Simultaneous_music ();
+  Simultaneous_music (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Simultaneous_music);
 
   virtual Pitch to_relative_octave (Pitch);
@@ -34,6 +34,7 @@ class Event_chord : public Simultaneous_music
 public:
   VIRTUAL_COPY_CONSTRUCTOR (Music, Event_chord);
   virtual Pitch to_relative_octave (Pitch);
+  Event_chord (SCM);
 };
 
 /**
@@ -46,7 +47,7 @@ public:
   virtual Moment get_length () const;
   virtual Moment start_mom () const;
   
-  Sequential_music ();
+  Sequential_music (SCM);
 };
 
 #endif /* MUSIC_LIST_HH */

diff --git a/lily/include/music-sequence.hh b/lily/include/music-sequence.hh
index 01753fd41ab6d7d1bfe4965647dabd8fbcad1708..c1c307b1ec36ebfd63fd45530a6286d7054f84f6 100644 (file)
--- a/lily/include/music-sequence.hh
+++ b/lily/include/music-sequence.hh
@@ -17,11 +17,9 @@ class Music_sequence : public Music
 {
 public:
   Music_sequence (SCM h);
-  Music_sequence ();
   VIRTUAL_COPY_CONSTRUCTOR (Music, Music_sequence);
 
   SCM music_list () const;
-  void append_music (Music *);
   
   Pitch do_relative_octave (Pitch p, bool b);
   

diff --git a/lily/include/music.hh b/lily/include/music.hh
index 60baeb72e83478d13dca8e0a2687d22a72bb3b56..a9a60cbe6bbf66f7521441128991948cdb84ee12 100644 (file)
--- a/lily/include/music.hh
+++ b/lily/include/music.hh
@@ -31,7 +31,7 @@
 class Music
 {
 public:
-  Music ();
+  Music (SCM init);
   Music (Music const &m);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Music);
 

diff --git a/lily/include/relative-music.hh b/lily/include/relative-music.hh
index eebc43e4f120af2247072584b95860ca7eac8264..17f0f5721b5734359b969ca3fb1cb679f5b09fcc 100644 (file)
--- a/lily/include/relative-music.hh
+++ b/lily/include/relative-music.hh
@@ -15,7 +15,7 @@
 class Relative_octave_music : public Music_wrapper
 {
 public:
-  Relative_octave_music ();
+  Relative_octave_music (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Relative_octave_music);
 
   virtual Pitch to_relative_octave (Pitch);

diff --git a/lily/include/relative-octave-check.hh b/lily/include/relative-octave-check.hh
index 72cf3e2a1268a2f503cc8bc5f57fc4ad368f16a7..ae3b9adb06ee3d90381b4560987fbed8e9081d67 100644 (file)
--- a/lily/include/relative-octave-check.hh
+++ b/lily/include/relative-octave-check.hh
@@ -15,6 +15,7 @@
 class Relative_octave_check : public Music
 {
 public:
+  Relative_octave_check (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Relative_octave_check);
 
   virtual Pitch to_relative_octave (Pitch);

diff --git a/lily/include/repeated-music.hh b/lily/include/repeated-music.hh
index e84b1d2fbc8e9f1be45439e644cc8b587d6bb52b..a61dd75fd2b4c756949227478e374dcf74fdbbb0 100644 (file)
--- a/lily/include/repeated-music.hh
+++ b/lily/include/repeated-music.hh
@@ -49,7 +49,6 @@
 class Repeated_music : public Music
 {
 public:
-  Repeated_music ();
   Repeated_music (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Repeated_music);
 

diff --git a/lily/include/transposed-music.hh b/lily/include/transposed-music.hh
index d355fb045a6a8d39a47b2da131bf3b673570846a..2642531475f85d0813ece035bc8f3104eedc6ee7 100644 (file)
--- a/lily/include/transposed-music.hh
+++ b/lily/include/transposed-music.hh
@@ -15,7 +15,6 @@
 class Transposed_music : public Music_wrapper
 {
 public:
-  Transposed_music ();
   Transposed_music (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Transposed_music);
 

diff --git a/lily/include/un-relativable-music.hh b/lily/include/un-relativable-music.hh
index b927a8a133a5a1094d6aff06fc4a4b53f32bf7ce..09460a9ab39993fb462f352338262364132c3b6a 100644 (file)
--- a/lily/include/un-relativable-music.hh
+++ b/lily/include/un-relativable-music.hh
@@ -15,7 +15,7 @@
 class Un_relativable_music: public Music_wrapper
 {
 public:
-  Un_relativable_music ();
+  Un_relativable_music (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Un_relativable_music);
 
   Pitch to_relative_octave (Pitch);

diff --git a/lily/include/untransposable-music.hh b/lily/include/untransposable-music.hh
index f5a4a9f5db9ba3974b17240d02b105e4d2b6a3b5..7e88a21b07aa22aa2a07c293c91616d6aa667846 100644 (file)
--- a/lily/include/untransposable-music.hh
+++ b/lily/include/untransposable-music.hh
@@ -15,7 +15,7 @@
 class Untransposable_music : public Music_wrapper
 {
 public:
-  Untransposable_music ();
+  Untransposable_music (SCM);
   VIRTUAL_COPY_CONSTRUCTOR (Music, Untransposable_music);
 
   virtual Pitch to_relative_octave (Pitch);

diff --git a/lily/lyric-combine-music.cc b/lily/lyric-combine-music.cc
index 82f1e56de7eba7cd5299ec13c0c7eab07375c6f2..98777b1dd741626aadc52f0d3ea617b157d09288 100644 (file)
--- a/lily/lyric-combine-music.cc
+++ b/lily/lyric-combine-music.cc
@@ -11,8 +11,8 @@
 
 #include "pitch.hh"
 
-Lyric_combine_music::Lyric_combine_music ()
-  : Music ()
+Lyric_combine_music::Lyric_combine_music (SCM x)
+  : Music (x)
 {
 }
 

diff --git a/lily/music-constructor.cc b/lily/music-constructor.cc
index bfa4199c91ff36268e5c3fda85842db664eca7ac..120bfef2368260469227a81897cf16e9c4d8012c 100644 (file)
--- a/lily/music-constructor.cc
+++ b/lily/music-constructor.cc
@@ -37,13 +37,13 @@ get_music_ctor (String s)
 }
 
 Music * 
-make_music (String s)
+make_music (String s, SCM init)
 {
   Music_ctor c = get_music_ctor (s);
   if (!c)
     programming_error (String ("No constructor for music: ") + s);
   assert (c);
   
-  return (*c) ();
+  return (*c) (init);
 }
 

diff --git a/lily/music-scheme.cc b/lily/music-scheme.cc
index d3d200ad090c90bd9e99f040fb7732817cdfa50c..2d1b9353523527ca927fc2c9dcdcc1d2d7c79b68 100644 (file)
--- a/lily/music-scheme.cc
+++ b/lily/music-scheme.cc
@@ -73,8 +73,7 @@ LY_DEFINE (ly_extended_make_music, "ly:make-bare-music",
          )
 {
   SCM_ASSERT_TYPE (scm_is_string (type), type, SCM_ARG1, __FUNCTION__, "string");
-  SCM s = make_music (ly_scm2string (type))->self_scm ();
-  unsmob_music (s)->immutable_property_alist_ = props;
+  SCM s = make_music (ly_scm2string (type), props)->self_scm ();
   scm_gc_unprotect_object (s);
   return s;
 }

diff --git a/lily/music-sequence.cc b/lily/music-sequence.cc
index c15ebaf2dbb29a36ddd931bd0db956f09e99f4e7..35db3471c8a55e058d765973fe2702379e9fe82d 100644 (file)
--- a/lily/music-sequence.cc
+++ b/lily/music-sequence.cc
@@ -11,8 +11,8 @@
 #include "pitch.hh"
 #include "input.hh"
 
-Music_sequence::Music_sequence ()
-  : Music ()
+Music_sequence::Music_sequence (SCM x)
+  : Music (x)
 {
 }
 
@@ -22,17 +22,6 @@ Music_sequence::music_list () const
   return get_property ("elements");
 }
 
-/*
-  Ugh this sucks. Linear. do not use.
- */
-void
-Music_sequence::append_music (Music *m)
-{
-  set_property ("elements",
-               ly_append2 (music_list (), scm_cons (m->self_scm (), SCM_EOL)));
-  scm_gc_unprotect_object (m->self_scm ());
-}
-
 void
 transpose_music_list (SCM lst, Pitch rq)
 {

diff --git a/lily/music.cc b/lily/music.cc
index 3ce9c302ce7b6331693784a170cd686c674c2a11..4e98b61775fb867c4aa4b4111faef2e3d073d197 100644 (file)
--- a/lily/music.cc
+++ b/lily/music.cc
@@ -39,10 +39,10 @@ Music::name () const
     }
 }
 
-Music::Music ()
+Music::Music (SCM init)
 {
   self_scm_ = SCM_EOL;
-  immutable_property_alist_ = SCM_EOL;
+  immutable_property_alist_ = init;
   mutable_property_alist_ = SCM_EOL;
   smobify_self ();
 }

diff --git a/lily/relative-octave-check.cc b/lily/relative-octave-check.cc
index ee22516c07732a455509597ebd1ed63c013647eb..f751dc1e241f327b228ca0b74be6daf7e2bb01eb 100644 (file)
--- a/lily/relative-octave-check.cc
+++ b/lily/relative-octave-check.cc
@@ -1,12 +1,17 @@
+/*
+  relative-octave-check.cc --  implement Relative_octave_check
+
+  source file of the GNU LilyPond music typesetter
+
+  (c) 2005 Han-Wen Nienhuys <hanwen@xs4all.nl>
+
+*/
+
 #include "relative-octave-check.hh"
 
 #include "input.hh"
 #include "pitch.hh"
 
-/*
-  yeah, so this should be in a separate file.
-  I'm lazy.
- */
 Pitch
 Relative_octave_check::to_relative_octave (Pitch p)
 {
@@ -36,4 +41,10 @@ Relative_octave_check::to_relative_octave (Pitch p)
                 p.get_notename (), p.get_alteration ());
 }
 
+
+Relative_octave_check::Relative_octave_check (SCM x)
+  : Music (x)
+{
+}
+
 ADD_MUSIC (Relative_octave_check);

diff --git a/lily/relative-octave-music.cc b/lily/relative-octave-music.cc
index bc723df7239c8a859379a275b442f8876586ca8a..afe6b4a29a5ca04af2b9b572e32d48cd000c7d8d 100644 (file)
--- a/lily/relative-octave-music.cc
+++ b/lily/relative-octave-music.cc
@@ -31,8 +31,10 @@ Relative_octave_music::to_relative_octave (Pitch p)
 }
 
 
-Relative_octave_music::Relative_octave_music ()
+Relative_octave_music::Relative_octave_music (SCM x)
+  : Music (x)
 {
+  
 }
 
 ADD_MUSIC (Relative_octave_music);

diff --git a/lily/repeated-music.cc b/lily/repeated-music.cc
index 6cf1ff9ce90a9da6a6ba1e18f095f1168f6acf97..f145ecfe36c1e108498d31a63271239362e2ae94 100644 (file)
--- a/lily/repeated-music.cc
+++ b/lily/repeated-music.cc
@@ -26,9 +26,6 @@ Repeated_music::alternatives ()const
   return get_property ("elements");
 }
 
-
-
-
 Pitch
 Repeated_music::to_relative_octave (Pitch p)
 {
@@ -152,8 +149,8 @@ Repeated_music::volta_music_length (SCM m)
 
 ADD_MUSIC (Repeated_music);
 
-Repeated_music::Repeated_music ()
-  : Music ()
+Repeated_music::Repeated_music (SCM x)
+  : Music (x)
 {
 }
 

diff --git a/lily/simultaneous-music.cc b/lily/simultaneous-music.cc
index ccf3287ab511202b73d61e397522acc1e7909834..4f67bceb1cce1031525f4ccbe6ed9a0d36e26e70 100644 (file)
--- a/lily/simultaneous-music.cc
+++ b/lily/simultaneous-music.cc
@@ -24,7 +24,8 @@ Simultaneous_music::start_mom () const
   return Music_sequence::minimum_start (get_property ("elements"));
 }
 
-Simultaneous_music::Simultaneous_music ()
+Simultaneous_music::Simultaneous_music (SCM x)
+  : Music (x)
 {
 
 }

diff --git a/lily/transposed-music.cc b/lily/transposed-music.cc
index d2c1166a2128a7f58c121b54c9f7f7b2eab57ebe..6be20ce65c2166a1436fc824cf4f22d4e3327eaf 100644 (file)
--- a/lily/transposed-music.cc
+++ b/lily/transposed-music.cc
@@ -18,7 +18,9 @@ Transposed_music::to_relative_octave (Pitch p)
 }
 
 ADD_MUSIC (Transposed_music);
-Transposed_music::Transposed_music ()
+
+Transposed_music::Transposed_music (SCM x)
+  : Music (x)
 {
 
 }

diff --git a/lily/un-relativable-music.cc b/lily/un-relativable-music.cc
index 1d0f0271d64547347b3da0faba98a9d1987c80aa..9253272ecf69d07f8003780f9efeebc6e8ca39e8 100644 (file)
--- a/lily/un-relativable-music.cc
+++ b/lily/un-relativable-music.cc
@@ -9,7 +9,8 @@
 
 #include "un-relativable-music.hh"
 
-Un_relativable_music::Un_relativable_music ( )
+Un_relativable_music::Un_relativable_music (SCM x)
+  : Music (x)
 {
 }
 

diff --git a/lily/untransposable-music.cc b/lily/untransposable-music.cc
index 754ad9733316807f52c99aa394ab542a1879a1e8..02ef66debef553f4faac378692ba5630a474aa39 100644 (file)
--- a/lily/untransposable-music.cc
+++ b/lily/untransposable-music.cc
@@ -15,7 +15,7 @@ source file of the GNU LilyPond music typesetter
   fixthis.
 */
 void
-Untransposable_music::transpose (Pitch )
+Untransposable_music::transpose (Pitch)
 {
 }
 
@@ -27,7 +27,8 @@ Untransposable_music::to_relative_octave (Pitch p)
 
 ADD_MUSIC (Untransposable_music);
 
-Untransposable_music::Untransposable_music ()
+Untransposable_music::Untransposable_music (SCM init)
+  : Music_wrapper (init)
 {
 
 }

diff --git a/mf/GNUmakefile b/mf/GNUmakefile
index 951c5bc340a57860d431feb7a09b4746718a41cc..265fa8cf826977285adaca0aa18d1c0a63829b47 100644 (file)
--- a/mf/GNUmakefile
+++ b/mf/GNUmakefile
@@ -85,7 +85,7 @@ ALL_GEN_FILES= $(TFM_FILES) $(TEXTABLES) $(TFM_FILES) $(LOG_FILES) $(ENC_FILES)
 INSTALLATION_DIR=$(local_lilypond_datadir)/fonts/source
 INSTALLATION_FILES=$(MF_FILES) $(AF_FILES)
 
-INSTALLATION_OUT_SUFFIXES=1 2 3 4 5 6 7 8 9
+INSTALLATION_OUT_SUFFIXES=1 2 3 5 6 7 8 9
 
 INSTALLATION_OUT_DIR1=$(local_lilypond_datadir)/tex
 INSTALLATION_OUT_FILES1=$(TEXTABLES)
@@ -97,9 +97,6 @@ INSTALLATION_OUT_FILES2=$(OTF_FILES)
 INSTALLATION_OUT_DIR3=$(local_lilypond_datadir)/fonts/tfm
 INSTALLATION_OUT_FILES3=$(TFM_FILES)
 
-INSTALLATION_OUT_DIR4=$(local_lilypond_datadir)/ly
-INSTALLATION_OUT_FILES4=$(FETA_LIST_FILES)
-
 INSTALLATION_OUT_DIR5=$(local_lilypond_datadir)/fonts/type1
 INSTALLATION_OUT_FILES5=$(PFA_FILES)
 

diff --git a/scm/define-music-types.scm b/scm/define-music-types.scm
index 57d4acf8dde7f157d05835c0f75966d211f7c17b..c3ac9e8856c058514da0bf82717d73b4b2194b9f 100644 (file)
--- a/scm/define-music-types.scm
+++ b/scm/define-music-types.scm
@@ -198,7 +198,6 @@ Syntax: @var{note}\\cr
     (GraceMusic
      . (
        (description .  "Interpret the argument as grace notes. ")
-
        (internal-class-name . "Grace_music")
        (iterator-ctor . ,Grace_iterator::constructor)
        (types . (grace-music music-wrapper-music general-music))

diff --git a/scripts/convert-ly.py b/scripts/convert-ly.py
index 2384587e6f90b1b0d6a92c1e14fe2a48d33c8802..13f009a7321c44e754b4cdc1efc21969af1fd07c 100644 (file)
--- a/scripts/convert-ly.py
+++ b/scripts/convert-ly.py
@@ -1840,6 +1840,8 @@ Grob::preset_extent removed.
 
 
 def conv (str):
+       str = re.sub (r'(\\property[^=]+)=\s*([-0-9]+)',
+                     r'\1= #\2', str) 
        str = re.sub (r'\\property\s+([^. ]+)\s*\.\s*([^\\=]+)\s*\\(set|override)',
                      r"\\overrid@ \1.\2 ", str)
        str = re.sub (r'\\property\s+([^. ]+)\s*\.\s*([^\\= ]+)\s*=\s*',
@@ -2242,6 +2244,17 @@ conversions.append (((2, 3, 23),
                     conv,
                     '''\context Foo = NOTENAME -> \context Foo = "NOTENAME"'''))
 
+def conv (str):
+       def sub(m):
+               return regularize_id (m.group (1))
+       str = re.sub (r'(maintainer_email|maintainer_web|midi_stuff|gourlay_maxmeasures)',
+                     sub, str)
+       return str
+
+conversions.append (((2, 3, 24),
+                    conv,
+                    '''regularize other identifiers.'''))
+
 
 def conv (str):
        return str

diff --git a/stepmake/stepmake/install-targets.make b/stepmake/stepmake/install-targets.make
index 0eaa54f4a06747d834cd7fc0b7b1d8f1d751c40d..762a509b4e837977208df4a58f421c78e6aaa2b3 100644 (file)
--- a/stepmake/stepmake/install-targets.make
+++ b/stepmake/stepmake/install-targets.make
@@ -7,12 +7,12 @@ local-install-outfiles:
 local-install-files: $(INSTALLATION_FILES)
        $(PRE_INSTALL)
        -$(INSTALL) -d $(INSTALLATION_DIR)
-       $(foreach i,  $(INSTALLATION_FILES),\
-               $(INSTALL) -m 644 $(i) $(INSTALLATION_DIR)/ &&)true
+       for i in $(INSTALLATION_FILES); do \
+               $(INSTALL) -m 644 $$i $(INSTALLATION_DIR)/ ; done
        $(foreach suff, $(INSTALLATION_SUFFIXES),  \
                ($(INSTALL) -d $(INSTALLATION_DIR$(suff)) || true) && \
-               $(foreach i, $(INSTALLATION_FILES$(suff)), \
-                       $(INSTALL) -m 644 $(i) $(INSTALLATION_DIR$(suff))/  && )  && ) true
+               for i in $(INSTALLATION_FILES$(suff)); do \
+                       $(INSTALL) -m 644 $$i $(INSTALLATION_DIR$(suff))/; done )
        $(POST_INSTALL)
 
 local-uninstall: local-uninstall-outfiles local-uninstall-files