]> git.donarmstrong.com Git - qmk_firmware.git/commitdiff
Fix enables for Haptic Feedback (#6707)
authorDrashna Jaelre <drashna@live.com>
Sun, 15 Sep 2019 02:57:07 +0000 (19:57 -0700)
committerGitHub <noreply@github.com>
Sun, 15 Sep 2019 02:57:07 +0000 (19:57 -0700)
* Fix enables for Haptic Feedback

If you enabled bothe DRV2605 and SOLENOID, it would only enable one of these, not both.

This fixes the check so that you can enable both options.

* Fix check for haptic feature

common_features.mk

index 3bc6f1c73bfe460e3f624aedd806cd65f90b8420..79af8a2256c923241b5189e3f8b2e760ad8a431c 100644 (file)
@@ -267,20 +267,21 @@ ifeq ($(strip $(ENCODER_ENABLE)), yes)
     OPT_DEFS += -DENCODER_ENABLE
 endif
 
-ifeq ($(strip $(HAPTIC_ENABLE)), DRV2605L)
-    COMMON_VPATH += $(DRIVER_PATH)/haptic
-    SRC += haptic.c
+HAPTIC_ENABLE ?= no
+ifneq ($(strip $(HAPTIC_ENABLE)),no)
+       COMMON_VPATH += $(DRIVER_PATH)/haptic
+       SRC += haptic.c
+       OPT_DEFS += -DHAPTIC_ENABLE
+endif
+
+ifneq ($(filter DRV2605L, $(HAPTIC_ENABLE)), )
     SRC += DRV2605L.c
     QUANTUM_LIB_SRC += i2c_master.c
-    OPT_DEFS += -DHAPTIC_ENABLE
     OPT_DEFS += -DDRV2605L
 endif
 
-ifeq ($(strip $(HAPTIC_ENABLE)), SOLENOID)
-    COMMON_VPATH += $(DRIVER_PATH)/haptic
-    SRC += haptic.c
+ifneq ($(filter SOLENOID, $(HAPTIC_ENABLE)), )
     SRC += solenoid.c
-    OPT_DEFS += -DHAPTIC_ENABLE
     OPT_DEFS += -DSOLENOID_ENABLE
 endif