revert change of instrumentTransposition definition. Document why.

diff --git a/lily/note-performer.cc b/lily/note-performer.cc
index a5b4afce87f35d2d430ab8dd85722ef1a5bc471e..6bfc82211b73724e7104fa121558bfb903b06776 100644 (file)
--- a/lily/note-performer.cc
+++ b/lily/note-performer.cc
@@ -66,7 +66,7 @@ Note_performer::process_music ()
                 }
 
              Audio_note *p = new Audio_note (*pitp, get_event_length (n), 
-                                              tie_event, transposing);
+                                              tie_event, transposing.negated ());
              Audio_element_info info (p, n);
              announce_element (info);
              notes_.push_back (p);

diff --git a/ly/music-functions-init.ly b/ly/music-functions-init.ly
index 9baec24ae30dc97bed4ac97183438ebc448ba155..05ed471320d93d629567448e51ef7afe8a035df8 100644 (file)
--- a/ly/music-functions-init.ly
+++ b/ly/music-functions-init.ly
@@ -599,7 +599,7 @@ as a first or second voice."
              'quoted-context-id "cue"
              'quoted-music-name what
              'quoted-voice-direction dir
-             'quoted-transposition (ly:pitch-negate (pitch-of-note pitch-note))
+             'quoted-transposition (pitch-of-note pitch-note)
              'origin location))
 
 
@@ -610,9 +610,8 @@ transposition =
 
    (context-spec-music
     (make-property-set 'instrumentTransposition
-                      (pitch-of-note pitch-note))
-        'Staff
-))
+                      (ly:pitch-negate (pitch-of-note pitch-note)))
+        'Staff))
 
 tweak = #(define-music-function (parser location sym val arg)
           (symbol? scheme? ly:music?)

diff --git a/scm/define-context-properties.scm b/scm/define-context-properties.scm
index 16dddf3e7e121eca16f48d68cf0fe660b7f89e9c..43a738d6ae25a2a6241aaad830af50a63785d91e 100644 (file)
--- a/scm/define-context-properties.scm
+++ b/scm/define-context-properties.scm
@@ -260,10 +260,13 @@ the @code{instr} property labels following lines.")
      (instrumentEqualizer ,procedure? "
 Function taking a string (instrument name), and returning a (@var{min} . @var{max}) pair of numbers for the loudness range of the instrument.
 ")
+
+     ;; the definition is reversed wrt  traditional transposition
+     ;; this because \transpose { \transposition .. } won't work
+     ;; otherwise.
      (instrumentTransposition ,ly:pitch? "Defines the transposition of
-the instrument. Its value is the pitch that sounds when the instrument
-plays written middle C.  This is used to transpose the MIDI output,
-and @code{\\quote}s.")
+the instrument. Its value is the pitch that sounds like middle C. This
+is used to transpose the MIDI output, and @code{\\quote}s.")
 
      (internalBarNumber ,integer? "Contains the current barnumber. This property is used for internal timekeeping, among others by the @code{Accidental_engraver}.")