]> git.donarmstrong.com Git - qmk_firmware.git/commitdiff
Fix warnings in process_printer
authorFred Sundvik <fsundvik@gmail.com>
Mon, 10 Apr 2017 07:36:09 +0000 (10:36 +0300)
committerFred Sundvik <fsundvik@gmail.com>
Thu, 13 Apr 2017 13:00:29 +0000 (16:00 +0300)
quantum/process_keycode/process_printer.c
quantum/process_keycode/process_printer.h
quantum/process_keycode/process_printer_bb.c

index 807f7a0b91a82d41473deedc0727361fc297d55c..613af70183b9cd677bff8ed102d97f499dd052e2 100644 (file)
 bool printing_enabled = false;
 uint8_t character_shift = 0;
 
-void enabled_printing() {
+void enable_printing(void) {
        printing_enabled = true;
        serial_init();
 }
 
-void disable_printing() {
+void disable_printing(void) {
        printing_enabled = false;
 }
 
@@ -41,9 +41,14 @@ void print_char(char c) {
        USB_Init();
 }
 
-void print_box_string(uint8_t text[]) {
-       uint8_t len = strlen(text);
-       uint8_t out[len * 3 + 8];
+void print_string(char c[]) {
+       for(uint8_t i = 0; i < strlen(c); i++)
+               print_char(c[i]);
+}
+
+void print_box_string(const char text[]) {
+       size_t len = strlen(text);
+       char out[len * 3 + 8];
        out[0] = 0xDA;
        for (uint8_t i = 0; i < len; i++) {
                out[i+1] = 0xC4;
@@ -69,14 +74,9 @@ void print_box_string(uint8_t text[]) {
        print_string(out); 
 }
 
-void print_string(char c[]) {
-       for(uint8_t i = 0; i < strlen(c); i++)
-               print_char(c[i]);
-}
-
 bool process_printer(uint16_t keycode, keyrecord_t *record) {
        if (keycode == PRINT_ON) {
-               enabled_printing();
+               enable_printing();
                return false;
        }
        if (keycode == PRINT_OFF) {
index aa494ac8a7f53c9e1a4ce53261094b6235eaf3bb..71d3a4b56a67521d6b3d83856add855b4b5d022a 100644 (file)
@@ -21,4 +21,6 @@
 
 #include "protocol/serial.h"
 
+bool process_printer(uint16_t keycode, keyrecord_t *record);
+
 #endif
index 55d3b552b2fbc4fc20eebf5c5cd77275407bb7cb..3a00f169d8b4d656b0f24ce626cdfce9ea047e4e 100644 (file)
@@ -46,7 +46,7 @@ void serial_output(void) {
 }
 
 
-void enabled_printing() {
+void enable_printing() {
        printing_enabled = true;
        serial_output();
        serial_high();
@@ -82,7 +82,7 @@ void print_string(char c[]) {
 
 bool process_printer(uint16_t keycode, keyrecord_t *record) {
        if (keycode == PRINT_ON) {
-               enabled_printing();
+               enable_printing();
                return false;
        }
        if (keycode == PRINT_OFF) {